Summary

General comment: web-api and tests

Review Request #6431 — Created Oct. 11, 2014 and submitted Dec. 4, 2014, 12:57 a.m.

Information

Owner

nicolexin

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

712b65f...

Reviewers

Groups

reviewboard, students

People

Description

Reviewboard currently support 3 types of comments: Diff commment, File attachment comments, Screenshot comments.
This is a new type of comments: General comments.

A general comment on a review request is used when a comment is not tied to specific lines of code or a special file attachment, and an issue is opened. Examples include suggestions for testing or pointing out errors in the change description.

The general comment model is built. (review request 6375)
This review request is for general comments web-api.

Testing Done

Add 106 tests for general comments in reviewboard/webapi/tests and all tests passed.

Issues

Description	From	Last Updated
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Oct. 11, 2014, 1:22 p.m.
Col: 5 E113 unexpected indentation	reviewbot	Oct. 11, 2014, 1:22 p.m.
Col: 9 E113 unexpected indentation	reviewbot	Oct. 11, 2014, 1:22 p.m.
Col: 17 E225 missing whitespace around operator	reviewbot	Oct. 11, 2014, 1:22 p.m.
Col: 9 E122 continuation line missing indentation or outdented	reviewbot	Oct. 11, 2014, 1:22 p.m.
Col: 5 E122 continuation line missing indentation or outdented	reviewbot	Oct. 11, 2014, 1:22 p.m.
Col: 5 E122 continuation line missing indentation or outdented	reviewbot	Oct. 11, 2014, 1:22 p.m.
Col: 47 E701 multiple statements on one line (colon)	reviewbot	Oct. 11, 2014, 1:22 p.m.
Col: 12 E701 multiple statements on one line (colon)	reviewbot	Oct. 11, 2014, 1:22 p.m.
Col: 27 E251 unexpected spaces around keyword / parameter equals	reviewbot	Oct. 11, 2014, 1:22 p.m.
Col: 29 E251 unexpected spaces around keyword / parameter equals	reviewbot	Oct. 11, 2014, 1:22 p.m.
Col: 30 E502 the backslash is redundant between brackets	reviewbot	Oct. 11, 2014, 1:22 p.m.
Col: 17 E131 continuation line unaligned for hanging indent	reviewbot	Oct. 11, 2014, 1:22 p.m.
Col: 19 E251 unexpected spaces around keyword / parameter equals	reviewbot	Oct. 11, 2014, 1:22 p.m.
Col: 21 E251 unexpected spaces around keyword / parameter equals	reviewbot	Oct. 11, 2014, 1:22 p.m.
Col: 34 E701 multiple statements on one line (colon)	reviewbot	Oct. 11, 2014, 1:22 p.m.
Col: 72 E701 multiple statements on one line (colon)	reviewbot	Oct. 11, 2014, 1:22 p.m.
Col: 20 E251 unexpected spaces around keyword / parameter equals	reviewbot	Oct. 11, 2014, 1:22 p.m.
Col: 22 E251 unexpected spaces around keyword / parameter equals	reviewbot	Oct. 11, 2014, 1:22 p.m.
Col: 13 E128 continuation line under-indented for visual indent	reviewbot	Oct. 11, 2014, 1:22 p.m.
Col: 13 E128 continuation line under-indented for visual indent	reviewbot	Oct. 11, 2014, 1:22 p.m.
Col: 13 E128 continuation line under-indented for visual indent	reviewbot	Oct. 11, 2014, 1:22 p.m.
Col: 9 E124 closing bracket does not match visual indentation	reviewbot	Oct. 11, 2014, 1:22 p.m.
Col: 5 E122 continuation line missing indentation or outdented	reviewbot	Oct. 11, 2014, 1:22 p.m.
Col: 5 E122 continuation line missing indentation or outdented	reviewbot	Oct. 11, 2014, 1:22 p.m.
Col: 5 E122 continuation line missing indentation or outdented	reviewbot	Oct. 11, 2014, 1:22 p.m.
Col: 5 E122 continuation line missing indentation or outdented	reviewbot	Oct. 11, 2014, 1:22 p.m.
Col: 9 E128 continuation line under-indented for visual indent	reviewbot	Oct. 11, 2014, 1:22 p.m.
Col: 9 E128 continuation line under-indented for visual indent	reviewbot	Oct. 11, 2014, 1:22 p.m.
Col: 5 E124 closing bracket does not match visual indentation	reviewbot	Oct. 11, 2014, 1:22 p.m.
'six' imported but unused	reviewbot	Oct. 11, 2014, 1:40 p.m.
Col: 5 E303 too many blank lines (2)	reviewbot	Oct. 11, 2014, 1:40 p.m.
local variable 'review_request' is assigned to but never used	reviewbot	Oct. 11, 2014, 1:40 p.m.
Col: 77 W291 trailing whitespace	reviewbot	Oct. 11, 2014, 1:40 p.m.
'get_general_comment_list_url' imported but unused	reviewbot	Oct. 11, 2014, 1:40 p.m.
undefined name 'get_review_general_comment_list_url'	reviewbot	Oct. 11, 2014, 1:40 p.m.
Col: 62 E127 continuation line over-indented for visual indent	reviewbot	Oct. 11, 2014, 1:40 p.m.
Col: 62 E127 continuation line over-indented for visual indent	reviewbot	Oct. 11, 2014, 1:40 p.m.
Col: 17 E126 continuation line over-indented for hanging indent	reviewbot	Oct. 11, 2014, 1:40 p.m.
Col: 37 E127 continuation line over-indented for visual indent	reviewbot	Oct. 11, 2014, 1:40 p.m.
Col: 44 E127 continuation line over-indented for visual indent	reviewbot	Oct. 11, 2014, 1:40 p.m.
Col: 50 E127 continuation line over-indented for visual indent	reviewbot	Oct. 11, 2014, 1:40 p.m.
These don't really make any sense. The only filtering in here should be the review__isnull one, and then ReviewGeneralCommentResource and …	david	Oct. 18, 2014, 3:07 p.m.
This should probably be pulled out into a separate review request.	david	Oct. 29, 2014, 2:11 p.m.
This resource shouldn't be necessary, because the only "object" that general comments will be attached to will be the review …	david	Oct. 18, 2014, 3:07 p.m.
Please revert this change.	david	Oct. 29, 2014, 2:11 p.m.
Why did you add this?	david	Oct. 29, 2014, 2:11 p.m.
Why did you add this?	david	Oct. 29, 2014, 2:11 p.m.
Typo: 'genral'	david	Oct. 18, 2014, 3:11 p.m.
This resource definitely does support items.	david	Oct. 25, 2014, 6:37 p.m.
Col: 17 E126 continuation line over-indented for hanging indent	reviewbot	Oct. 11, 2014, 1:50 p.m.
Col: 56 W292 no newline at end of file	reviewbot	Oct. 18, 2014, 3:31 p.m.
Col: 46 E127 continuation line over-indented for visual indent	reviewbot	Oct. 18, 2014, 3:31 p.m.
Col: 50 E127 continuation line over-indented for visual indent	reviewbot	Oct. 18, 2014, 3:31 p.m.
undefined name 'CommentItemMixin'	reviewbot	Oct. 18, 2014, 3:31 p.m.
undefined name 'ReviewRequestChildItemMixin'	reviewbot	Oct. 18, 2014, 3:31 p.m.
undefined name 'get_review_general_comment_item_url'	reviewbot	Oct. 18, 2014, 3:31 p.m.
undefined name 'general_comment_item_mimetype'	reviewbot	Oct. 18, 2014, 3:31 p.m.
undefined name 'get_review_general_comment_item_url'	reviewbot	Oct. 18, 2014, 3:31 p.m.
undefined name 'get_review_general_comment_item_url'	reviewbot	Oct. 18, 2014, 3:31 p.m.
undefined name 'get_review_general_comment_item_url'	reviewbot	Oct. 18, 2014, 3:31 p.m.
undefined name 'general_comment_item_mimetype'	reviewbot	Oct. 18, 2014, 3:31 p.m.
undefined name 'get_review_general_comment_item_url'	reviewbot	Oct. 18, 2014, 3:31 p.m.
Col: 56 E127 continuation line over-indented for visual indent	reviewbot	Oct. 18, 2014, 3:31 p.m.
undefined name 'general_comment_item_mimetype'	reviewbot	Oct. 18, 2014, 3:31 p.m.
Col: 17 E126 continuation line over-indented for hanging indent	reviewbot	Oct. 18, 2014, 3:21 p.m.
undefined name 'GeneralComment'	reviewbot	Oct. 18, 2014, 3:31 p.m.
undefined name 'get_review_general_comment_item_url'	reviewbot	Oct. 18, 2014, 3:31 p.m.
undefined name 'general_comment_item_mimetype'	reviewbot	Oct. 18, 2014, 3:31 p.m.
undefined name 'get_review_general_comment_item_url'	reviewbot	Oct. 18, 2014, 3:31 p.m.
undefined name 'general_comment_item_mimetype'	reviewbot	Oct. 18, 2014, 3:31 p.m.
undefined name 'get_review_general_comment_item_url'	reviewbot	Oct. 18, 2014, 3:31 p.m.
undefined name 'general_comment_item_mimetype'	reviewbot	Oct. 18, 2014, 3:31 p.m.
undefined name 'User'	reviewbot	Oct. 18, 2014, 3:32 p.m.
undefined name 'get_review_general_comment_item_url'	reviewbot	Oct. 18, 2014, 3:32 p.m.
undefined name 'general_comment_item_mimetype'	reviewbot	Oct. 18, 2014, 3:32 p.m.
undefined name 'User'	reviewbot	Oct. 18, 2014, 3:32 p.m.
undefined name 'get_review_general_comment_item_url'	reviewbot	Oct. 18, 2014, 3:32 p.m.
undefined name 'PERMISSION_DENIED'	reviewbot	Oct. 18, 2014, 3:32 p.m.
Col: 17 E126 continuation line over-indented for hanging indent	reviewbot	Oct. 18, 2014, 3:32 p.m.
undefined name 'CommentListMixin'	reviewbot	Oct. 25, 2014, 6:12 p.m.
undefined name 'get_review_general_comment_item_url'	reviewbot	Oct. 25, 2014, 6:12 p.m.
undefined name 'general_comment_item_mimetype'	reviewbot	Oct. 25, 2014, 6:12 p.m.
undefined name 'get_review_general_comment_item_url'	reviewbot	Oct. 25, 2014, 6:12 p.m.
undefined name 'get_review_general_comment_item_url'	reviewbot	Oct. 25, 2014, 6:12 p.m.
undefined name 'get_review_general_comment_item_url'	reviewbot	Oct. 25, 2014, 6:12 p.m.
undefined name 'general_comment_item_mimetype'	reviewbot	Oct. 25, 2014, 6:12 p.m.
undefined name 'get_review_general_comment_item_url'	reviewbot	Oct. 25, 2014, 6:12 p.m.
undefined name 'general_comment_item_mimetype'	reviewbot	Oct. 25, 2014, 6:12 p.m.
Col: 17 E126 continuation line over-indented for hanging indent	reviewbot	Oct. 25, 2014, 6:12 p.m.
undefined name 'GeneralComment'	reviewbot	Oct. 25, 2014, 6:12 p.m.
undefined name 'get_review_general_comment_item_url'	reviewbot	Oct. 25, 2014, 6:12 p.m.
undefined name 'general_comment_item_mimetype'	reviewbot	Oct. 25, 2014, 6:12 p.m.
undefined name 'get_review_general_comment_item_url'	reviewbot	Oct. 25, 2014, 6:12 p.m.
undefined name 'general_comment_item_mimetype'	reviewbot	Oct. 25, 2014, 6:12 p.m.
undefined name 'get_review_general_comment_item_url'	reviewbot	Oct. 25, 2014, 6:12 p.m.
undefined name 'general_comment_item_mimetype'	reviewbot	Oct. 25, 2014, 6:13 p.m.
undefined name 'get_review_general_comment_item_url'	reviewbot	Oct. 25, 2014, 6:13 p.m.
undefined name 'general_comment_item_mimetype'	reviewbot	Oct. 25, 2014, 6:13 p.m.
undefined name 'get_review_general_comment_item_url'	reviewbot	Oct. 25, 2014, 6:13 p.m.
undefined name 'PERMISSION_DENIED'	reviewbot	Oct. 25, 2014, 6:13 p.m.
Col: 56 E127 continuation line over-indented for visual indent	reviewbot	Oct. 25, 2014, 6:37 p.m.
Col: 17 E126 continuation line over-indented for hanging indent	reviewbot	Oct. 25, 2014, 6:37 p.m.
Col: 17 E126 continuation line over-indented for hanging indent	reviewbot	Oct. 25, 2014, 6:37 p.m.
Col: 17 E126 continuation line over-indented for hanging indent	reviewbot	Oct. 25, 2014, 6:37 p.m.
Col: 56 E127 continuation line over-indented for visual indent	reviewbot	Oct. 25, 2014, 6:36 p.m.
Col: 17 E126 continuation line over-indented for hanging indent	reviewbot	Oct. 25, 2014, 6:36 p.m.
Col: 17 E126 continuation line over-indented for hanging indent	reviewbot	Oct. 25, 2014, 6:36 p.m.
Col: 17 E126 continuation line over-indented for hanging indent	reviewbot	Oct. 25, 2014, 6:36 p.m.
Col: 17 E126 continuation line over-indented for hanging indent	reviewbot	Oct. 25, 2014, 6:38 p.m.
Col: 17 E126 continuation line over-indented for hanging indent	reviewbot	Oct. 25, 2014, 6:38 p.m.
Col: 17 E126 continuation line over-indented for hanging indent	reviewbot	Oct. 25, 2014, 6:38 p.m.
This is no longer needed. It's for some old, deprecated support that actually probably isn't used anymore. Now, all resource …	chipx86	Nov. 8, 2014, 2:43 p.m.
You can remove this. Some changes will soon be pushed (currently on the markdown-redesign branch) that move all this documentation …	chipx86	Nov. 8, 2014, 2:43 p.m.
This class will have this automatically, so no need to copy it here.	chipx86	Nov. 8, 2014, 2:43 p.m.
The base class here shouldn't set this, as that's going to be up to the subclass.	chipx86	Nov. 8, 2014, 2:43 p.m.
For the life of me, I can't figure out why this isn't just in BaseComment. All subclasses use it. Maybe …	chipx86	Nov. 8, 2014, 2:43 p.m.
"... the comment text and the date/time the comment was made."	chipx86	Nov. 8, 2014, 2:43 p.m.
This isn't true for all subclasses. We shouldn't doc this one, and should instead only doc in the subclasses.	chipx86	Nov. 8, 2014, 2:43 p.m.
"file attachments, or general comments not tied to any code or file."	chipx86	Nov. 8, 2014, 2:43 p.m.
This can be removed.	chipx86	Nov. 8, 2014, 2:42 p.m.
Can you wrap this a bit nicer? It's awfully short, and you can fit more on a line.	chipx86	Nov. 8, 2014, 2:42 p.m.
This can be removed.	chipx86	Nov. 8, 2014, 2:42 p.m.
This should all be able to fit on one line.	chipx86	Nov. 8, 2014, 2:42 p.m.
This can be removed.	chipx86	Nov. 8, 2014, 2:42 p.m.
Indentation problems. Note that the summary must fit on one line.	chipx86	Nov. 8, 2014, 2:42 p.m.
This can be removed.	chipx86	Nov. 8, 2014, 2:42 p.m.
This can be removed.	chipx86	Nov. 8, 2014, 2:42 p.m.
"general"	chipx86	Nov. 8, 2014, 2:42 p.m.
This can be removed.	chipx86	Nov. 8, 2014, 2:42 p.m.
Small, but for method summaries Review Board follows one of the conventions: """One line summary Long explanation, that can possible …	ML mloyzer	Nov. 8, 2014, 2:42 p.m.
Why this change?	chipx86	Dec. 1, 2014, 6:51 p.m.
I know the naming is inconsistent, but this should be _post_new_general_comment.	chipx86	Nov. 8, 2014, 2:42 p.m.
Small, but for method summaries Review Board follows one of the conventions: """One line summary Long explanation, that can possible …	ML mloyzer	Nov. 8, 2014, 2:42 p.m.
Just a note: This is going to change soon, due to the markdown-redesign branch. That will probably be merged this …	chipx86	Nov. 16, 2014, 4:29 p.m.
Col: 17 E126 continuation line over-indented for hanging indent	reviewbot	Oct. 29, 2014, 2:19 p.m.
Col: 17 E126 continuation line over-indented for hanging indent	reviewbot	Oct. 29, 2014, 2:19 p.m.
Col: 17 E126 continuation line over-indented for hanging indent	reviewbot	Oct. 29, 2014, 2:19 p.m.
'GeneralComment' imported but unused	reviewbot	Nov. 8, 2014, 5:24 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 8, 2014, 5:24 p.m.
Col: 17 E126 continuation line over-indented for hanging indent	reviewbot	Nov. 8, 2014, 5:23 p.m.
Col: 17 E126 continuation line over-indented for hanging indent	reviewbot	Nov. 8, 2014, 5:23 p.m.
Col: 17 E126 continuation line over-indented for hanging indent	reviewbot	Nov. 8, 2014, 5:23 p.m.
Col: 17 E126 continuation line over-indented for hanging indent	reviewbot	Nov. 8, 2014, 5:25 p.m.
Col: 17 E126 continuation line over-indented for hanging indent	reviewbot	Nov. 8, 2014, 5:25 p.m.
Col: 17 E126 continuation line over-indented for hanging indent	reviewbot	Nov. 8, 2014, 5:25 p.m.
Col: 17 E126 continuation line over-indented for hanging indent	reviewbot	Nov. 16, 2014, 5 p.m.
Col: 17 E126 continuation line over-indented for hanging indent	reviewbot	Nov. 16, 2014, 5 p.m.
Col: 17 E126 continuation line over-indented for hanging indent	reviewbot	Nov. 16, 2014, 5 p.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/encoder.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/resources/review_file_attachment_comment.py
    reviewboard/webapi/resources/base_general_comment.py
    reviewboard/webapi/tests/test_review_general_comment.py
    reviewboard/webapi/tests/test_file_attachment_comment.py
    reviewboard/webapi/resources/screenshot_comment.py
    reviewboard/webapi/resources/file_attachment_comment.py
    reviewboard/webapi/tests/test_review_reply_general_comment.py
    reviewboard/webapi/resources/general_comment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/base.py
    reviewboard/webapi/resources/review_general_comment.py
    reviewboard/webapi/resources/review_reply_general_comment.py


WARNING: Number of comments exceeded maximum, showing 30 of 60.

reviewboard/webapi/resources/general_comment.py (Diff revision 1)
Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/webapi/resources/general_comment.py (Diff revision 1)
Show all issues
```
Col: 5
 E113 unexpected indentation
```
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1)
Show all issues
```
Col: 9
 E113 unexpected indentation
```
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1)
Show all issues
```
Col: 17
 E225 missing whitespace around operator
```
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1)
Show all issues
```
Col: 9
 E122 continuation line missing indentation or outdented
```
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1)
Show all issues
```
Col: 5
 E122 continuation line missing indentation or outdented
```
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1)
Show all issues
```
Col: 5
 E122 continuation line missing indentation or outdented
```
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1)
Show all issues
```
Col: 47
 E701 multiple statements on one line (colon)
```
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1)
Show all issues
```
Col: 12
 E701 multiple statements on one line (colon)
```
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1)
Show all issues
```
Col: 27
 E251 unexpected spaces around keyword / parameter equals
```
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1)
Show all issues
```
Col: 29
 E251 unexpected spaces around keyword / parameter equals
```
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1)
Show all issues
```
Col: 30
 E502 the backslash is redundant between brackets
```
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1)
Show all issues
```
Col: 17
 E131 continuation line unaligned for hanging indent
```
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1)
Show all issues
```
Col: 19
 E251 unexpected spaces around keyword / parameter equals
```
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1)
Show all issues
```
Col: 21
 E251 unexpected spaces around keyword / parameter equals
```
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1)
Show all issues
```
Col: 34
 E701 multiple statements on one line (colon)
```
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1)
Show all issues
```
Col: 72
 E701 multiple statements on one line (colon)
```
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1)
Show all issues
```
Col: 20
 E251 unexpected spaces around keyword / parameter equals
```
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1)
Show all issues
```
Col: 22
 E251 unexpected spaces around keyword / parameter equals
```
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1)
Show all issues
```
Col: 13
 E128 continuation line under-indented for visual indent
```
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1)
Show all issues
```
Col: 13
 E128 continuation line under-indented for visual indent
```
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1)
Show all issues
```
Col: 13
 E128 continuation line under-indented for visual indent
```
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1)
Show all issues
```
Col: 9
 E124 closing bracket does not match visual indentation
```
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1)
Show all issues
```
Col: 5
 E122 continuation line missing indentation or outdented
```
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1)
Show all issues
```
Col: 5
 E122 continuation line missing indentation or outdented
```
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1)
Show all issues
```
Col: 5
 E122 continuation line missing indentation or outdented
```
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1)
Show all issues
```
Col: 5
 E122 continuation line missing indentation or outdented
```
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1)
Show all issues
```
Col: 9
 E128 continuation line under-indented for visual indent
```
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1)
Show all issues
```
Col: 9
 E128 continuation line under-indented for visual indent
```
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1)
Show all issues
```
Col: 5
 E124 closing bracket does not match visual indentation
```

Commit:

-	121408e317a927831bef28aa72e82af966f198ad
+	a5905f640bb9a90d2e021ee77607f8d9284858fe

Diff:

Revision 2 (+862 -12)

Show changes

	reviewboard/webapi/encoder.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/base_general_comment.py
	reviewboard/webapi/resources/file_attachment_comment.py
	reviewboard/webapi/resources/general_comment.py
	reviewboard/webapi/resources/review_file_attachment_comment.py
	reviewboard/webapi/resources/review_general_comment.py
	reviewboard/webapi/resources/review_reply_general_comment.py
	7 more

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/encoder.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/resources/review_file_attachment_comment.py
    reviewboard/webapi/resources/base_general_comment.py
    reviewboard/webapi/tests/test_review_general_comment.py
    reviewboard/webapi/tests/test_file_attachment_comment.py
    reviewboard/webapi/resources/screenshot_comment.py
    reviewboard/webapi/resources/file_attachment_comment.py
    reviewboard/webapi/tests/test_review_reply_general_comment.py
    reviewboard/webapi/resources/general_comment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/base.py
    reviewboard/webapi/resources/review_general_comment.py
    reviewboard/webapi/resources/review_reply_general_comment.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/encoder.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/resources/review_file_attachment_comment.py
    reviewboard/webapi/resources/base_general_comment.py
    reviewboard/webapi/tests/test_review_general_comment.py
    reviewboard/webapi/tests/test_file_attachment_comment.py
    reviewboard/webapi/resources/screenshot_comment.py
    reviewboard/webapi/resources/file_attachment_comment.py
    reviewboard/webapi/tests/test_review_reply_general_comment.py
    reviewboard/webapi/resources/general_comment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/base.py
    reviewboard/webapi/resources/review_general_comment.py
    reviewboard/webapi/resources/review_reply_general_comment.py

reviewboard/webapi/resources/base_general_comment.py (Diff revision 2)
Show all issues
```
 'six' imported but unused
```
reviewboard/webapi/resources/general_comment.py (Diff revision 2)
Show all issues
```
Col: 5
 E303 too many blank lines (2)
```
reviewboard/webapi/resources/review_general_comment.py (Diff revision 2)
Show all issues
```
 local variable 'review_request' is assigned to but never used
```
reviewboard/webapi/resources/screenshot_comment.py (Diff revision 2)
Show all issues
```
Col: 77
 W291 trailing whitespace
```
reviewboard/webapi/tests/base.py (Diff revision 2)
Show all issues
```
 'get_general_comment_list_url' imported but unused
```

reviewboard/webapi/tests/base.py (Diff revision 2)

Show all issues

 undefined name 'get_review_general_comment_list_url'

reviewboard/webapi/tests/test_review_reply_general_comment.py (Diff revision 2)
Show all issues
```
Col: 62
 E127 continuation line over-indented for visual indent
```
reviewboard/webapi/tests/test_review_reply_general_comment.py (Diff revision 2)
Show all issues
```
Col: 62
 E127 continuation line over-indented for visual indent
```
reviewboard/webapi/tests/test_review_reply_general_comment.py (Diff revision 2)
Show all issues
```
Col: 17
 E126 continuation line over-indented for hanging indent
```

reviewboard/webapi/tests/urls.py (Diff revision 2)

Show all issues

Col: 37
 E127 continuation line over-indented for visual indent

reviewboard/webapi/tests/urls.py (Diff revision 2)

Show all issues

Col: 44
 E127 continuation line over-indented for visual indent

reviewboard/webapi/tests/urls.py (Diff revision 2)

Show all issues

Col: 50
 E127 continuation line over-indented for visual indent

Commit:

-	a5905f640bb9a90d2e021ee77607f8d9284858fe
+	3dad883d7dcda6b0a1470fa11104d0067976df17

Diff:

Revision 3 (+860 -14)

Show changes

	reviewboard/webapi/encoder.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/base_general_comment.py
	reviewboard/webapi/resources/file_attachment_comment.py
	reviewboard/webapi/resources/general_comment.py
	reviewboard/webapi/resources/review_file_attachment_comment.py
	reviewboard/webapi/resources/review_general_comment.py
	reviewboard/webapi/resources/review_reply_general_comment.py
	7 more

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/encoder.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/resources/review_file_attachment_comment.py
    reviewboard/webapi/resources/base_general_comment.py
    reviewboard/webapi/tests/test_review_general_comment.py
    reviewboard/webapi/tests/test_file_attachment_comment.py
    reviewboard/webapi/resources/screenshot_comment.py
    reviewboard/webapi/resources/file_attachment_comment.py
    reviewboard/webapi/tests/test_review_reply_general_comment.py
    reviewboard/webapi/resources/general_comment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/base.py
    reviewboard/webapi/resources/review_general_comment.py
    reviewboard/webapi/resources/review_reply_general_comment.py



Tool: Pyflakes
Processed Files:
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/encoder.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/resources/review_file_attachment_comment.py
    reviewboard/webapi/resources/base_general_comment.py
    reviewboard/webapi/tests/test_review_general_comment.py
    reviewboard/webapi/tests/test_file_attachment_comment.py
    reviewboard/webapi/resources/screenshot_comment.py
    reviewboard/webapi/resources/file_attachment_comment.py
    reviewboard/webapi/tests/test_review_reply_general_comment.py
    reviewboard/webapi/resources/general_comment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/base.py
    reviewboard/webapi/resources/review_general_comment.py
    reviewboard/webapi/resources/review_reply_general_comment.py

reviewboard/webapi/tests/test_review_reply_general_comment.py (Diff revision 3)
Show all issues
```
Col: 17
 E126 continuation line over-indented for hanging indent
```

reviewboard/webapi/resources/base_general_comment.py (Diff revision 3)

Show all issues

These don't really make any sense. The only filtering in here should be the review__isnull one, and then ReviewGeneralCommentResource and ReviewReplyGeneralCommentResource can filter to the specific review.

reviewboard/webapi/resources/file_attachment_comment.py (Diff revision 3)
Show all issues
```
This should probably be pulled out into a separate review request.
```
1. NI
  
  nicolexin Oct. 18, 2014, 3:14 p.m.
  Sure. I will do this later.

reviewboard/webapi/resources/general_comment.py (Diff revision 3)

Show all issues

This resource shouldn't be necessary, because the only "object" that general comments will be attached to will be the review (or reply). The docstrings you have in here should be moved over to BaseGeneralCommentResource.

The other comments have a separate resource that's used to attach to the given object in the tree. For example, the FileAttachmentCommentResource is accessible through the FileAttachmentResource.

reviewboard/webapi/resources/review_file_attachment_comment.py (Diff revision 3)

Show all issues

Please revert this change.

nicolexin Oct. 18, 2014, 3:14 p.m.

I think my modification make sense because the person wrote review_file_attachment_comment.py copy this from screenshot comment. However, screenshot comments contain dimensions info but file attachment comments actually don't.

reviewboard/webapi/resources/review_file_attachment_comment.py (Diff revision 3)

Show all issues

Why did you add this?

nicolexin Oct. 18, 2014, 3:14 p.m.

Well I thought maybe it make sense to check local site accessibility? I saw diff and screenshot comment does that, but since the function does nothing, I can remove this.

reviewboard/webapi/resources/review_file_attachment_comment.py (Diff revision 3)
Show all issues
```
Why did you add this?
```
reviewboard/webapi/resources/review_reply_general_comment.py (Diff revision 3)
Show all issues
```
Typo: 'genral'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 3)
Show all issues
```
This resource definitely does support items.
```

Commit:

-	3dad883d7dcda6b0a1470fa11104d0067976df17
+	d7da3673eb87834df843d8e0c143f148141523fe

Diff:

Revision 4 (+1059 -14)

Show changes

	reviewboard/webapi/encoder.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/base_general_comment.py
	reviewboard/webapi/resources/file_attachment_comment.py
	reviewboard/webapi/resources/review_file_attachment_comment.py
	reviewboard/webapi/resources/review_general_comment.py
	reviewboard/webapi/resources/review_reply_general_comment.py
	reviewboard/webapi/resources/screenshot_comment.py
	6 more

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/encoder.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/resources/review_file_attachment_comment.py
    reviewboard/webapi/resources/base_general_comment.py
    reviewboard/webapi/tests/test_review_general_comment.py
    reviewboard/webapi/tests/test_file_attachment_comment.py
    reviewboard/webapi/resources/screenshot_comment.py
    reviewboard/webapi/resources/file_attachment_comment.py
    reviewboard/webapi/tests/test_review_reply_general_comment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/base.py
    reviewboard/webapi/resources/review_general_comment.py
    reviewboard/webapi/resources/review_reply_general_comment.py



Tool: Pyflakes
Processed Files:
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/encoder.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/resources/review_file_attachment_comment.py
    reviewboard/webapi/resources/base_general_comment.py
    reviewboard/webapi/tests/test_review_general_comment.py
    reviewboard/webapi/tests/test_file_attachment_comment.py
    reviewboard/webapi/resources/screenshot_comment.py
    reviewboard/webapi/resources/file_attachment_comment.py
    reviewboard/webapi/tests/test_review_reply_general_comment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/base.py
    reviewboard/webapi/resources/review_general_comment.py
    reviewboard/webapi/resources/review_reply_general_comment.py

reviewboard/webapi/resources/base_general_comment.py (Diff revision 4)
Show all issues
```
Col: 56
 W292 no newline at end of file
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4)
Show all issues
```
Col: 46
 E127 continuation line over-indented for visual indent
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4)
Show all issues
```
Col: 50
 E127 continuation line over-indented for visual indent
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4)
Show all issues
```
 undefined name 'CommentItemMixin'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4)
Show all issues
```
 undefined name 'ReviewRequestChildItemMixin'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4)
Show all issues
```
 undefined name 'get_review_general_comment_item_url'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4)
Show all issues
```
 undefined name 'general_comment_item_mimetype'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4)
Show all issues
```
 undefined name 'get_review_general_comment_item_url'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4)
Show all issues
```
 undefined name 'get_review_general_comment_item_url'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4)
Show all issues
```
 undefined name 'get_review_general_comment_item_url'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4)
Show all issues
```
 undefined name 'general_comment_item_mimetype'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4)
Show all issues
```
 undefined name 'get_review_general_comment_item_url'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4)
Show all issues
```
Col: 56
 E127 continuation line over-indented for visual indent
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4)
Show all issues
```
 undefined name 'general_comment_item_mimetype'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4)
Show all issues
```
Col: 17
 E126 continuation line over-indented for hanging indent
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4)
Show all issues
```
 undefined name 'GeneralComment'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4)
Show all issues
```
 undefined name 'get_review_general_comment_item_url'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4)
Show all issues
```
 undefined name 'general_comment_item_mimetype'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4)
Show all issues
```
 undefined name 'get_review_general_comment_item_url'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4)
Show all issues
```
 undefined name 'general_comment_item_mimetype'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4)
Show all issues
```
 undefined name 'get_review_general_comment_item_url'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4)
Show all issues
```
 undefined name 'general_comment_item_mimetype'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4)
Show all issues
```
 undefined name 'User'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4)
Show all issues
```
 undefined name 'get_review_general_comment_item_url'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4)
Show all issues
```
 undefined name 'general_comment_item_mimetype'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4)
Show all issues
```
 undefined name 'User'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4)
Show all issues
```
 undefined name 'get_review_general_comment_item_url'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4)
Show all issues
```
 undefined name 'PERMISSION_DENIED'
```
reviewboard/webapi/tests/test_review_reply_general_comment.py (Diff revision 4)
Show all issues
```
Col: 17
 E126 continuation line over-indented for hanging indent
```

Description:

		The general comment model is built. (review request 6375)
~		Now the general comment web-api is done.
	~	Still writing test cases.
	+	(Missing "test_review_reply_general_comment.py", will be put up after careful consideration.)
	+	Testing required.

Testing Done:

~		No testing done yet.
	~	No testing done yet.
-		Stuck on updating the database.
-
-		Todo: Testing
-
-		Next step: start UI design

Commit:

-	d7da3673eb87834df843d8e0c143f148141523fe
+	99310a89f72f6032474b7bc0b626c46716f77e69

Diff:

Revision 5 (+820 -14)

Show changes

	reviewboard/webapi/encoder.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/base_general_comment.py
	reviewboard/webapi/resources/file_attachment_comment.py
	reviewboard/webapi/resources/review_file_attachment_comment.py
	reviewboard/webapi/resources/review_general_comment.py
	reviewboard/webapi/resources/review_reply_general_comment.py
	reviewboard/webapi/resources/screenshot_comment.py
	5 more

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/encoder.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/resources/review_file_attachment_comment.py
    reviewboard/webapi/resources/base_general_comment.py
    reviewboard/webapi/tests/test_review_general_comment.py
    reviewboard/webapi/tests/test_file_attachment_comment.py
    reviewboard/webapi/resources/screenshot_comment.py
    reviewboard/webapi/resources/file_attachment_comment.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/base.py
    reviewboard/webapi/resources/review_general_comment.py
    reviewboard/webapi/resources/review_reply_general_comment.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/encoder.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/resources/review_file_attachment_comment.py
    reviewboard/webapi/resources/base_general_comment.py
    reviewboard/webapi/tests/test_review_general_comment.py
    reviewboard/webapi/tests/test_file_attachment_comment.py
    reviewboard/webapi/resources/screenshot_comment.py
    reviewboard/webapi/resources/file_attachment_comment.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/base.py
    reviewboard/webapi/resources/review_general_comment.py
    reviewboard/webapi/resources/review_reply_general_comment.py

reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5)
Show all issues
```
 undefined name 'CommentListMixin'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5)
Show all issues
```
 undefined name 'get_review_general_comment_item_url'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5)
Show all issues
```
 undefined name 'general_comment_item_mimetype'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5)
Show all issues
```
 undefined name 'get_review_general_comment_item_url'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5)
Show all issues
```
 undefined name 'get_review_general_comment_item_url'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5)
Show all issues
```
 undefined name 'get_review_general_comment_item_url'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5)
Show all issues
```
 undefined name 'general_comment_item_mimetype'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5)
Show all issues
```
 undefined name 'get_review_general_comment_item_url'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5)
Show all issues
```
 undefined name 'general_comment_item_mimetype'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5)
Show all issues
```
Col: 17
 E126 continuation line over-indented for hanging indent
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5)
Show all issues
```
 undefined name 'GeneralComment'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5)
Show all issues
```
 undefined name 'get_review_general_comment_item_url'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5)
Show all issues
```
 undefined name 'general_comment_item_mimetype'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5)
Show all issues
```
 undefined name 'get_review_general_comment_item_url'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5)
Show all issues
```
 undefined name 'general_comment_item_mimetype'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5)
Show all issues
```
 undefined name 'get_review_general_comment_item_url'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5)
Show all issues
```
 undefined name 'general_comment_item_mimetype'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5)
Show all issues
```
 undefined name 'get_review_general_comment_item_url'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5)
Show all issues
```
 undefined name 'general_comment_item_mimetype'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5)
Show all issues
```
 undefined name 'get_review_general_comment_item_url'
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5)
Show all issues
```
 undefined name 'PERMISSION_DENIED'
```

Description:

		The general comment model is built. (review request 6375)
~		Still writing test cases.
~		(Missing "test_review_reply_general_comment.py", will be put up after careful consideration.)
~		Testing required.
	~	Now web-api's done.
	~
	~	Sorry about change in backend model included in the diff, please ingore that.
	+	I did "rbt post -u --tracking-branch=upstream/comment_model", but i have no idea why it gives modifications in comment_model branch.

Testing Done:

~		No testing done yet.
	~	Add 106 test and all test passed.

Commit:

-	99310a89f72f6032474b7bc0b626c46716f77e69
+	c54ed7c4457a043ef8b8a090f6207e0d7e10b8f8

Diff:

Revision 6 (+1963 -42)

Show changes

	reviewboard/notifications/tests.py
	reviewboard/notifications/webhooks.py
	reviewboard/reviews/admin.py
	reviewboard/reviews/tests.py
	reviewboard/reviews/views.py
	reviewboard/reviews/models/__init__.py
	reviewboard/reviews/models/general_comment.py
	reviewboard/reviews/models/review.py
	24 more

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/webapi/resources/screenshot_comment.py
    reviewboard/webapi/tests/test_review_reply_general_comment.py
    reviewboard/webapi/tests/test_file_attachment_comment.py
    reviewboard/webapi/resources/review_reply.py
    reviewboard/webapi/encoder.py
    reviewboard/webapi/resources/review_file_attachment_comment.py
    reviewboard/reviews/models/__init__.py
    reviewboard/webapi/review_general_comment.py
    reviewboard/webapi/tests/urls.py
    reviewboard/reviews/models/review.py
    reviewboard/webapi/tests/base.py
    reviewboard/webapi/resources/review_reply_general_comment.py
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment_comment.py
    reviewboard/webapi/resources/base_general_comment.py
    reviewboard/reviews/tests.py
    reviewboard/reviews/models/review_request.py
    reviewboard/reviews/models/general_comment.py
    reviewboard/webapi/base_file_attachment_comment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/notifications/tests.py
    reviewboard/webapi/review_reply.py
    reviewboard/webapi/tests/test_review_general_comment.py
    reviewboard/reviews/admin.py
    reviewboard/webapi/resources/file_attachment_comment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/review.py
    reviewboard/notifications/webhooks.py
    reviewboard/webapi/resources/review_general_comment.py
    reviewboard/webapi/review.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/webapi/resources/screenshot_comment.py
    reviewboard/webapi/tests/test_review_reply_general_comment.py
    reviewboard/webapi/tests/test_file_attachment_comment.py
    reviewboard/webapi/resources/review_reply.py
    reviewboard/webapi/encoder.py
    reviewboard/webapi/resources/review_file_attachment_comment.py
    reviewboard/reviews/models/__init__.py
    reviewboard/webapi/review_general_comment.py
    reviewboard/webapi/tests/urls.py
    reviewboard/reviews/models/review.py
    reviewboard/webapi/tests/base.py
    reviewboard/webapi/resources/review_reply_general_comment.py
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment_comment.py
    reviewboard/webapi/resources/base_general_comment.py
    reviewboard/reviews/tests.py
    reviewboard/reviews/models/review_request.py
    reviewboard/reviews/models/general_comment.py
    reviewboard/webapi/base_file_attachment_comment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/notifications/tests.py
    reviewboard/webapi/review_reply.py
    reviewboard/webapi/tests/test_review_general_comment.py
    reviewboard/reviews/admin.py
    reviewboard/webapi/resources/file_attachment_comment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/review.py
    reviewboard/notifications/webhooks.py
    reviewboard/webapi/resources/review_general_comment.py
    reviewboard/webapi/review.py

reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 6)
Show all issues
```
Col: 56
 E127 continuation line over-indented for visual indent
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 6)
Show all issues
```
Col: 17
 E126 continuation line over-indented for hanging indent
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 6)
Show all issues
```
Col: 17
 E126 continuation line over-indented for hanging indent
```
reviewboard/webapi/tests/test_review_reply_general_comment.py (Diff revision 6)
Show all issues
```
Col: 17
 E126 continuation line over-indented for hanging indent
```

Summary:

-	[WIP]General comment: web-api and tests
+	General comment: web-api and tests

Description:

		The general comment model is built. (review request 6375)
		Now web-api's done.

~		Sorry about change in backend model included in the diff, please ingore that.
~		I did "rbt post -u --tracking-branch=upstream/comment_model", but i have no idea why it gives modifications in comment_model branch.
	~	And I'm able to exclude all files in comment model branch.
	~	Ready for review.

Testing Done:

~		Add 106 test and all test passed.
	~	Add 106 tests and all tests passed.

Commit:

-	c54ed7c4457a043ef8b8a090f6207e0d7e10b8f8
+	8e0887cede8d11d33b0248e0bc56a7d932ea4b4b

Diff:

Revision 7 (+1750 -18)

Show changes

	reviewboard/notifications/tests.py
	reviewboard/notifications/webhooks.py
	reviewboard/webapi/base_file_attachment_comment.py
	reviewboard/webapi/encoder.py
	reviewboard/webapi/review.py
	reviewboard/webapi/review_general_comment.py
	reviewboard/webapi/review_reply.py
	reviewboard/webapi/resources/__init__.py
	15 more

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/review_general_comment.py
    reviewboard/webapi/resources/review_reply.py
    reviewboard/webapi/encoder.py
    reviewboard/webapi/resources/review_file_attachment_comment.py
    reviewboard/webapi/tests/test_file_attachment_comment.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/base.py
    reviewboard/webapi/resources/review_reply_general_comment.py
    reviewboard/webapi/tests/test_review_reply_general_comment.py
    reviewboard/webapi/resources/base_general_comment.py
    reviewboard/webapi/resources/base_file_attachment_comment.py
    reviewboard/webapi/base_file_attachment_comment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/notifications/tests.py
    reviewboard/webapi/review_reply.py
    reviewboard/webapi/tests/test_review_general_comment.py
    reviewboard/webapi/resources/screenshot_comment.py
    reviewboard/webapi/resources/file_attachment_comment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/review.py
    reviewboard/notifications/webhooks.py
    reviewboard/webapi/resources/review_general_comment.py
    reviewboard/webapi/review.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/review_general_comment.py
    reviewboard/webapi/resources/review_reply.py
    reviewboard/webapi/encoder.py
    reviewboard/webapi/resources/review_file_attachment_comment.py
    reviewboard/webapi/tests/test_file_attachment_comment.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/base.py
    reviewboard/webapi/resources/review_reply_general_comment.py
    reviewboard/webapi/tests/test_review_reply_general_comment.py
    reviewboard/webapi/resources/base_general_comment.py
    reviewboard/webapi/resources/base_file_attachment_comment.py
    reviewboard/webapi/base_file_attachment_comment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/notifications/tests.py
    reviewboard/webapi/review_reply.py
    reviewboard/webapi/tests/test_review_general_comment.py
    reviewboard/webapi/resources/screenshot_comment.py
    reviewboard/webapi/resources/file_attachment_comment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/review.py
    reviewboard/notifications/webhooks.py
    reviewboard/webapi/resources/review_general_comment.py
    reviewboard/webapi/review.py

reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 7)
Show all issues
```
Col: 56
 E127 continuation line over-indented for visual indent
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 7)
Show all issues
```
Col: 17
 E126 continuation line over-indented for hanging indent
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 7)
Show all issues
```
Col: 17
 E126 continuation line over-indented for hanging indent
```
reviewboard/webapi/tests/test_review_reply_general_comment.py (Diff revision 7)
Show all issues
```
Col: 17
 E126 continuation line over-indented for hanging indent
```

Summary:

-	General comment: web-api and tests
+	[WIP]General comment: web-api and tests

Description:

		The general comment model is built. (review request 6375)
		Now web-api's done.

		And I'm able to exclude all files in comment model branch.
~		Ready for review.
	~	TODO: split modifications on other comments

Commit:

-	8e0887cede8d11d33b0248e0bc56a7d932ea4b4b
+	ad86570a9cde87cdc2496349249cb62047e2d369

Diff:

Revision 8 (+1750 -18)

Show changes

	reviewboard/notifications/tests.py
	reviewboard/notifications/webhooks.py
	reviewboard/webapi/base_file_attachment_comment.py
	reviewboard/webapi/encoder.py
	reviewboard/webapi/review.py
	reviewboard/webapi/review_general_comment.py
	reviewboard/webapi/review_reply.py
	reviewboard/webapi/resources/__init__.py
	15 more

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/review_general_comment.py
    reviewboard/webapi/resources/review_reply.py
    reviewboard/webapi/encoder.py
    reviewboard/webapi/resources/review_file_attachment_comment.py
    reviewboard/webapi/tests/test_file_attachment_comment.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/base.py
    reviewboard/webapi/resources/review_reply_general_comment.py
    reviewboard/webapi/tests/test_review_reply_general_comment.py
    reviewboard/webapi/resources/base_general_comment.py
    reviewboard/webapi/resources/base_file_attachment_comment.py
    reviewboard/webapi/base_file_attachment_comment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/notifications/tests.py
    reviewboard/webapi/review_reply.py
    reviewboard/webapi/tests/test_review_general_comment.py
    reviewboard/webapi/resources/screenshot_comment.py
    reviewboard/webapi/resources/file_attachment_comment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/review.py
    reviewboard/notifications/webhooks.py
    reviewboard/webapi/resources/review_general_comment.py
    reviewboard/webapi/review.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/review_general_comment.py
    reviewboard/webapi/resources/review_reply.py
    reviewboard/webapi/encoder.py
    reviewboard/webapi/resources/review_file_attachment_comment.py
    reviewboard/webapi/tests/test_file_attachment_comment.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/base.py
    reviewboard/webapi/resources/review_reply_general_comment.py
    reviewboard/webapi/tests/test_review_reply_general_comment.py
    reviewboard/webapi/resources/base_general_comment.py
    reviewboard/webapi/resources/base_file_attachment_comment.py
    reviewboard/webapi/base_file_attachment_comment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/notifications/tests.py
    reviewboard/webapi/review_reply.py
    reviewboard/webapi/tests/test_review_general_comment.py
    reviewboard/webapi/resources/screenshot_comment.py
    reviewboard/webapi/resources/file_attachment_comment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/review.py
    reviewboard/notifications/webhooks.py
    reviewboard/webapi/resources/review_general_comment.py
    reviewboard/webapi/review.py

reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 8)
Show all issues
```
Col: 17
 E126 continuation line over-indented for hanging indent
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 8)
Show all issues
```
Col: 17
 E126 continuation line over-indented for hanging indent
```
reviewboard/webapi/tests/test_review_reply_general_comment.py (Diff revision 8)
Show all issues
```
Col: 17
 E126 continuation line over-indented for hanging indent
```

Hmmm, a bunch of files from reviewboard/webapi/resources/ just got added into reviewboard/webapi/. What happened there? Something seems wrong.

NI

nicolexin Oct. 29, 2014, 2:12 p.m.
```
Sorry about that, should be fixed now!
```

Summary:

-	[WIP]General comment: web-api and tests
+	General comment: web-api and tests

Description:

		The general comment model is built. (review request 6375)
		Now web-api's done.

~		And I'm able to exclude all files in comment model branch.
	~	Other unrelated changes has moved to review request 6528.
-		TODO: split modifications on other comments

Commit:

-	ad86570a9cde87cdc2496349249cb62047e2d369
+	44e33d42579505fa32328cff2790d9a632952ce7

Diff:

Revision 9 (+1122 -12)

Show changes

	reviewboard/notifications/tests.py
	reviewboard/notifications/webhooks.py
	reviewboard/webapi/encoder.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/base_general_comment.py
	reviewboard/webapi/resources/review.py
	reviewboard/webapi/resources/review_general_comment.py
	reviewboard/webapi/resources/review_reply.py
	6 more

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/encoder.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/notifications/tests.py
    reviewboard/webapi/resources/base_general_comment.py
    reviewboard/webapi/tests/test_review_general_comment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/test_review_reply_general_comment.py
    reviewboard/webapi/resources/review_reply.py
    reviewboard/webapi/resources/review.py
    reviewboard/notifications/webhooks.py
    reviewboard/webapi/tests/base.py
    reviewboard/webapi/resources/review_general_comment.py
    reviewboard/webapi/resources/review_reply_general_comment.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/encoder.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/notifications/tests.py
    reviewboard/webapi/resources/base_general_comment.py
    reviewboard/webapi/tests/test_review_general_comment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/test_review_reply_general_comment.py
    reviewboard/webapi/resources/review_reply.py
    reviewboard/webapi/resources/review.py
    reviewboard/notifications/webhooks.py
    reviewboard/webapi/tests/base.py
    reviewboard/webapi/resources/review_general_comment.py
    reviewboard/webapi/resources/review_reply_general_comment.py

reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 9)
Show all issues
```
Col: 17
 E126 continuation line over-indented for hanging indent
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 9)
Show all issues
```
Col: 17
 E126 continuation line over-indented for hanging indent
```
reviewboard/webapi/tests/test_review_reply_general_comment.py (Diff revision 9)
Show all issues
```
Col: 17
 E126 continuation line over-indented for hanging indent
```

Fix it!

reviewboard/webapi/encoder.py (Diff revision 9)

Show all issues

This is no longer needed. It's for some old, deprecated support that actually probably isn't used anymore.

Now, all resource data is serialized straight from the WebAPIResource subclass.

reviewboard/webapi/resources/base_general_comment.py (Diff revision 9)

Show all issues

You can remove this. Some changes will soon be pushed (currently on the markdown-redesign branch) that move all this documentation to a new page.

reviewboard/webapi/resources/base_general_comment.py (Diff revision 9)
Show all issues
```
This class will have this automatically, so no need to copy it here.
```

reviewboard/webapi/resources/base_general_comment.py (Diff revision 9)

Show all issues

The base class here shouldn't set this, as that's going to be up to the subclass.

reviewboard/webapi/resources/base_general_comment.py (Diff revision 9)

Show all issues

For the life of me, I can't figure out why this isn't just in BaseComment. All subclasses use it. Maybe just introduce it there?

reviewboard/webapi/resources/base_general_comment.py (Diff revision 9)
Show all issues
```
"... the comment text and the date/time the comment was made."
```

reviewboard/webapi/resources/base_general_comment.py (Diff revision 9)

Show all issues

This isn't true for all subclasses.

We shouldn't doc this one, and should instead only doc in the subclasses.

reviewboard/webapi/resources/review.py (Diff revision 9)

Show all issues

"file attachments, or general comments not tied to any code or file."

reviewboard/webapi/resources/review_general_comment.py (Diff revision 9)

Show all issues

This can be removed.

reviewboard/webapi/resources/review_general_comment.py (Diff revision 9)

Show all issues

Can you wrap this a bit nicer? It's awfully short, and you can fit more on a line.

reviewboard/webapi/resources/review_general_comment.py (Diff revision 9)
Show all issues
```
This can be removed.
```
reviewboard/webapi/resources/review_general_comment.py (Diff revision 9)
Show all issues
```
This should all be able to fit on one line.
```

reviewboard/webapi/resources/review_general_comment.py (Diff revision 9)

Show all issues

This can be removed.

reviewboard/webapi/resources/review_reply_general_comment.py (Diff revision 9)

Show all issues

Indentation problems.

Note that the summary must fit on one line.

reviewboard/webapi/resources/review_reply_general_comment.py (Diff revision 9)

Show all issues

This can be removed.

reviewboard/webapi/resources/review_reply_general_comment.py (Diff revision 9)
Show all issues
```
This can be removed.
```
reviewboard/webapi/resources/review_reply_general_comment.py (Diff revision 9)
Show all issues
```
"general"
```

reviewboard/webapi/resources/review_reply_general_comment.py (Diff revision 9)

Show all issues

This can be removed.

reviewboard/webapi/tests/base.py (Diff revision 9)

Show all issues

Why this change?

nicolexin Nov. 8, 2014, 2:48 p.m.

Since we are passing a review in, we are finding screenshot comments related to a review, not a review request. But in webapi/test/urls.py we can see that get_screenshot_list_url is getting all the screenshot comments in the review request.

reviewboard/webapi/tests/base.py (Diff revision 9)

Show all issues

I know the naming is inconsistent, but this should be _post_new_general_comment.

reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 9)

Show all issues

Just a note: This is going to change soon, due to the markdown-redesign branch. That will probably be merged this week. At that point, your tests will break, so look at the similar test classes when that happens to see how they changed.

reviewboard/webapi/resources/review_reply_general_comment.py (Diff revision 9)

Show all issues

Small, but for method summaries Review Board follows one of the conventions:

"""One line summary

Long explanation, that can possible
span multiple lines.
"""

or:

"""One line summary"""

Review Board adheres to the PEP standard: http://legacy.python.org/dev/peps/pep-0257/

reviewboard/webapi/tests/base.py (Diff revision 9)

Show all issues

Small, but for method summaries Review Board follows one of the conventions:

"""One line summary

Long explanation, that can possible
span multiple lines.
"""
(make sure there's a new line)

Commit:

-	44e33d42579505fa32328cff2790d9a632952ce7
+	a6a2ec07ff1810be6ea9ac3253bada281d14136e

Diff:

Revision 10 (+1054 -12)

Show changes

	reviewboard/notifications/tests.py
	reviewboard/notifications/webhooks.py
	reviewboard/webapi/encoder.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/base_review_general_comment.py
	reviewboard/webapi/resources/review.py
	reviewboard/webapi/resources/review_general_comment.py
	reviewboard/webapi/resources/review_reply.py
	6 more

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/encoder.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/notifications/tests.py
    reviewboard/webapi/tests/test_review_general_comment.py
    reviewboard/webapi/resources/base_review_general_comment.py
    reviewboard/webapi/tests/test_review_reply_general_comment.py
    reviewboard/webapi/resources/review_reply.py
    reviewboard/webapi/resources/review.py
    reviewboard/notifications/webhooks.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/base.py
    reviewboard/webapi/resources/review_general_comment.py
    reviewboard/webapi/resources/review_reply_general_comment.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/encoder.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/notifications/tests.py
    reviewboard/webapi/tests/test_review_general_comment.py
    reviewboard/webapi/resources/base_review_general_comment.py
    reviewboard/webapi/tests/test_review_reply_general_comment.py
    reviewboard/webapi/resources/review_reply.py
    reviewboard/webapi/resources/review.py
    reviewboard/notifications/webhooks.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/base.py
    reviewboard/webapi/resources/review_general_comment.py
    reviewboard/webapi/resources/review_reply_general_comment.py

reviewboard/webapi/encoder.py (Diff revision 10)
Show all issues
```
 'GeneralComment' imported but unused
```
reviewboard/webapi/tests/base.py (Diff revision 10)
Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 10)
Show all issues
```
Col: 17
 E126 continuation line over-indented for hanging indent
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 10)
Show all issues
```
Col: 17
 E126 continuation line over-indented for hanging indent
```
reviewboard/webapi/tests/test_review_reply_general_comment.py (Diff revision 10)
Show all issues
```
Col: 17
 E126 continuation line over-indented for hanging indent
```

Commit:

-	a6a2ec07ff1810be6ea9ac3253bada281d14136e
+	556d98b7f7dac763c905375cb068f8b338e743c3

Diff:

Revision 11 (+1054 -11)

Show changes

	reviewboard/notifications/tests.py
	reviewboard/notifications/webhooks.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/base_review_general_comment.py
	reviewboard/webapi/resources/review.py
	reviewboard/webapi/resources/review_general_comment.py
	reviewboard/webapi/resources/review_reply.py
	reviewboard/webapi/resources/review_reply_general_comment.py
	5 more

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/notifications/tests.py
    reviewboard/webapi/tests/test_review_general_comment.py
    reviewboard/webapi/resources/base_review_general_comment.py
    reviewboard/webapi/tests/test_review_reply_general_comment.py
    reviewboard/webapi/resources/review_reply.py
    reviewboard/webapi/resources/review.py
    reviewboard/notifications/webhooks.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/base.py
    reviewboard/webapi/resources/review_general_comment.py
    reviewboard/webapi/resources/review_reply_general_comment.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/notifications/tests.py
    reviewboard/webapi/tests/test_review_general_comment.py
    reviewboard/webapi/resources/base_review_general_comment.py
    reviewboard/webapi/tests/test_review_reply_general_comment.py
    reviewboard/webapi/resources/review_reply.py
    reviewboard/webapi/resources/review.py
    reviewboard/notifications/webhooks.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/base.py
    reviewboard/webapi/resources/review_general_comment.py
    reviewboard/webapi/resources/review_reply_general_comment.py

reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 11)
Show all issues
```
Col: 17
 E126 continuation line over-indented for hanging indent
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 11)
Show all issues
```
Col: 17
 E126 continuation line over-indented for hanging indent
```
reviewboard/webapi/tests/test_review_reply_general_comment.py (Diff revision 11)
Show all issues
```
Col: 17
 E126 continuation line over-indented for hanging indent
```

Commit:

-	556d98b7f7dac763c905375cb068f8b338e743c3
+	712b65f5efb8d49db3a65dd79db69edb0bcb60cc

Diff:

Revision 12 (+1067 -11)

Show changes

	reviewboard/notifications/tests.py
	reviewboard/notifications/webhooks.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/base_comment.py
	reviewboard/webapi/resources/base_review_general_comment.py
	reviewboard/webapi/resources/review.py
	reviewboard/webapi/resources/review_general_comment.py
	reviewboard/webapi/resources/review_reply.py
	6 more

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/resources/base_comment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/notifications/tests.py
    reviewboard/webapi/tests/test_review_general_comment.py
    reviewboard/webapi/resources/base_review_general_comment.py
    reviewboard/webapi/tests/test_review_reply_general_comment.py
    reviewboard/webapi/resources/review_reply.py
    reviewboard/webapi/resources/review.py
    reviewboard/notifications/webhooks.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/base.py
    reviewboard/webapi/resources/review_general_comment.py
    reviewboard/webapi/resources/review_reply_general_comment.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/resources/base_comment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/notifications/tests.py
    reviewboard/webapi/tests/test_review_general_comment.py
    reviewboard/webapi/resources/base_review_general_comment.py
    reviewboard/webapi/tests/test_review_reply_general_comment.py
    reviewboard/webapi/resources/review_reply.py
    reviewboard/webapi/resources/review.py
    reviewboard/notifications/webhooks.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/base.py
    reviewboard/webapi/resources/review_general_comment.py
    reviewboard/webapi/resources/review_reply_general_comment.py

reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 12)
Show all issues
```
Col: 17
 E126 continuation line over-indented for hanging indent
```
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 12)
Show all issues
```
Col: 17
 E126 continuation line over-indented for hanging indent
```
reviewboard/webapi/tests/test_review_reply_general_comment.py (Diff revision 12)
Show all issues
```
Col: 17
 E126 continuation line over-indented for hanging indent
```

Description:

~		The general comment model is built. (review request 6375)
~		Now web-api's done.
	~	Reviewboard currently support 3 types of comments: Diff commment, File attachment comments, Screenshot comments.
	~	This is a new type of comments: General comments.
	+
	+	A general comment on a review request is used when a comment is not tied to specific lines of code or a special file attachment, and an issue is opened. Examples include suggestions for testing or pointing out errors in the change description.

~		Other unrelated changes has moved to review request 6528.
	~	The general comment model is built. (review request 6375)
	+	This review request is for general comments web-api.

Testing Done:

~		Add 106 tests and all tests passed.
	~	Add 106 tests for general comments in reviewboard/webapi/tests and all tests passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to ucosp/nicole_xin/general-comments (3c3e22d)