-
-
reviewboard/webapi/resources/general_comment.py (Diff revision 1) Col: 1 E302 expected 2 blank lines, found 1
-
reviewboard/webapi/resources/general_comment.py (Diff revision 1) Col: 5 E113 unexpected indentation
-
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1) Col: 9 E113 unexpected indentation
-
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1) Col: 17 E225 missing whitespace around operator
-
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1) Col: 9 E122 continuation line missing indentation or outdented
-
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1) Col: 5 E122 continuation line missing indentation or outdented
-
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1) Col: 5 E122 continuation line missing indentation or outdented
-
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1) Col: 47 E701 multiple statements on one line (colon)
-
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1) Col: 12 E701 multiple statements on one line (colon)
-
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1) Col: 27 E251 unexpected spaces around keyword / parameter equals
-
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1) Col: 29 E251 unexpected spaces around keyword / parameter equals
-
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1) Col: 30 E502 the backslash is redundant between brackets
-
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1) Col: 17 E131 continuation line unaligned for hanging indent
-
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1) Col: 19 E251 unexpected spaces around keyword / parameter equals
-
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1) Col: 21 E251 unexpected spaces around keyword / parameter equals
-
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1) Col: 34 E701 multiple statements on one line (colon)
-
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1) Col: 72 E701 multiple statements on one line (colon)
-
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1) Col: 20 E251 unexpected spaces around keyword / parameter equals
-
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1) Col: 22 E251 unexpected spaces around keyword / parameter equals
-
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1) Col: 13 E128 continuation line under-indented for visual indent
-
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1) Col: 13 E128 continuation line under-indented for visual indent
-
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1) Col: 13 E128 continuation line under-indented for visual indent
-
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1) Col: 9 E124 closing bracket does not match visual indentation
-
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1) Col: 5 E122 continuation line missing indentation or outdented
-
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1) Col: 5 E122 continuation line missing indentation or outdented
-
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1) Col: 5 E122 continuation line missing indentation or outdented
-
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1) Col: 5 E122 continuation line missing indentation or outdented
-
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1) Col: 9 E128 continuation line under-indented for visual indent
-
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1) Col: 9 E128 continuation line under-indented for visual indent
-
reviewboard/webapi/resources/review_general_comment.py (Diff revision 1) Col: 5 E124 closing bracket does not match visual indentation
General comment: web-api and tests
Review Request #6431 — Created Oct. 11, 2014 and submitted
Information | |
---|---|
nicolexin | |
Review Board | |
master | |
712b65f... | |
Reviewers | |
reviewboard, students | |
Reviewboard currently support 3 types of comments: Diff commment, File attachment comments, Screenshot comments.
This is a new type of comments: General comments.A general comment on a review request is used when a comment is not tied to specific lines of code or a special file attachment, and an issue is opened. Examples include suggestions for testing or pointing out errors in the change description.
The general comment model is built. (review request 6375)
This review request is for general comments web-api.
Add 106 tests for general comments in reviewboard/webapi/tests and all tests passed.
Description | From | Last Updated |
---|---|---|
Col: 1 E302 expected 2 blank lines, found 1 |
![]() |
|
Col: 5 E113 unexpected indentation |
![]() |
|
Col: 9 E113 unexpected indentation |
![]() |
|
Col: 17 E225 missing whitespace around operator |
![]() |
|
Col: 9 E122 continuation line missing indentation or outdented |
![]() |
|
Col: 5 E122 continuation line missing indentation or outdented |
![]() |
|
Col: 5 E122 continuation line missing indentation or outdented |
![]() |
|
Col: 47 E701 multiple statements on one line (colon) |
![]() |
|
Col: 12 E701 multiple statements on one line (colon) |
![]() |
|
Col: 27 E251 unexpected spaces around keyword / parameter equals |
![]() |
|
Col: 29 E251 unexpected spaces around keyword / parameter equals |
![]() |
|
Col: 30 E502 the backslash is redundant between brackets |
![]() |
|
Col: 17 E131 continuation line unaligned for hanging indent |
![]() |
|
Col: 19 E251 unexpected spaces around keyword / parameter equals |
![]() |
|
Col: 21 E251 unexpected spaces around keyword / parameter equals |
![]() |
|
Col: 34 E701 multiple statements on one line (colon) |
![]() |
|
Col: 72 E701 multiple statements on one line (colon) |
![]() |
|
Col: 20 E251 unexpected spaces around keyword / parameter equals |
![]() |
|
Col: 22 E251 unexpected spaces around keyword / parameter equals |
![]() |
|
Col: 13 E128 continuation line under-indented for visual indent |
![]() |
|
Col: 13 E128 continuation line under-indented for visual indent |
![]() |
|
Col: 13 E128 continuation line under-indented for visual indent |
![]() |
|
Col: 9 E124 closing bracket does not match visual indentation |
![]() |
|
Col: 5 E122 continuation line missing indentation or outdented |
![]() |
|
Col: 5 E122 continuation line missing indentation or outdented |
![]() |
|
Col: 5 E122 continuation line missing indentation or outdented |
![]() |
|
Col: 5 E122 continuation line missing indentation or outdented |
![]() |
|
Col: 9 E128 continuation line under-indented for visual indent |
![]() |
|
Col: 9 E128 continuation line under-indented for visual indent |
![]() |
|
Col: 5 E124 closing bracket does not match visual indentation |
![]() |
|
'six' imported but unused |
![]() |
|
Col: 5 E303 too many blank lines (2) |
![]() |
|
local variable 'review_request' is assigned to but never used |
![]() |
|
Col: 77 W291 trailing whitespace |
![]() |
|
'get_general_comment_list_url' imported but unused |
![]() |
|
undefined name 'get_review_general_comment_list_url' |
![]() |
|
Col: 62 E127 continuation line over-indented for visual indent |
![]() |
|
Col: 62 E127 continuation line over-indented for visual indent |
![]() |
|
Col: 17 E126 continuation line over-indented for hanging indent |
![]() |
|
Col: 37 E127 continuation line over-indented for visual indent |
![]() |
|
Col: 44 E127 continuation line over-indented for visual indent |
![]() |
|
Col: 50 E127 continuation line over-indented for visual indent |
![]() |
|
These don't really make any sense. The only filtering in here should be the review__isnull one, and then ReviewGeneralCommentResource and … |
|
|
This should probably be pulled out into a separate review request. |
|
|
This resource shouldn't be necessary, because the only "object" that general comments will be attached to will be the review … |
|
|
Please revert this change. |
|
|
Why did you add this? |
|
|
Why did you add this? |
|
|
Typo: 'genral' |
|
|
This resource definitely does support items. |
|
|
Col: 17 E126 continuation line over-indented for hanging indent |
![]() |
|
Col: 56 W292 no newline at end of file |
![]() |
|
Col: 46 E127 continuation line over-indented for visual indent |
![]() |
|
Col: 50 E127 continuation line over-indented for visual indent |
![]() |
|
undefined name 'CommentItemMixin' |
![]() |
|
undefined name 'ReviewRequestChildItemMixin' |
![]() |
|
undefined name 'get_review_general_comment_item_url' |
![]() |
|
undefined name 'general_comment_item_mimetype' |
![]() |
|
undefined name 'get_review_general_comment_item_url' |
![]() |
|
undefined name 'get_review_general_comment_item_url' |
![]() |
|
undefined name 'get_review_general_comment_item_url' |
![]() |
|
undefined name 'general_comment_item_mimetype' |
![]() |
|
undefined name 'get_review_general_comment_item_url' |
![]() |
|
Col: 56 E127 continuation line over-indented for visual indent |
![]() |
|
undefined name 'general_comment_item_mimetype' |
![]() |
|
Col: 17 E126 continuation line over-indented for hanging indent |
![]() |
|
undefined name 'GeneralComment' |
![]() |
|
undefined name 'get_review_general_comment_item_url' |
![]() |
|
undefined name 'general_comment_item_mimetype' |
![]() |
|
undefined name 'get_review_general_comment_item_url' |
![]() |
|
undefined name 'general_comment_item_mimetype' |
![]() |
|
undefined name 'get_review_general_comment_item_url' |
![]() |
|
undefined name 'general_comment_item_mimetype' |
![]() |
|
undefined name 'User' |
![]() |
|
undefined name 'get_review_general_comment_item_url' |
![]() |
|
undefined name 'general_comment_item_mimetype' |
![]() |
|
undefined name 'User' |
![]() |
|
undefined name 'get_review_general_comment_item_url' |
![]() |
|
undefined name 'PERMISSION_DENIED' |
![]() |
|
Col: 17 E126 continuation line over-indented for hanging indent |
![]() |
|
undefined name 'CommentListMixin' |
![]() |
|
undefined name 'get_review_general_comment_item_url' |
![]() |
|
undefined name 'general_comment_item_mimetype' |
![]() |
|
undefined name 'get_review_general_comment_item_url' |
![]() |
|
undefined name 'get_review_general_comment_item_url' |
![]() |
|
undefined name 'get_review_general_comment_item_url' |
![]() |
|
undefined name 'general_comment_item_mimetype' |
![]() |
|
undefined name 'get_review_general_comment_item_url' |
![]() |
|
undefined name 'general_comment_item_mimetype' |
![]() |
|
Col: 17 E126 continuation line over-indented for hanging indent |
![]() |
|
undefined name 'GeneralComment' |
![]() |
|
undefined name 'get_review_general_comment_item_url' |
![]() |
|
undefined name 'general_comment_item_mimetype' |
![]() |
|
undefined name 'get_review_general_comment_item_url' |
![]() |
|
undefined name 'general_comment_item_mimetype' |
![]() |
|
undefined name 'get_review_general_comment_item_url' |
![]() |
|
undefined name 'general_comment_item_mimetype' |
![]() |
|
undefined name 'get_review_general_comment_item_url' |
![]() |
|
undefined name 'general_comment_item_mimetype' |
![]() |
|
undefined name 'get_review_general_comment_item_url' |
![]() |
|
undefined name 'PERMISSION_DENIED' |
![]() |
|
Col: 56 E127 continuation line over-indented for visual indent |
![]() |
|
Col: 17 E126 continuation line over-indented for hanging indent |
![]() |
|
Col: 17 E126 continuation line over-indented for hanging indent |
![]() |
|
Col: 17 E126 continuation line over-indented for hanging indent |
![]() |
|
Col: 56 E127 continuation line over-indented for visual indent |
![]() |
|
Col: 17 E126 continuation line over-indented for hanging indent |
![]() |
|
Col: 17 E126 continuation line over-indented for hanging indent |
![]() |
|
Col: 17 E126 continuation line over-indented for hanging indent |
![]() |
|
Col: 17 E126 continuation line over-indented for hanging indent |
![]() |
|
Col: 17 E126 continuation line over-indented for hanging indent |
![]() |
|
Col: 17 E126 continuation line over-indented for hanging indent |
![]() |
|
This is no longer needed. It's for some old, deprecated support that actually probably isn't used anymore. Now, all resource … |
|
|
You can remove this. Some changes will soon be pushed (currently on the markdown-redesign branch) that move all this documentation … |
|
|
This class will have this automatically, so no need to copy it here. |
|
|
The base class here shouldn't set this, as that's going to be up to the subclass. |
|
|
For the life of me, I can't figure out why this isn't just in BaseComment. All subclasses use it. Maybe … |
|
|
"... the comment text and the date/time the comment was made." |
|
|
This isn't true for all subclasses. We shouldn't doc this one, and should instead only doc in the subclasses. |
|
|
"file attachments, or general comments not tied to any code or file." |
|
|
This can be removed. |
|
|
Can you wrap this a bit nicer? It's awfully short, and you can fit more on a line. |
|
|
This can be removed. |
|
|
This should all be able to fit on one line. |
|
|
This can be removed. |
|
|
Indentation problems. Note that the summary must fit on one line. |
|
|
This can be removed. |
|
|
This can be removed. |
|
|
"general" |
|
|
This can be removed. |
|
|
Small, but for method summaries Review Board follows one of the conventions: """One line summary Long explanation, that can possible … |
ML mloyzer | |
Why this change? |
|
|
I know the naming is inconsistent, but this should be _post_new_general_comment. |
|
|
Small, but for method summaries Review Board follows one of the conventions: """One line summary Long explanation, that can possible … |
ML mloyzer | |
Just a note: This is going to change soon, due to the markdown-redesign branch. That will probably be merged this … |
|
|
Col: 17 E126 continuation line over-indented for hanging indent |
![]() |
|
Col: 17 E126 continuation line over-indented for hanging indent |
![]() |
|
Col: 17 E126 continuation line over-indented for hanging indent |
![]() |
|
'GeneralComment' imported but unused |
![]() |
|
Col: 80 E501 line too long (80 > 79 characters) |
![]() |
|
Col: 17 E126 continuation line over-indented for hanging indent |
![]() |
|
Col: 17 E126 continuation line over-indented for hanging indent |
![]() |
|
Col: 17 E126 continuation line over-indented for hanging indent |
![]() |
|
Col: 17 E126 continuation line over-indented for hanging indent |
![]() |
|
Col: 17 E126 continuation line over-indented for hanging indent |
![]() |
|
Col: 17 E126 continuation line over-indented for hanging indent |
![]() |
|
Col: 17 E126 continuation line over-indented for hanging indent |
![]() |
|
Col: 17 E126 continuation line over-indented for hanging indent |
![]() |
|
Col: 17 E126 continuation line over-indented for hanging indent |
![]() |

Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+862 -12) |

-
Tool: Pyflakes Processed Files: reviewboard/webapi/tests/urls.py reviewboard/webapi/encoder.py reviewboard/webapi/resources/__init__.py reviewboard/webapi/resources/review_file_attachment_comment.py reviewboard/webapi/resources/base_general_comment.py reviewboard/webapi/tests/test_review_general_comment.py reviewboard/webapi/tests/test_file_attachment_comment.py reviewboard/webapi/resources/screenshot_comment.py reviewboard/webapi/resources/file_attachment_comment.py reviewboard/webapi/tests/test_review_reply_general_comment.py reviewboard/webapi/resources/general_comment.py reviewboard/webapi/tests/mimetypes.py reviewboard/webapi/tests/base.py reviewboard/webapi/resources/review_general_comment.py reviewboard/webapi/resources/review_reply_general_comment.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/tests/urls.py reviewboard/webapi/encoder.py reviewboard/webapi/resources/__init__.py reviewboard/webapi/resources/review_file_attachment_comment.py reviewboard/webapi/resources/base_general_comment.py reviewboard/webapi/tests/test_review_general_comment.py reviewboard/webapi/tests/test_file_attachment_comment.py reviewboard/webapi/resources/screenshot_comment.py reviewboard/webapi/resources/file_attachment_comment.py reviewboard/webapi/tests/test_review_reply_general_comment.py reviewboard/webapi/resources/general_comment.py reviewboard/webapi/tests/mimetypes.py reviewboard/webapi/tests/base.py reviewboard/webapi/resources/review_general_comment.py reviewboard/webapi/resources/review_reply_general_comment.py
-
-
reviewboard/webapi/resources/general_comment.py (Diff revision 2) Col: 5 E303 too many blank lines (2)
-
reviewboard/webapi/resources/review_general_comment.py (Diff revision 2) local variable 'review_request' is assigned to but never used
-
reviewboard/webapi/resources/screenshot_comment.py (Diff revision 2) Col: 77 W291 trailing whitespace
-
reviewboard/webapi/tests/base.py (Diff revision 2) 'get_general_comment_list_url' imported but unused
-
reviewboard/webapi/tests/base.py (Diff revision 2) undefined name 'get_review_general_comment_list_url'
-
reviewboard/webapi/tests/test_review_reply_general_comment.py (Diff revision 2) Col: 62 E127 continuation line over-indented for visual indent
-
reviewboard/webapi/tests/test_review_reply_general_comment.py (Diff revision 2) Col: 62 E127 continuation line over-indented for visual indent
-
reviewboard/webapi/tests/test_review_reply_general_comment.py (Diff revision 2) Col: 17 E126 continuation line over-indented for hanging indent
-
reviewboard/webapi/tests/urls.py (Diff revision 2) Col: 37 E127 continuation line over-indented for visual indent
-
reviewboard/webapi/tests/urls.py (Diff revision 2) Col: 44 E127 continuation line over-indented for visual indent
-
reviewboard/webapi/tests/urls.py (Diff revision 2) Col: 50 E127 continuation line over-indented for visual indent
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+860 -14) |

-
Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/tests/urls.py reviewboard/webapi/encoder.py reviewboard/webapi/resources/__init__.py reviewboard/webapi/resources/review_file_attachment_comment.py reviewboard/webapi/resources/base_general_comment.py reviewboard/webapi/tests/test_review_general_comment.py reviewboard/webapi/tests/test_file_attachment_comment.py reviewboard/webapi/resources/screenshot_comment.py reviewboard/webapi/resources/file_attachment_comment.py reviewboard/webapi/tests/test_review_reply_general_comment.py reviewboard/webapi/resources/general_comment.py reviewboard/webapi/tests/mimetypes.py reviewboard/webapi/tests/base.py reviewboard/webapi/resources/review_general_comment.py reviewboard/webapi/resources/review_reply_general_comment.py Tool: Pyflakes Processed Files: reviewboard/webapi/tests/urls.py reviewboard/webapi/encoder.py reviewboard/webapi/resources/__init__.py reviewboard/webapi/resources/review_file_attachment_comment.py reviewboard/webapi/resources/base_general_comment.py reviewboard/webapi/tests/test_review_general_comment.py reviewboard/webapi/tests/test_file_attachment_comment.py reviewboard/webapi/resources/screenshot_comment.py reviewboard/webapi/resources/file_attachment_comment.py reviewboard/webapi/tests/test_review_reply_general_comment.py reviewboard/webapi/resources/general_comment.py reviewboard/webapi/tests/mimetypes.py reviewboard/webapi/tests/base.py reviewboard/webapi/resources/review_general_comment.py reviewboard/webapi/resources/review_reply_general_comment.py
-
reviewboard/webapi/tests/test_review_reply_general_comment.py (Diff revision 3) Col: 17 E126 continuation line over-indented for hanging indent
-
-
reviewboard/webapi/resources/base_general_comment.py (Diff revision 3) These don't really make any sense. The only filtering in here should be the
review__isnull
one, and then ReviewGeneralCommentResource and ReviewReplyGeneralCommentResource can filter to the specific review. -
reviewboard/webapi/resources/file_attachment_comment.py (Diff revision 3) This should probably be pulled out into a separate review request.
-
reviewboard/webapi/resources/general_comment.py (Diff revision 3) This resource shouldn't be necessary, because the only "object" that general comments will be attached to will be the review (or reply). The docstrings you have in here should be moved over to BaseGeneralCommentResource.
The other comments have a separate resource that's used to attach to the given object in the tree. For example, the FileAttachmentCommentResource is accessible through the FileAttachmentResource.
-
reviewboard/webapi/resources/review_file_attachment_comment.py (Diff revision 3) Please revert this change.
-
reviewboard/webapi/resources/review_file_attachment_comment.py (Diff revision 3) Why did you add this?
-
reviewboard/webapi/resources/review_file_attachment_comment.py (Diff revision 3) Why did you add this?
-
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 3) This resource definitely does support items.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+1059 -14) |

-
Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/tests/urls.py reviewboard/webapi/encoder.py reviewboard/webapi/resources/__init__.py reviewboard/webapi/resources/review_file_attachment_comment.py reviewboard/webapi/resources/base_general_comment.py reviewboard/webapi/tests/test_review_general_comment.py reviewboard/webapi/tests/test_file_attachment_comment.py reviewboard/webapi/resources/screenshot_comment.py reviewboard/webapi/resources/file_attachment_comment.py reviewboard/webapi/tests/test_review_reply_general_comment.py reviewboard/webapi/tests/mimetypes.py reviewboard/webapi/tests/base.py reviewboard/webapi/resources/review_general_comment.py reviewboard/webapi/resources/review_reply_general_comment.py Tool: Pyflakes Processed Files: reviewboard/webapi/tests/urls.py reviewboard/webapi/encoder.py reviewboard/webapi/resources/__init__.py reviewboard/webapi/resources/review_file_attachment_comment.py reviewboard/webapi/resources/base_general_comment.py reviewboard/webapi/tests/test_review_general_comment.py reviewboard/webapi/tests/test_file_attachment_comment.py reviewboard/webapi/resources/screenshot_comment.py reviewboard/webapi/resources/file_attachment_comment.py reviewboard/webapi/tests/test_review_reply_general_comment.py reviewboard/webapi/tests/mimetypes.py reviewboard/webapi/tests/base.py reviewboard/webapi/resources/review_general_comment.py reviewboard/webapi/resources/review_reply_general_comment.py
-
reviewboard/webapi/resources/base_general_comment.py (Diff revision 4) Col: 56 W292 no newline at end of file
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4) Col: 46 E127 continuation line over-indented for visual indent
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4) Col: 50 E127 continuation line over-indented for visual indent
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4) undefined name 'CommentItemMixin'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4) undefined name 'ReviewRequestChildItemMixin'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4) undefined name 'get_review_general_comment_item_url'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4) undefined name 'general_comment_item_mimetype'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4) undefined name 'get_review_general_comment_item_url'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4) undefined name 'get_review_general_comment_item_url'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4) undefined name 'get_review_general_comment_item_url'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4) undefined name 'general_comment_item_mimetype'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4) undefined name 'get_review_general_comment_item_url'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4) Col: 56 E127 continuation line over-indented for visual indent
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4) undefined name 'general_comment_item_mimetype'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4) Col: 17 E126 continuation line over-indented for hanging indent
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4) undefined name 'GeneralComment'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4) undefined name 'get_review_general_comment_item_url'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4) undefined name 'general_comment_item_mimetype'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4) undefined name 'get_review_general_comment_item_url'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4) undefined name 'general_comment_item_mimetype'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4) undefined name 'get_review_general_comment_item_url'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4) undefined name 'general_comment_item_mimetype'
-
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4) undefined name 'get_review_general_comment_item_url'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4) undefined name 'general_comment_item_mimetype'
-
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4) undefined name 'get_review_general_comment_item_url'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 4) undefined name 'PERMISSION_DENIED'
-
reviewboard/webapi/tests/test_review_reply_general_comment.py (Diff revision 4) Col: 17 E126 continuation line over-indented for hanging indent
Description: |
|
|||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
|||||||||||||||||||||
Commit: |
|
|||||||||||||||||||||
Diff: |
Revision 5 (+820 -14) |

-
Tool: Pyflakes Processed Files: reviewboard/webapi/encoder.py reviewboard/webapi/resources/__init__.py reviewboard/webapi/resources/review_file_attachment_comment.py reviewboard/webapi/resources/base_general_comment.py reviewboard/webapi/tests/test_review_general_comment.py reviewboard/webapi/tests/test_file_attachment_comment.py reviewboard/webapi/resources/screenshot_comment.py reviewboard/webapi/resources/file_attachment_comment.py reviewboard/webapi/tests/urls.py reviewboard/webapi/tests/mimetypes.py reviewboard/webapi/tests/base.py reviewboard/webapi/resources/review_general_comment.py reviewboard/webapi/resources/review_reply_general_comment.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/encoder.py reviewboard/webapi/resources/__init__.py reviewboard/webapi/resources/review_file_attachment_comment.py reviewboard/webapi/resources/base_general_comment.py reviewboard/webapi/tests/test_review_general_comment.py reviewboard/webapi/tests/test_file_attachment_comment.py reviewboard/webapi/resources/screenshot_comment.py reviewboard/webapi/resources/file_attachment_comment.py reviewboard/webapi/tests/urls.py reviewboard/webapi/tests/mimetypes.py reviewboard/webapi/tests/base.py reviewboard/webapi/resources/review_general_comment.py reviewboard/webapi/resources/review_reply_general_comment.py
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5) undefined name 'CommentListMixin'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5) undefined name 'get_review_general_comment_item_url'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5) undefined name 'general_comment_item_mimetype'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5) undefined name 'get_review_general_comment_item_url'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5) undefined name 'get_review_general_comment_item_url'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5) undefined name 'get_review_general_comment_item_url'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5) undefined name 'general_comment_item_mimetype'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5) undefined name 'get_review_general_comment_item_url'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5) undefined name 'general_comment_item_mimetype'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5) Col: 17 E126 continuation line over-indented for hanging indent
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5) undefined name 'GeneralComment'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5) undefined name 'get_review_general_comment_item_url'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5) undefined name 'general_comment_item_mimetype'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5) undefined name 'get_review_general_comment_item_url'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5) undefined name 'general_comment_item_mimetype'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5) undefined name 'get_review_general_comment_item_url'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5) undefined name 'general_comment_item_mimetype'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5) undefined name 'get_review_general_comment_item_url'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5) undefined name 'general_comment_item_mimetype'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5) undefined name 'get_review_general_comment_item_url'
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 5) undefined name 'PERMISSION_DENIED'
Description: |
|
||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
||||||||||||||||||||||||
Commit: |
|
||||||||||||||||||||||||
Diff: |
Revision 6 (+1963 -42) |

-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/templatetags/reviewtags.py reviewboard/webapi/resources/screenshot_comment.py reviewboard/webapi/tests/test_review_reply_general_comment.py reviewboard/webapi/tests/test_file_attachment_comment.py reviewboard/webapi/resources/review_reply.py reviewboard/webapi/encoder.py reviewboard/webapi/resources/review_file_attachment_comment.py reviewboard/reviews/models/__init__.py reviewboard/webapi/review_general_comment.py reviewboard/webapi/tests/urls.py reviewboard/reviews/models/review.py reviewboard/webapi/tests/base.py reviewboard/webapi/resources/review_reply_general_comment.py reviewboard/testing/testcase.py reviewboard/webapi/resources/base_file_attachment_comment.py reviewboard/webapi/resources/base_general_comment.py reviewboard/reviews/tests.py reviewboard/reviews/models/review_request.py reviewboard/reviews/models/general_comment.py reviewboard/webapi/base_file_attachment_comment.py reviewboard/webapi/resources/__init__.py reviewboard/notifications/tests.py reviewboard/webapi/review_reply.py reviewboard/webapi/tests/test_review_general_comment.py reviewboard/reviews/admin.py reviewboard/webapi/resources/file_attachment_comment.py reviewboard/webapi/tests/mimetypes.py reviewboard/webapi/resources/review.py reviewboard/notifications/webhooks.py reviewboard/webapi/resources/review_general_comment.py reviewboard/webapi/review.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/templatetags/reviewtags.py reviewboard/webapi/resources/screenshot_comment.py reviewboard/webapi/tests/test_review_reply_general_comment.py reviewboard/webapi/tests/test_file_attachment_comment.py reviewboard/webapi/resources/review_reply.py reviewboard/webapi/encoder.py reviewboard/webapi/resources/review_file_attachment_comment.py reviewboard/reviews/models/__init__.py reviewboard/webapi/review_general_comment.py reviewboard/webapi/tests/urls.py reviewboard/reviews/models/review.py reviewboard/webapi/tests/base.py reviewboard/webapi/resources/review_reply_general_comment.py reviewboard/testing/testcase.py reviewboard/webapi/resources/base_file_attachment_comment.py reviewboard/webapi/resources/base_general_comment.py reviewboard/reviews/tests.py reviewboard/reviews/models/review_request.py reviewboard/reviews/models/general_comment.py reviewboard/webapi/base_file_attachment_comment.py reviewboard/webapi/resources/__init__.py reviewboard/notifications/tests.py reviewboard/webapi/review_reply.py reviewboard/webapi/tests/test_review_general_comment.py reviewboard/reviews/admin.py reviewboard/webapi/resources/file_attachment_comment.py reviewboard/webapi/tests/mimetypes.py reviewboard/webapi/resources/review.py reviewboard/notifications/webhooks.py reviewboard/webapi/resources/review_general_comment.py reviewboard/webapi/review.py
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 6) Col: 56 E127 continuation line over-indented for visual indent
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 6) Col: 17 E126 continuation line over-indented for hanging indent
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 6) Col: 17 E126 continuation line over-indented for hanging indent
-
reviewboard/webapi/tests/test_review_reply_general_comment.py (Diff revision 6) Col: 17 E126 continuation line over-indented for hanging indent
Summary: |
|
|||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
|||||||||||||||||||||
Testing Done: |
|
|||||||||||||||||||||
Commit: |
|
|||||||||||||||||||||
Diff: |
Revision 7 (+1750 -18) |

-
Tool: Pyflakes Processed Files: reviewboard/webapi/review_general_comment.py reviewboard/webapi/resources/review_reply.py reviewboard/webapi/encoder.py reviewboard/webapi/resources/review_file_attachment_comment.py reviewboard/webapi/tests/test_file_attachment_comment.py reviewboard/webapi/tests/urls.py reviewboard/webapi/tests/base.py reviewboard/webapi/resources/review_reply_general_comment.py reviewboard/webapi/tests/test_review_reply_general_comment.py reviewboard/webapi/resources/base_general_comment.py reviewboard/webapi/resources/base_file_attachment_comment.py reviewboard/webapi/base_file_attachment_comment.py reviewboard/webapi/resources/__init__.py reviewboard/notifications/tests.py reviewboard/webapi/review_reply.py reviewboard/webapi/tests/test_review_general_comment.py reviewboard/webapi/resources/screenshot_comment.py reviewboard/webapi/resources/file_attachment_comment.py reviewboard/webapi/tests/mimetypes.py reviewboard/webapi/resources/review.py reviewboard/notifications/webhooks.py reviewboard/webapi/resources/review_general_comment.py reviewboard/webapi/review.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/review_general_comment.py reviewboard/webapi/resources/review_reply.py reviewboard/webapi/encoder.py reviewboard/webapi/resources/review_file_attachment_comment.py reviewboard/webapi/tests/test_file_attachment_comment.py reviewboard/webapi/tests/urls.py reviewboard/webapi/tests/base.py reviewboard/webapi/resources/review_reply_general_comment.py reviewboard/webapi/tests/test_review_reply_general_comment.py reviewboard/webapi/resources/base_general_comment.py reviewboard/webapi/resources/base_file_attachment_comment.py reviewboard/webapi/base_file_attachment_comment.py reviewboard/webapi/resources/__init__.py reviewboard/notifications/tests.py reviewboard/webapi/review_reply.py reviewboard/webapi/tests/test_review_general_comment.py reviewboard/webapi/resources/screenshot_comment.py reviewboard/webapi/resources/file_attachment_comment.py reviewboard/webapi/tests/mimetypes.py reviewboard/webapi/resources/review.py reviewboard/notifications/webhooks.py reviewboard/webapi/resources/review_general_comment.py reviewboard/webapi/review.py
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 7) Col: 56 E127 continuation line over-indented for visual indent
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 7) Col: 17 E126 continuation line over-indented for hanging indent
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 7) Col: 17 E126 continuation line over-indented for hanging indent
-
reviewboard/webapi/tests/test_review_reply_general_comment.py (Diff revision 7) Col: 17 E126 continuation line over-indented for hanging indent
Summary: |
|
||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 8 (+1750 -18) |

-
Tool: Pyflakes Processed Files: reviewboard/webapi/review_general_comment.py reviewboard/webapi/resources/review_reply.py reviewboard/webapi/encoder.py reviewboard/webapi/resources/review_file_attachment_comment.py reviewboard/webapi/tests/test_file_attachment_comment.py reviewboard/webapi/tests/urls.py reviewboard/webapi/tests/base.py reviewboard/webapi/resources/review_reply_general_comment.py reviewboard/webapi/tests/test_review_reply_general_comment.py reviewboard/webapi/resources/base_general_comment.py reviewboard/webapi/resources/base_file_attachment_comment.py reviewboard/webapi/base_file_attachment_comment.py reviewboard/webapi/resources/__init__.py reviewboard/notifications/tests.py reviewboard/webapi/review_reply.py reviewboard/webapi/tests/test_review_general_comment.py reviewboard/webapi/resources/screenshot_comment.py reviewboard/webapi/resources/file_attachment_comment.py reviewboard/webapi/tests/mimetypes.py reviewboard/webapi/resources/review.py reviewboard/notifications/webhooks.py reviewboard/webapi/resources/review_general_comment.py reviewboard/webapi/review.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/review_general_comment.py reviewboard/webapi/resources/review_reply.py reviewboard/webapi/encoder.py reviewboard/webapi/resources/review_file_attachment_comment.py reviewboard/webapi/tests/test_file_attachment_comment.py reviewboard/webapi/tests/urls.py reviewboard/webapi/tests/base.py reviewboard/webapi/resources/review_reply_general_comment.py reviewboard/webapi/tests/test_review_reply_general_comment.py reviewboard/webapi/resources/base_general_comment.py reviewboard/webapi/resources/base_file_attachment_comment.py reviewboard/webapi/base_file_attachment_comment.py reviewboard/webapi/resources/__init__.py reviewboard/notifications/tests.py reviewboard/webapi/review_reply.py reviewboard/webapi/tests/test_review_general_comment.py reviewboard/webapi/resources/screenshot_comment.py reviewboard/webapi/resources/file_attachment_comment.py reviewboard/webapi/tests/mimetypes.py reviewboard/webapi/resources/review.py reviewboard/notifications/webhooks.py reviewboard/webapi/resources/review_general_comment.py reviewboard/webapi/review.py
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 8) Col: 17 E126 continuation line over-indented for hanging indent
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 8) Col: 17 E126 continuation line over-indented for hanging indent
-
reviewboard/webapi/tests/test_review_reply_general_comment.py (Diff revision 8) Col: 17 E126 continuation line over-indented for hanging indent
-
Hmmm, a bunch of files from reviewboard/webapi/resources/ just got added into reviewboard/webapi/. What happened there? Something seems wrong.
Summary: |
|
||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||||||||
Commit: |
|
||||||||||||||||||
Diff: |
Revision 9 (+1122 -12) |

-
Tool: Pyflakes Processed Files: reviewboard/webapi/tests/urls.py reviewboard/webapi/encoder.py reviewboard/webapi/resources/__init__.py reviewboard/notifications/tests.py reviewboard/webapi/resources/base_general_comment.py reviewboard/webapi/tests/test_review_general_comment.py reviewboard/webapi/tests/mimetypes.py reviewboard/webapi/tests/test_review_reply_general_comment.py reviewboard/webapi/resources/review_reply.py reviewboard/webapi/resources/review.py reviewboard/notifications/webhooks.py reviewboard/webapi/tests/base.py reviewboard/webapi/resources/review_general_comment.py reviewboard/webapi/resources/review_reply_general_comment.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/tests/urls.py reviewboard/webapi/encoder.py reviewboard/webapi/resources/__init__.py reviewboard/notifications/tests.py reviewboard/webapi/resources/base_general_comment.py reviewboard/webapi/tests/test_review_general_comment.py reviewboard/webapi/tests/mimetypes.py reviewboard/webapi/tests/test_review_reply_general_comment.py reviewboard/webapi/resources/review_reply.py reviewboard/webapi/resources/review.py reviewboard/notifications/webhooks.py reviewboard/webapi/tests/base.py reviewboard/webapi/resources/review_general_comment.py reviewboard/webapi/resources/review_reply_general_comment.py
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 9) Col: 17 E126 continuation line over-indented for hanging indent
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 9) Col: 17 E126 continuation line over-indented for hanging indent
-
reviewboard/webapi/tests/test_review_reply_general_comment.py (Diff revision 9) Col: 17 E126 continuation line over-indented for hanging indent
-
-
reviewboard/webapi/encoder.py (Diff revision 9) This is no longer needed. It's for some old, deprecated support that actually probably isn't used anymore.
Now, all resource data is serialized straight from the WebAPIResource subclass.
-
reviewboard/webapi/resources/base_general_comment.py (Diff revision 9) You can remove this. Some changes will soon be pushed (currently on the markdown-redesign branch) that move all this documentation to a new page.
-
reviewboard/webapi/resources/base_general_comment.py (Diff revision 9) This class will have this automatically, so no need to copy it here.
-
reviewboard/webapi/resources/base_general_comment.py (Diff revision 9) The base class here shouldn't set this, as that's going to be up to the subclass.
-
reviewboard/webapi/resources/base_general_comment.py (Diff revision 9) For the life of me, I can't figure out why this isn't just in
BaseComment
. All subclasses use it. Maybe just introduce it there? -
reviewboard/webapi/resources/base_general_comment.py (Diff revision 9) "... the comment text and the date/time the comment was made."
-
reviewboard/webapi/resources/base_general_comment.py (Diff revision 9) This isn't true for all subclasses.
We shouldn't doc this one, and should instead only doc in the subclasses.
-
reviewboard/webapi/resources/review.py (Diff revision 9) "file attachments, or general comments not tied to any code or file."
-
-
reviewboard/webapi/resources/review_general_comment.py (Diff revision 9) Can you wrap this a bit nicer? It's awfully short, and you can fit more on a line.
-
-
reviewboard/webapi/resources/review_general_comment.py (Diff revision 9) This should all be able to fit on one line.
-
-
reviewboard/webapi/resources/review_reply_general_comment.py (Diff revision 9) Indentation problems.
Note that the summary must fit on one line.
-
-
-
-
-
-
reviewboard/webapi/tests/base.py (Diff revision 9) I know the naming is inconsistent, but this should be
_post_new_general_comment
. -
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 9) Just a note: This is going to change soon, due to the markdown-redesign branch. That will probably be merged this week. At that point, your tests will break, so look at the similar test classes when that happens to see how they changed.
-
-
reviewboard/webapi/resources/review_reply_general_comment.py (Diff revision 9) Small, but for method summaries Review Board follows one of the conventions:
"""One line summary
Long explanation, that can possible
span multiple lines.
"""or:
"""One line summary"""
Review Board adheres to the PEP standard: http://legacy.python.org/dev/peps/pep-0257/
-
-
reviewboard/webapi/tests/base.py (Diff revision 9) Small, but for method summaries Review Board follows one of the conventions:
"""One line summary
Long explanation, that can possible
span multiple lines.
"""
(make sure there's a new line)
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 10 (+1054 -12) |

-
Tool: Pyflakes Processed Files: reviewboard/webapi/tests/urls.py reviewboard/webapi/encoder.py reviewboard/webapi/resources/__init__.py reviewboard/notifications/tests.py reviewboard/webapi/tests/test_review_general_comment.py reviewboard/webapi/resources/base_review_general_comment.py reviewboard/webapi/tests/test_review_reply_general_comment.py reviewboard/webapi/resources/review_reply.py reviewboard/webapi/resources/review.py reviewboard/notifications/webhooks.py reviewboard/webapi/tests/mimetypes.py reviewboard/webapi/tests/base.py reviewboard/webapi/resources/review_general_comment.py reviewboard/webapi/resources/review_reply_general_comment.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/tests/urls.py reviewboard/webapi/encoder.py reviewboard/webapi/resources/__init__.py reviewboard/notifications/tests.py reviewboard/webapi/tests/test_review_general_comment.py reviewboard/webapi/resources/base_review_general_comment.py reviewboard/webapi/tests/test_review_reply_general_comment.py reviewboard/webapi/resources/review_reply.py reviewboard/webapi/resources/review.py reviewboard/notifications/webhooks.py reviewboard/webapi/tests/mimetypes.py reviewboard/webapi/tests/base.py reviewboard/webapi/resources/review_general_comment.py reviewboard/webapi/resources/review_reply_general_comment.py
-
-
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 10) Col: 17 E126 continuation line over-indented for hanging indent
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 10) Col: 17 E126 continuation line over-indented for hanging indent
-
reviewboard/webapi/tests/test_review_reply_general_comment.py (Diff revision 10) Col: 17 E126 continuation line over-indented for hanging indent
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 11 (+1054 -11) |

-
Tool: Pyflakes Processed Files: reviewboard/webapi/tests/urls.py reviewboard/webapi/resources/__init__.py reviewboard/notifications/tests.py reviewboard/webapi/tests/test_review_general_comment.py reviewboard/webapi/resources/base_review_general_comment.py reviewboard/webapi/tests/test_review_reply_general_comment.py reviewboard/webapi/resources/review_reply.py reviewboard/webapi/resources/review.py reviewboard/notifications/webhooks.py reviewboard/webapi/tests/mimetypes.py reviewboard/webapi/tests/base.py reviewboard/webapi/resources/review_general_comment.py reviewboard/webapi/resources/review_reply_general_comment.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/tests/urls.py reviewboard/webapi/resources/__init__.py reviewboard/notifications/tests.py reviewboard/webapi/tests/test_review_general_comment.py reviewboard/webapi/resources/base_review_general_comment.py reviewboard/webapi/tests/test_review_reply_general_comment.py reviewboard/webapi/resources/review_reply.py reviewboard/webapi/resources/review.py reviewboard/notifications/webhooks.py reviewboard/webapi/tests/mimetypes.py reviewboard/webapi/tests/base.py reviewboard/webapi/resources/review_general_comment.py reviewboard/webapi/resources/review_reply_general_comment.py
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 11) Col: 17 E126 continuation line over-indented for hanging indent
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 11) Col: 17 E126 continuation line over-indented for hanging indent
-
reviewboard/webapi/tests/test_review_reply_general_comment.py (Diff revision 11) Col: 17 E126 continuation line over-indented for hanging indent
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 12 (+1067 -11) |

-
Tool: Pyflakes Processed Files: reviewboard/webapi/tests/urls.py reviewboard/webapi/resources/base_comment.py reviewboard/webapi/resources/__init__.py reviewboard/notifications/tests.py reviewboard/webapi/tests/test_review_general_comment.py reviewboard/webapi/resources/base_review_general_comment.py reviewboard/webapi/tests/test_review_reply_general_comment.py reviewboard/webapi/resources/review_reply.py reviewboard/webapi/resources/review.py reviewboard/notifications/webhooks.py reviewboard/webapi/tests/mimetypes.py reviewboard/webapi/tests/base.py reviewboard/webapi/resources/review_general_comment.py reviewboard/webapi/resources/review_reply_general_comment.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/tests/urls.py reviewboard/webapi/resources/base_comment.py reviewboard/webapi/resources/__init__.py reviewboard/notifications/tests.py reviewboard/webapi/tests/test_review_general_comment.py reviewboard/webapi/resources/base_review_general_comment.py reviewboard/webapi/tests/test_review_reply_general_comment.py reviewboard/webapi/resources/review_reply.py reviewboard/webapi/resources/review.py reviewboard/notifications/webhooks.py reviewboard/webapi/tests/mimetypes.py reviewboard/webapi/tests/base.py reviewboard/webapi/resources/review_general_comment.py reviewboard/webapi/resources/review_reply_general_comment.py
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 12) Col: 17 E126 continuation line over-indented for hanging indent
-
reviewboard/webapi/tests/test_review_general_comment.py (Diff revision 12) Col: 17 E126 continuation line over-indented for hanging indent
-
reviewboard/webapi/tests/test_review_reply_general_comment.py (Diff revision 12) Col: 17 E126 continuation line over-indented for hanging indent
Description: |
|
||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|