Switch to a different version of marked.js that fixes in-word underscores.

Review Request #6415 — Created Oct. 7, 2014 and submitted

Information

Review Board
release-2.0.x
317764e...

Reviewers

marked.js has an infuriating bug that even when "github flavored markdown" is
turned on, it has problems with underscores in the middle of words. Worse, it
didn't handle escaped underscores in the middle of hyperlinks, so even when
they were escaped, it was broken in some cases.

This change pulls in a version of marked.js from an open pull request that
fixes these bugs, which means that we no longer have to escape them.

  • Ran unit tests
  • Posted some changes with underscores mid-word, saw that the escaping was gone
    and that all text looked correct (with no unexpected em or strong).
Description From Last Updated

Can we keep th original check as well, to make sure that f_o_o doesn't get escaped?

chipx86chipx86
chipx86
  1. 
      
  2. reviewboard/reviews/tests.py (Diff revision 1)
     
     

    Can we keep th original check as well, to make sure that f_o_o doesn't get escaped?

  3. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (4c99a9a)
Loading...