Add FileAttachmentHistory model and evolutions.

Review Request #6385 — Created Sept. 30, 2014 and submitted

Information

Review Board
master
58dd8b1...

Reviewers

This change adds a model which is used to aggregate multiple FileAttachments
together into a single "history". This will be used by future changes for the
"Update" command, allowing users to replace attachments with new versions.

Ran evolutions.

Description From Last Updated

This requires a fetch for attachment_history that isn't needed. How about: return FileAttachment.objects.filter(attachment_history=self.attachment_history_id).count() - 1

chipx86chipx86
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/attachments/evolutions/__init__.py
        reviewboard/attachments/evolutions/file_attachment_revision.py
        reviewboard/attachments/models.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/attachments/evolutions/__init__.py
        reviewboard/attachments/evolutions/file_attachment_revision.py
        reviewboard/attachments/models.py
    
    
  2. 
      
chipx86
  1. 
      
  2. reviewboard/attachments/models.py (Diff revision 1)
     
     
    Show all issues

    This requires a fetch for attachment_history that isn't needed. How about:

    return FileAttachment.objects.filter(attachment_history=self.attachment_history_id).count() - 1
    
  3. 
      
david
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/attachments/evolutions/__init__.py
        reviewboard/attachments/evolutions/file_attachment_revision.py
        reviewboard/attachments/models.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/attachments/evolutions/__init__.py
        reviewboard/attachments/evolutions/file_attachment_revision.py
        reviewboard/attachments/models.py
    
    
  2. 
      
chipx86
  1. Ship It!

  2. 
      
david
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/attachments/models.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/attachments/evolutions/__init__.py
        reviewboard/reviews/evolutions/review_request_file_attachment_histories.py
        reviewboard/reviews/models/review_request.py
        reviewboard/attachments/evolutions/file_attachment_revision.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/attachments/models.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/attachments/evolutions/__init__.py
        reviewboard/reviews/evolutions/review_request_file_attachment_histories.py
        reviewboard/reviews/models/review_request.py
        reviewboard/attachments/evolutions/file_attachment_revision.py
    
    
  2. 
      
chipx86
  1. Ship It!

  2. 
      
david
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/attachments/models.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/attachments/evolutions/__init__.py
        reviewboard/reviews/evolutions/review_request_file_attachment_histories.py
        reviewboard/reviews/models/review_request.py
        reviewboard/attachments/evolutions/file_attachment_revision.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/attachments/models.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/attachments/evolutions/__init__.py
        reviewboard/reviews/evolutions/review_request_file_attachment_histories.py
        reviewboard/reviews/models/review_request.py
        reviewboard/attachments/evolutions/file_attachment_revision.py
    
    
  2. 
      
chipx86
  1. Ship It!

  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to master (29a7ff5)