Add FileAttachmentHistory model and evolutions.
Review Request #6385 — Created Sept. 30, 2014 and submitted
This change adds a model which is used to aggregate multiple FileAttachments
together into a single "history". This will be used by future changes for the
"Update" command, allowing users to replace attachments with new versions.
Ran evolutions.
| Description | From | Last Updated |
|---|---|---|
|
This requires a fetch for attachment_history that isn't needed. How about: return FileAttachment.objects.filter(attachment_history=self.attachment_history_id).count() - 1 |
 chipx86
|
-
-
reviewboard/attachments/models.py (Diff revision 1) This requires a fetch for
attachment_historythat isn't needed. How about:return FileAttachment.objects.filter(attachment_history=self.attachment_history_id).count() - 1
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+48) |
-
Tool: PEP8 Style Checker Processed Files: reviewboard/attachments/evolutions/__init__.py reviewboard/attachments/evolutions/file_attachment_revision.py reviewboard/attachments/models.py Tool: Pyflakes Processed Files: reviewboard/attachments/evolutions/__init__.py reviewboard/attachments/evolutions/file_attachment_revision.py reviewboard/attachments/models.py
Change Summary:
Add a relation between ReviewRequest and FileAttachmentHistory (to be used for display position).
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+67 -1) |
-
Tool: Pyflakes Processed Files: reviewboard/attachments/models.py reviewboard/reviews/evolutions/__init__.py reviewboard/attachments/evolutions/__init__.py reviewboard/reviews/evolutions/review_request_file_attachment_histories.py reviewboard/reviews/models/review_request.py reviewboard/attachments/evolutions/file_attachment_revision.py Tool: PEP8 Style Checker Processed Files: reviewboard/attachments/models.py reviewboard/reviews/evolutions/__init__.py reviewboard/attachments/evolutions/__init__.py reviewboard/reviews/evolutions/review_request_file_attachment_histories.py reviewboard/reviews/models/review_request.py reviewboard/attachments/evolutions/file_attachment_revision.py
Change Summary:
Make latest_revision a field rather than a property.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+64 -1) |
-
Tool: Pyflakes Processed Files: reviewboard/attachments/models.py reviewboard/reviews/evolutions/__init__.py reviewboard/attachments/evolutions/__init__.py reviewboard/reviews/evolutions/review_request_file_attachment_histories.py reviewboard/reviews/models/review_request.py reviewboard/attachments/evolutions/file_attachment_revision.py Tool: PEP8 Style Checker Processed Files: reviewboard/attachments/models.py reviewboard/reviews/evolutions/__init__.py reviewboard/attachments/evolutions/__init__.py reviewboard/reviews/evolutions/review_request_file_attachment_histories.py reviewboard/reviews/models/review_request.py reviewboard/attachments/evolutions/file_attachment_revision.py
Tool: PEP8 Style Checker Processed Files: reviewboard/attachments/evolutions/__init__.py reviewboard/attachments/evolutions/file_attachment_revision.py reviewboard/attachments/models.py Tool: Pyflakes Processed Files: reviewboard/attachments/evolutions/__init__.py reviewboard/attachments/evolutions/file_attachment_revision.py reviewboard/attachments/models.py