• 
      

    Post-commit hooks now match repositories along with commit IDs.

    Review Request #6382 — Created Sept. 29, 2014 and submitted

    Information

    Review Board
    release-2.0.x
    0cd8f6d...

    Reviewers

    When looking up review requests for a commit, we'd attempt to find one
    that has a matching commit_id field if the commit description didn't
    explicitly specify an ID. However, this lookup did not take the
    repository into account, resulting in problems if two review requests
    across two different repositories had the same commit ID.

    This is not a major problem for Git and Mercurial. In theory, it could
    affect Subversion on Google Code, but we actually have that matching
    disabled (though we likely suffered from another bug as a result).

    The repository is now passed to the matcher function, and is required
    for commit ID matching.

    Unit tests pass.

    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/hostingsvcs/github.py
          reviewboard/hostingsvcs/googlecode.py
          reviewboard/hostingsvcs/hook_utils.py
          reviewboard/hostingsvcs/bitbucket.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/hostingsvcs/github.py
          reviewboard/hostingsvcs/googlecode.py
          reviewboard/hostingsvcs/hook_utils.py
          reviewboard/hostingsvcs/bitbucket.py
      
      
    2. 
        
    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (5cd3ce2)