Fix KeyError: u'message' in SVN commits backend.

Review Request #6361 — Created Sept. 23, 2014 and submitted

Information

Review Board
release-2.0.x
d4ccd17...

Reviewers

Not every commit we get has a message, which can cause exceptions to be thrown
from the repository commits resource. We already had one fix for this sort of
error with the author fields. This change fixes it up to do the same for
message and author everywhere.

Ran unit tests.

Description From Last Updated

What about these instances of commit['message'] and commit['author']?

ST stilor
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/scmtools/svn/__init__.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/scmtools/svn/__init__.py
    
    
  2. 
      
chipx86
  1. Ship It!

  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (99fa229)
ST
  1. 
      
  2. reviewboard/scmtools/svn/__init__.py (Diff revision 1)
     
     
     
    Show all issues

    What about these instances of commit['message'] and commit['author']?

  3. BTW, this change was checked in with a wrong reference to the issue number (3579 instead of 3570).

Loading...