Refactor SVN's filter diff into a utility function

Review Request #6357 — Created Sept. 22, 2014 and submitted

Information

RBTools
release-0.6.x
b188fca...

Reviewers

Move SVNClient._filter_diff into rbtools.utils.diffs so that it may be
used by other SCMClient instances that require filtering.

Running rbt diff -X file with multiple files modified yields the diff
for all files modified except file.

Description From Last Updated

'fnmatch' imported but unused

reviewbotreviewbot
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/svn.py
        rbtools/utils/diffs.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        rbtools/clients/svn.py
        rbtools/utils/diffs.py
    
    
  2. rbtools/clients/svn.py (Diff revision 1)
     
     
    Show all issues
     'fnmatch' imported but unused
    
  3. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/svn.py
        rbtools/utils/diffs.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/svn.py
        rbtools/utils/diffs.py
    
    
  2. 
      
david
  1. Ship It!

  2. 
      
brennie
Review request changed
Status:
Completed
Change Summary:
Pushed to release-0.6.x (02e3ae0)