Summary

Refactor SVN's filter diff into a utility function

Review Request #6357 — Created Sept. 22, 2014 and submitted Sept. 22, 2014, 3:52 p.m.

Information

Owner

brennie

Repository

RBTools

Branch

release-0.6.x

Bugs

Depends On

Blocks

6358, 6349

Commit

b188fca...

Reviewers

Groups

rbtools

People

Description

Move SVNClient._filter_diff into rbtools.utils.diffs so that it may be
used by other SCMClient instances that require filtering.

Testing Done

Running rbt diff -X file with multiple files modified yields the diff
for all files modified except file.

Issues

Description	From	Last Updated
'fnmatch' imported but unused	reviewbot	Sept. 22, 2014, 3:25 p.m.

Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/svn.py
    rbtools/utils/diffs.py



Tool: Pyflakes
Processed Files:
    rbtools/clients/svn.py
    rbtools/utils/diffs.py

rbtools/clients/svn.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'fnmatch' imported but unused
```

Change Summary:

Remove import of fnmatch from svn.py
Use a generator expression instead of a list comprehension
Remove comment that accidentally got copied from svn-specific code.

Commit:

-	0fbe1c8488aaad5b49c9944f1f171ee5afc8998d
+	b188fcacba1f48ccde88100aeacfe2779e0454c2

Diff:

Revision 2 (+36 -30)

Show changes

	rbtools/clients/svn.py
	rbtools/utils/diffs.py

Tool: Pyflakes
Processed Files:
    rbtools/clients/svn.py
    rbtools/utils/diffs.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/svn.py
    rbtools/utils/diffs.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.6.x (02e3ae0)

rbtools/clients/svn.py (Diff revision 1)