- Download Diff

Summary:

Adding TFS SCM tool support to rbtools.

Review Request #6356 — Created Sept. 22, 2014 and discarded Dec. 10, 2014, 4:49 p.m.

Information
Owner:	berdon
Repository:	RBTools
Branch:	master
Bugs:
Depends On:
Reviewers
Groups:	rbtools
People:

Description

Testing Done

Tested in conjunction with https://reviews.reviewboard.org/r/6355/ (CR for TFS SCM tool addition).

Haven't used Python in a long time (and even then it was brief) so expect stupidity.

Issues

Description	From	Last Updated
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Sept. 22, 2014, 9:45 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Sept. 22, 2014, 11:27 a.m.
Col: 19 E231 missing whitespace after ';'	reviewbot	Sept. 22, 2014, 11:28 a.m.
Col: 19 E702 multiple statements on one line (semicolon)	reviewbot	Sept. 22, 2014, 11:37 a.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Sept. 22, 2014, 11:28 a.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Sept. 22, 2014, 11:28 a.m.
Col: 80 E501 line too long (113 > 79 characters)	reviewbot	Sept. 22, 2014, 11:29 a.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Sept. 22, 2014, 11:29 a.m.
Col: 9 E301 expected 1 blank line, found 0	reviewbot	Sept. 22, 2014, 11:30 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Sept. 22, 2014, 11:30 a.m.
Col: 80 E501 line too long (86 > 79 characters)	reviewbot	Sept. 22, 2014, 11:31 a.m.
Col: 80 E501 line too long (104 > 79 characters)	reviewbot	Sept. 22, 2014, 11:31 a.m.
'json' imported but unused	reviewbot	Sept. 22, 2014, 11:31 a.m.
'json' imported but unused	reviewbot	Sept. 22, 2014, 11:38 a.m.
Col: 19 E231 missing whitespace after ';'	reviewbot	Sept. 29, 2014, 9:43 a.m.
Col: 19 E702 multiple statements on one line (semicolon)	reviewbot	Sept. 29, 2014, 9:43 a.m.
Col: 19 E231 missing whitespace after ';'	reviewbot	Sept. 29, 2014, 9:43 a.m.
Col: 19 E702 multiple statements on one line (semicolon)	reviewbot	Sept. 29, 2014, 9:43 a.m.
'json' imported but unused	reviewbot	Sept. 29, 2014, 9:43 a.m.
'json' imported but unused	reviewbot	Sept. 29, 2014, 9:44 a.m.

Tool: Pyflakes
Processed Files:
    rbtools/clients/tfs.py
    rbtools/commands/post.py
    setup.py
    rbtools/commands/__init__.py
    rbtools/commands/diff.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/tfs.py
    rbtools/commands/post.py
    setup.py
    rbtools/commands/__init__.py
    rbtools/commands/diff.py

rbtools/clients/tfs.py (Diff revision 1)

Show all issues

Col: 1
 E302 expected 2 blank lines, found 1

rbtools/clients/tfs.py (Diff revision 1)

Show all issues

Col: 80
 E501 line too long (80 > 79 characters)

rbtools/clients/tfs.py (Diff revision 1)
Show all issues
```
Col: 19
 E231 missing whitespace after ';'
```
1. BE
  
  berdon Sept. 22, 2014, 11:32 a.m.
  sigh

rbtools/clients/tfs.py (Diff revision 1)

Show all issues

Col: 19
 E702 multiple statements on one line (semicolon)

rbtools/clients/tfs.py (Diff revision 1)

Show all issues

Col: 80
 E501 line too long (92 > 79 characters)

rbtools/clients/tfs.py (Diff revision 1)

Show all issues

Col: 80
 E501 line too long (87 > 79 characters)

rbtools/clients/tfs.py (Diff revision 1)

Show all issues

Col: 80
 E501 line too long (113 > 79 characters)

rbtools/clients/tfs.py (Diff revision 1)

Show all issues

Col: 80
 E501 line too long (107 > 79 characters)

rbtools/clients/tfs.py (Diff revision 1)
Show all issues
```
Col: 9
 E301 expected 1 blank line, found 0
```

rbtools/clients/tfs.py (Diff revision 1)

Show all issues

Col: 1
 E302 expected 2 blank lines, found 1

rbtools/clients/tfs.py (Diff revision 1)

Show all issues

Col: 80
 E501 line too long (86 > 79 characters)

rbtools/clients/tfs.py (Diff revision 1)

Show all issues

Col: 80
 E501 line too long (104 > 79 characters)

setup.py (Diff revision 1)

Show all issues

 'json' imported but unused

berdon Sept. 22, 2014, 11:32 a.m.

Didn't add this...assuming it should be there considering the install_requires statement.

Change Summary:

Fixing line issues and removing a pdb.set_trace()...

Commit:

-	dbd2d4ef11c7f4ee42b22a47ae7455de75f6de4f
+	805dba8dae59fc3849d68173f784818bf58301d8

Diff:

Revision 2 (+243)

Show changes

	setup.py
	rbtools/clients/tfs.py
	rbtools/commands/__init__.py
	rbtools/commands/diff.py
	rbtools/commands/post.py

Tool: Pyflakes
Processed Files:
    rbtools/clients/tfs.py
    rbtools/commands/post.py
    setup.py
    rbtools/commands/__init__.py
    rbtools/commands/diff.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/tfs.py
    rbtools/commands/post.py
    setup.py
    rbtools/commands/__init__.py
    rbtools/commands/diff.py

setup.py (Diff revision 2)
Show all issues
```
 'json' imported but unused
```

Change Summary:

Tested (and fixed) when running on Windows.

Commit:

-	805dba8dae59fc3849d68173f784818bf58301d8
+	27664307b960fa486ec637a16ba893e51591d666

Diff:

Revision 3 (+268)

Show changes

	setup.py
	rbtools/clients/tfs.py
	rbtools/commands/__init__.py
	rbtools/commands/diff.py
	rbtools/commands/post.py
	rbtools/commands/setup_repo.py
	rbtools/commands/status.py

Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/status.py
    rbtools/commands/setup_repo.py
    rbtools/clients/tfs.py
    rbtools/commands/__init__.py
    rbtools/commands/diff.py
    rbtools/commands/post.py
    setup.py



Tool: Pyflakes
Processed Files:
    rbtools/commands/status.py
    rbtools/commands/setup_repo.py
    rbtools/clients/tfs.py
    rbtools/commands/__init__.py
    rbtools/commands/diff.py
    rbtools/commands/post.py
    setup.py

rbtools/clients/tfs.py (Diff revision 3)
Show all issues
```
Col: 19
 E231 missing whitespace after ';'
```
1. BE
  
  berdon Sept. 29, 2014, 9:43 a.m.
  And removed the trace call.

rbtools/clients/tfs.py (Diff revision 3)

Show all issues

Col: 19
 E702 multiple statements on one line (semicolon)

BE

berdon Sept. 29, 2014, 9:43 a.m.
```
And removed the trace call.
```

rbtools/clients/tfs.py (Diff revision 3)
Show all issues
```
Col: 19
 E231 missing whitespace after ';'
```
1. BE
  
  berdon Sept. 29, 2014, 9:43 a.m.
  And removed the trace call.

rbtools/clients/tfs.py (Diff revision 3)

Show all issues

Col: 19
 E702 multiple statements on one line (semicolon)

BE

berdon Sept. 29, 2014, 9:43 a.m.
```
And removed the trace call.
```

setup.py (Diff revision 3)
Show all issues
```
 'json' imported but unused
```

Change Summary:

Addressing bot findings.

Commit:

-	27664307b960fa486ec637a16ba893e51591d666
+	e267097f3e78d02138385cf4c66ef599432b9346

Diff:

Revision 4 (+263)

Show changes

	setup.py
	rbtools/clients/tfs.py
	rbtools/commands/__init__.py
	rbtools/commands/diff.py
	rbtools/commands/post.py
	rbtools/commands/setup_repo.py
	rbtools/commands/status.py

Tool: Pyflakes
Processed Files:
    rbtools/commands/status.py
    rbtools/commands/setup_repo.py
    rbtools/clients/tfs.py
    rbtools/commands/__init__.py
    rbtools/commands/diff.py
    rbtools/commands/post.py
    setup.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/status.py
    rbtools/commands/setup_repo.py
    rbtools/clients/tfs.py
    rbtools/commands/__init__.py
    rbtools/commands/diff.py
    rbtools/commands/post.py
    setup.py

setup.py (Diff revision 4)
Show all issues
```
 'json' imported but unused
```

You have a pending review.

Review Board 5.0.2 alpha 0 (dev)

Adding TFS SCM tool support to rbtools.

Change Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Status: Discarded