Adding TFS SCM tool support to rbtools.

Review Request #6356 — Created Sept. 22, 2014 and discarded

Information

RBTools
master

Reviewers

Adding TFS SCM tool support to rbtools.

Tested in conjunction with https://reviews.reviewboard.org/r/6355/ (CR for TFS SCM tool addition).

Haven't used Python in a long time (and even then it was brief) so expect stupidity.

Description From Last Updated

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 19 E231 missing whitespace after ';'

reviewbotreviewbot

Col: 19 E702 multiple statements on one line (semicolon)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (113 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 9 E301 expected 1 blank line, found 0

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

Col: 80 E501 line too long (86 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (104 > 79 characters)

reviewbotreviewbot

'json' imported but unused

reviewbotreviewbot

'json' imported but unused

reviewbotreviewbot

Col: 19 E231 missing whitespace after ';'

reviewbotreviewbot

Col: 19 E702 multiple statements on one line (semicolon)

reviewbotreviewbot

Col: 19 E231 missing whitespace after ';'

reviewbotreviewbot

Col: 19 E702 multiple statements on one line (semicolon)

reviewbotreviewbot

'json' imported but unused

reviewbotreviewbot

'json' imported but unused

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/tfs.py
        rbtools/commands/post.py
        setup.py
        rbtools/commands/__init__.py
        rbtools/commands/diff.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/tfs.py
        rbtools/commands/post.py
        setup.py
        rbtools/commands/__init__.py
        rbtools/commands/diff.py
    
    
  2. rbtools/clients/tfs.py (Diff revision 1)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  3. rbtools/clients/tfs.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  4. rbtools/clients/tfs.py (Diff revision 1)
     
     
    Show all issues
    Col: 19
     E231 missing whitespace after ';'
    
  5. rbtools/clients/tfs.py (Diff revision 1)
     
     
    Show all issues
    Col: 19
     E702 multiple statements on one line (semicolon)
    
  6. rbtools/clients/tfs.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  7. rbtools/clients/tfs.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (87 > 79 characters)
    
  8. rbtools/clients/tfs.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (113 > 79 characters)
    
  9. rbtools/clients/tfs.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (107 > 79 characters)
    
  10. rbtools/clients/tfs.py (Diff revision 1)
     
     
    Show all issues
    Col: 9
     E301 expected 1 blank line, found 0
    
  11. rbtools/clients/tfs.py (Diff revision 1)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  12. rbtools/clients/tfs.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (86 > 79 characters)
    
  13. rbtools/clients/tfs.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (104 > 79 characters)
    
  14. setup.py (Diff revision 1)
     
     
    Show all issues
     'json' imported but unused
    
    1. Didn't add this...assuming it should be there considering the install_requires statement.

  15. 
      
BE
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/tfs.py
        rbtools/commands/post.py
        setup.py
        rbtools/commands/__init__.py
        rbtools/commands/diff.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/tfs.py
        rbtools/commands/post.py
        setup.py
        rbtools/commands/__init__.py
        rbtools/commands/diff.py
    
    
  2. setup.py (Diff revision 2)
     
     
    Show all issues
     'json' imported but unused
    
  3. 
      
BE
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/status.py
        rbtools/commands/setup_repo.py
        rbtools/clients/tfs.py
        rbtools/commands/__init__.py
        rbtools/commands/diff.py
        rbtools/commands/post.py
        setup.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        rbtools/commands/status.py
        rbtools/commands/setup_repo.py
        rbtools/clients/tfs.py
        rbtools/commands/__init__.py
        rbtools/commands/diff.py
        rbtools/commands/post.py
        setup.py
    
    
  2. rbtools/clients/tfs.py (Diff revision 3)
     
     
    Show all issues
    Col: 19
     E231 missing whitespace after ';'
    
    1. And removed the trace call.

  3. rbtools/clients/tfs.py (Diff revision 3)
     
     
    Show all issues
    Col: 19
     E702 multiple statements on one line (semicolon)
    
    1. And removed the trace call.

  4. rbtools/clients/tfs.py (Diff revision 3)
     
     
    Show all issues
    Col: 19
     E231 missing whitespace after ';'
    
    1. And removed the trace call.

  5. rbtools/clients/tfs.py (Diff revision 3)
     
     
    Show all issues
    Col: 19
     E702 multiple statements on one line (semicolon)
    
    1. And removed the trace call.

  6. setup.py (Diff revision 3)
     
     
    Show all issues
     'json' imported but unused
    
  7. 
      
BE
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/commands/status.py
        rbtools/commands/setup_repo.py
        rbtools/clients/tfs.py
        rbtools/commands/__init__.py
        rbtools/commands/diff.py
        rbtools/commands/post.py
        setup.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/status.py
        rbtools/commands/setup_repo.py
        rbtools/clients/tfs.py
        rbtools/commands/__init__.py
        rbtools/commands/diff.py
        rbtools/commands/post.py
        setup.py
    
    
  2. setup.py (Diff revision 4)
     
     
    Show all issues
     'json' imported but unused
    
  3. 
      
BE
Review request changed
Status:
Discarded