Fix sample usage instructions for post-commit hooks on Local Sites.

Review Request #6353 — Created Sept. 21, 2014 and submitted

Information

Review Board
release-2.0.x
915c907...

Reviewers

The usage instructions were showing review request URLs off the root of
the site, rather than ones from a Local Site. We now generate a URL (and
a sample ID, for consistency) and send it off to the template for
rendering.

There's also a fix for some non-localized usage text ("Or:").

Tested each of these services both with and without Local Sites.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/github.py
        reviewboard/hostingsvcs/googlecode.py
        reviewboard/hostingsvcs/bitbucket.py
    
    Ignored Files:
        reviewboard/templates/hostingsvcs/bitbucket/repo_hook_instructions.html
        reviewboard/templates/hostingsvcs/github/repo_hook_instructions.html
        reviewboard/templates/hostingsvcs/googlecode/repo_hook_instructions.html
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/github.py
        reviewboard/hostingsvcs/googlecode.py
        reviewboard/hostingsvcs/bitbucket.py
    
    Ignored Files:
        reviewboard/templates/hostingsvcs/bitbucket/repo_hook_instructions.html
        reviewboard/templates/hostingsvcs/github/repo_hook_instructions.html
        reviewboard/templates/hostingsvcs/googlecode/repo_hook_instructions.html
    
    
  2. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (f2a9ec3)
Loading...