Summary

[WIP] Drag 'n Drop Inline Images

Review Request #6351 — Created Sept. 21, 2014 and discarded Oct. 17, 2014, 1:19 p.m.

Information

Owner

dkus

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard, students

People

Description

Adding support for dragging and dropping images into the markdown editor. Instead of having upload their image first and then link to that image, users can simply drag-and-drop their image file into the markdown editor. This will upload the image to reviewboard and insert a link to that image in the editor.

To accomplish this, a new resource for uesr file attachments was added (see https://reviews.reviewboard.org/r/6220/ for initial work) and some modifications to the markdown editor JS were made to support drag-and-drop (see https://reviews.reviewboard.org/r/5954/ for initial work).

Still a work-in-progress.
Ignore all the JavaScript files for now please

Testing Done

Issues

Description	From	Last Updated
Make sure to keep the includes in alphabetical order. so put this under fileAttachmentCommentReplyModel.js	ML mloyzer	Oct. 8, 2014, 3:19 p.m.
Alphabetical order again.	ML mloyzer	Oct. 8, 2014, 3:19 p.m.
'FILE_ALREADY_EXISTS' imported but unused	reviewbot	Oct. 2, 2014, 5:28 a.m.
Col: 9 E265 block comment should start with '# '	reviewbot	Oct. 2, 2014, 5:28 a.m.
Col: 9 E265 block comment should start with '# '	reviewbot	Oct. 2, 2014, 5:28 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 11, 2014, 1:57 p.m.
Col: 18 E251 unexpected spaces around keyword / parameter equals	reviewbot	Oct. 11, 2014, 1:57 p.m.
Col: 19 E502 the backslash is redundant between brackets	reviewbot	Oct. 11, 2014, 1:57 p.m.
Col: 18 E251 unexpected spaces around keyword / parameter equals	reviewbot	Oct. 11, 2014, 2:26 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/root.py
    reviewboard/attachments/models.py
    reviewboard/webapi/errors.py
    reviewboard/attachments/evolutions/__init__.py
    reviewboard/attachments/mimetypes.py
    reviewboard/attachments/evolutions/file_attachment_ownership.py
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/attachments/forms.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/dndUploaderView.js
    reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/resources/models/apiTokenModel.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/views/markdownEditorView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/root.py
    reviewboard/attachments/models.py
    reviewboard/webapi/errors.py
    reviewboard/attachments/evolutions/__init__.py
    reviewboard/attachments/mimetypes.py
    reviewboard/attachments/evolutions/file_attachment_ownership.py
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/attachments/forms.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/dndUploaderView.js
    reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/resources/models/apiTokenModel.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/views/markdownEditorView.js

Hey David.

I haven't looked at the change yet, but can you change the description to first summarize what this feature provides and how it's implemented, and then later in the description, refer to the other review requests?

Every review request filed should strive to convey enough information for the reviewers to know exactly what the change is about without having to click on any other links. These descriptions are also used for commit messages, which we try to keep detailed and individually descriptive.

Change Summary:: Updating description with some more detailed information.
Description:: ~
Adding new resource for user file attachments and initial work for supporting drag-and-drop images into markdown editor. New RR combining https://reviews.reviewboard.org/r/6220/ and https://reviews.reviewboard.org/r/5954/ (with some modifications right now).
~
Adding support for dragging and dropping images into the markdown editor. Instead of having upload their image first and then link to that image, users can simply drag-and-drop their image file into the markdown editor. This will upload the image to reviewboard and insert a link to that image in the editor.
+
+
To accomplish this, a new resource for uesr file attachments was added (see https://reviews.reviewboard.org/r/6220/ for initial work) and some modifications to the markdown editor JS were made to support drag-and-drop (see https://reviews.reviewboard.org/r/5954/ for initial work).
+
+
Still a work-in-progress.

Some minor nitpicky alphabetical ordering fixes.

reviewboard/staticbundles.py (Diff revision 1)

The issue has been dropped. Show all issues

Make sure to keep the includes in alphabetical order. so put this under fileAttachmentCommentReplyModel.js

dkus Sept. 24, 2014, 7:03 p.m.

Should they be in alphabetical order or dependency order? There is a note saying to keep em in dependency order.

mloyzer Sept. 24, 2014, 7:13 p.m.

I was under the impression it was alphabetical but maybe wait for someone else to confirm

mloyzer Oct. 2, 2014, 11:07 a.m.

FYI: I did ask last meeting (forgot to update here) but they did say the ordering is alphabetical. There are 3 groups (Django imports, reviewboard imports, and Python imports [i think]) and within each of those groups they are sorted alphabetically.

david Oct. 2, 2014, 11:12 a.m.

Ah, so that answer was for python imports. For these, they're in dependency order (and alphabetical when it doesn't matter).

reviewboard/staticbundles.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Alphabetical order again.
```

Change Summary:

Some work on the Create & Update endpoints for user file attachments

Commit:

4107dc8020ba48d71810686abb6910f9b2da3640

b87f78958262925f140bf5c5804b4999d72c9a66

Diff:

Revision 2 (+640 -67)

Show changes

	reviewboard/staticbundles.py
	reviewboard/attachments/forms.py
	reviewboard/attachments/mimetypes.py
	reviewboard/attachments/models.py
	reviewboard/attachments/evolutions/__init__.py
	reviewboard/attachments/evolutions/file_attachment_ownership.py
	reviewboard/static/rb/js/resources/models/apiTokenModel.js
	reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js
	7 more

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/root.py
    reviewboard/attachments/models.py
    reviewboard/webapi/errors.py
    reviewboard/attachments/evolutions/__init__.py
    reviewboard/attachments/mimetypes.py
    reviewboard/attachments/evolutions/file_attachment_ownership.py
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/attachments/forms.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/dndUploaderView.js
    reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/resources/models/apiTokenModel.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/views/markdownEditorView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/root.py
    reviewboard/attachments/models.py
    reviewboard/webapi/errors.py
    reviewboard/attachments/evolutions/__init__.py
    reviewboard/attachments/mimetypes.py
    reviewboard/attachments/evolutions/file_attachment_ownership.py
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/attachments/forms.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/dndUploaderView.js
    reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/resources/models/apiTokenModel.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/views/markdownEditorView.js

reviewboard/webapi/resources/file_attachment_user.py (Diff revision 2)
The issue has been resolved. Show all issues
```
 'FILE_ALREADY_EXISTS' imported but unused
```
reviewboard/webapi/resources/file_attachment_user.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 9
 E265 block comment should start with '# '
```
reviewboard/webapi/resources/file_attachment_user.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 9
 E265 block comment should start with '# '
```

Commit:

b87f78958262925f140bf5c5804b4999d72c9a66

6869a30d83d04c5884d714d915a68c49787b0df0

Diff:

Revision 3 (+643 -67)

Show changes

	reviewboard/staticbundles.py
	reviewboard/attachments/forms.py
	reviewboard/attachments/mimetypes.py
	reviewboard/attachments/models.py
	reviewboard/attachments/evolutions/__init__.py
	reviewboard/attachments/evolutions/file_attachment_ownership.py
	reviewboard/static/rb/js/resources/models/apiTokenModel.js
	reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js
	7 more

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/root.py
    reviewboard/attachments/models.py
    reviewboard/webapi/errors.py
    reviewboard/attachments/evolutions/__init__.py
    reviewboard/attachments/mimetypes.py
    reviewboard/attachments/evolutions/file_attachment_ownership.py
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/attachments/forms.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/dndUploaderView.js
    reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/resources/models/apiTokenModel.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/views/markdownEditorView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/root.py
    reviewboard/attachments/models.py
    reviewboard/webapi/errors.py
    reviewboard/attachments/evolutions/__init__.py
    reviewboard/attachments/mimetypes.py
    reviewboard/attachments/evolutions/file_attachment_ownership.py
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/attachments/forms.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/dndUploaderView.js
    reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/resources/models/apiTokenModel.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/views/markdownEditorView.js

Description:

		Adding support for dragging and dropping images into the markdown editor. Instead of having upload their image first and then link to that image, users can simply drag-and-drop their image file into the markdown editor. This will upload the image to reviewboard and insert a link to that image in the editor.

		To accomplish this, a new resource for uesr file attachments was added (see https://reviews.reviewboard.org/r/6220/ for initial work) and some modifications to the markdown editor JS were made to support drag-and-drop (see https://reviews.reviewboard.org/r/5954/ for initial work).

~		Still a work-in-progress.
	~	Still a work-in-progress.
	+	Ignore all the JavaScript files for now please

Commit:

6869a30d83d04c5884d714d915a68c49787b0df0

0a6436ae7cf97442fcc55e6b1270daaeb92b346e

Diff:

Revision 4 (+904 -322)

Show changes

	reviewboard/staticbundles.py
	reviewboard/attachments/forms.py
	reviewboard/attachments/mimetypes.py
	reviewboard/attachments/models.py
	reviewboard/attachments/evolutions/__init__.py
	reviewboard/attachments/evolutions/file_attachment_ownership.py
	reviewboard/static/rb/js/resources/models/apiTokenModel.js
	reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js
	12 more

Commit:

0a6436ae7cf97442fcc55e6b1270daaeb92b346e

db7dd3205cf80e641c304d60f79cc839ebfa5680

Diff:

Revision 5 (+897 -323)

Show changes

	reviewboard/staticbundles.py
	reviewboard/attachments/forms.py
	reviewboard/attachments/mimetypes.py
	reviewboard/attachments/models.py
	reviewboard/attachments/evolutions/__init__.py
	reviewboard/attachments/evolutions/file_attachment_ownership.py
	reviewboard/static/rb/js/resources/models/apiTokenModel.js
	reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js
	12 more

Commit:

db7dd3205cf80e641c304d60f79cc839ebfa5680

37cf33b673807e79a97fab587b92c9eef3e92aed

Diff:

Revision 6 (+933 -323)

Show changes

	reviewboard/staticbundles.py
	reviewboard/attachments/forms.py
	reviewboard/attachments/mimetypes.py
	reviewboard/attachments/models.py
	reviewboard/attachments/evolutions/__init__.py
	reviewboard/attachments/evolutions/file_attachment_ownership.py
	reviewboard/static/rb/js/resources/models/apiTokenModel.js
	reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js
	12 more

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/draft_file_attachment.py
    reviewboard/webapi/resources/diff_file_attachment.py
    reviewboard/attachments/models.py
    reviewboard/webapi/errors.py
    reviewboard/attachments/evolutions/__init__.py
    reviewboard/attachments/mimetypes.py
    reviewboard/attachments/evolutions/file_attachment_ownership.py
    reviewboard/webapi/resources/file_attachment.py
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/webapi/resources/base_review_request_file_attachment.py
    reviewboard/attachments/forms.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/dndUploaderView.js
    reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/resources/models/apiTokenModel.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/views/markdownEditorView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/draft_file_attachment.py
    reviewboard/webapi/resources/diff_file_attachment.py
    reviewboard/attachments/models.py
    reviewboard/webapi/errors.py
    reviewboard/attachments/evolutions/__init__.py
    reviewboard/attachments/mimetypes.py
    reviewboard/attachments/evolutions/file_attachment_ownership.py
    reviewboard/webapi/resources/file_attachment.py
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/webapi/resources/base_review_request_file_attachment.py
    reviewboard/attachments/forms.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/dndUploaderView.js
    reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/resources/models/apiTokenModel.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/views/markdownEditorView.js

reviewboard/webapi/resources/diff_file_attachment.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```

Commit:

37cf33b673807e79a97fab587b92c9eef3e92aed

77995d530c7e6b2cf964eec0b525a56f6b4af10c

Diff:

Revision 7 (+934 -323)

Show changes

	reviewboard/staticbundles.py
	reviewboard/attachments/forms.py
	reviewboard/attachments/mimetypes.py
	reviewboard/attachments/models.py
	reviewboard/attachments/evolutions/__init__.py
	reviewboard/attachments/evolutions/file_attachment_ownership.py
	reviewboard/static/rb/js/resources/models/apiTokenModel.js
	reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js
	12 more

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/draft_file_attachment.py
    reviewboard/webapi/resources/diff_file_attachment.py
    reviewboard/attachments/models.py
    reviewboard/webapi/errors.py
    reviewboard/attachments/evolutions/__init__.py
    reviewboard/attachments/mimetypes.py
    reviewboard/attachments/evolutions/file_attachment_ownership.py
    reviewboard/webapi/resources/file_attachment.py
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/webapi/resources/base_review_request_file_attachment.py
    reviewboard/attachments/forms.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/dndUploaderView.js
    reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/resources/models/apiTokenModel.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/views/markdownEditorView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/draft_file_attachment.py
    reviewboard/webapi/resources/diff_file_attachment.py
    reviewboard/attachments/models.py
    reviewboard/webapi/errors.py
    reviewboard/attachments/evolutions/__init__.py
    reviewboard/attachments/mimetypes.py
    reviewboard/attachments/evolutions/file_attachment_ownership.py
    reviewboard/webapi/resources/file_attachment.py
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/webapi/resources/base_review_request_file_attachment.py
    reviewboard/attachments/forms.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/dndUploaderView.js
    reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/resources/models/apiTokenModel.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/views/markdownEditorView.js

reviewboard/webapi/resources/diff_file_attachment.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Col: 18
 E251 unexpected spaces around keyword / parameter equals
```
reviewboard/webapi/resources/diff_file_attachment.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Col: 19
 E502 the backslash is redundant between brackets
```

Commit:

77995d530c7e6b2cf964eec0b525a56f6b4af10c

5d8f8cb6c100c28783ff928cf0fd5b36de694c9a

Diff:

Revision 8 (+934 -323)

Show changes

	reviewboard/staticbundles.py
	reviewboard/attachments/forms.py
	reviewboard/attachments/mimetypes.py
	reviewboard/attachments/models.py
	reviewboard/attachments/evolutions/__init__.py
	reviewboard/attachments/evolutions/file_attachment_ownership.py
	reviewboard/static/rb/js/resources/models/apiTokenModel.js
	reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js
	12 more

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/draft_file_attachment.py
    reviewboard/webapi/resources/diff_file_attachment.py
    reviewboard/attachments/models.py
    reviewboard/webapi/errors.py
    reviewboard/attachments/evolutions/__init__.py
    reviewboard/attachments/mimetypes.py
    reviewboard/attachments/evolutions/file_attachment_ownership.py
    reviewboard/webapi/resources/file_attachment.py
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/webapi/resources/base_review_request_file_attachment.py
    reviewboard/attachments/forms.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/dndUploaderView.js
    reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/resources/models/apiTokenModel.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/views/markdownEditorView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/draft_file_attachment.py
    reviewboard/webapi/resources/diff_file_attachment.py
    reviewboard/attachments/models.py
    reviewboard/webapi/errors.py
    reviewboard/attachments/evolutions/__init__.py
    reviewboard/attachments/mimetypes.py
    reviewboard/attachments/evolutions/file_attachment_ownership.py
    reviewboard/webapi/resources/file_attachment.py
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/webapi/resources/base_review_request_file_attachment.py
    reviewboard/attachments/forms.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/dndUploaderView.js
    reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/resources/models/apiTokenModel.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/views/markdownEditorView.js

reviewboard/webapi/resources/diff_file_attachment.py (Diff revision 8)
The issue has been resolved. Show all issues
```
Col: 18
 E251 unexpected spaces around keyword / parameter equals
```

Commit:

5d8f8cb6c100c28783ff928cf0fd5b36de694c9a

990a6b14a32e0114c04e5d2e0a629f4f3a817f0c

Diff:

Revision 9 (+934 -323)

Show changes

	reviewboard/staticbundles.py
	reviewboard/attachments/forms.py
	reviewboard/attachments/mimetypes.py
	reviewboard/attachments/models.py
	reviewboard/attachments/evolutions/__init__.py
	reviewboard/attachments/evolutions/file_attachment_ownership.py
	reviewboard/static/rb/js/resources/models/apiTokenModel.js
	reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js
	12 more

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/draft_file_attachment.py
    reviewboard/webapi/resources/diff_file_attachment.py
    reviewboard/attachments/models.py
    reviewboard/webapi/errors.py
    reviewboard/attachments/evolutions/__init__.py
    reviewboard/attachments/mimetypes.py
    reviewboard/attachments/evolutions/file_attachment_ownership.py
    reviewboard/webapi/resources/file_attachment.py
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/webapi/resources/base_review_request_file_attachment.py
    reviewboard/attachments/forms.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/dndUploaderView.js
    reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/resources/models/apiTokenModel.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/views/markdownEditorView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/draft_file_attachment.py
    reviewboard/webapi/resources/diff_file_attachment.py
    reviewboard/attachments/models.py
    reviewboard/webapi/errors.py
    reviewboard/attachments/evolutions/__init__.py
    reviewboard/attachments/mimetypes.py
    reviewboard/attachments/evolutions/file_attachment_ownership.py
    reviewboard/webapi/resources/file_attachment.py
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/webapi/resources/base_review_request_file_attachment.py
    reviewboard/attachments/forms.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/dndUploaderView.js
    reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/resources/models/apiTokenModel.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/views/markdownEditorView.js

Status:: Discarded
Change Summary:: Splitting this into two seperate review requests, one for backend and one for frontend. See https://reviews.reviewboard.org/r/6454/

~		Adding new resource for user file attachments and initial work for supporting drag-and-drop images into markdown editor. New RR combining https://reviews.reviewboard.org/r/6220/ and https://reviews.reviewboard.org/r/5954/ (with some modifications right now).
	~	Adding support for dragging and dropping images into the markdown editor. Instead of having upload their image first and then link to that image, users can simply drag-and-drop their image file into the markdown editor. This will upload the image to reviewboard and insert a link to that image in the editor.
	+
	+	To accomplish this, a new resource for uesr file attachments was added (see https://reviews.reviewboard.org/r/6220/ for initial work) and some modifications to the markdown editor JS were made to support drag-and-drop (see https://reviews.reviewboard.org/r/5954/ for initial work).
	+
	+	Still a work-in-progress.