Moves localized string to javascript, in the prompt to discard a draft review
Review Request #6346 — Created Sept. 20, 2014 and submitted
| Information | |
|---|---|
| justy777 | |
| Review Board | |
| master | |
| 3300 | |
| 70e20e5... | |
| Reviewers | |
| reviewboard, students | |
Making the last few changes on code that fixed an issue, where there was no prompt after pressing the Discard Review button on draft reviews.
This moves embedded localized strings to javascript from of HTML.
Tested Visually (in both Chrome and Firefox)
Both tested with and without clicking 'ok' on the draft review under a comment or issue.
. Clicking the Discard Review button, then clicking cancel closes the prompt.
. Clicking the Discard Review button, then clicking discard exits the review and gets you back to the review request.
| Description | From | Last Updated |
|---|---|---|
|
There's no trailing comma here, so this will actaully break. Make sure you test this, and have Testing Done reflect … |
 chipx86
|
Change Summary:
rebased on origin/master branch
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+37 -11) |
-
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/views/reviewDialogView.js AUTHORS Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/views/reviewDialogView.js AUTHORS
Change Summary:
rebases on the new master
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+6 -3) |
-
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/views/reviewDialogView.js AUTHORS Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/views/reviewDialogView.js AUTHORS
Summary: |
|
|||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
|||||||||||||||
Testing Done: |
|
-
Make sure every single summary, description, and testing done can be read without knowledge of other changes or bug numbers. "Issue XXX" shoudn't be in the summary, just in the bugs field, and I should be able to get a sense of the change from seeing just the summary, with complete details by reading the description.
-
-
reviewboard/static/rb/js/views/reviewDialogView.js (Diff revision 3) There's no trailing comma here, so this will actaully break. Make sure you test this, and have Testing Done reflect the changes in this change, rather than the prior one.
Change Summary:
Adding detail to the 'testing done' field
Testing Done: |
|
|---|
Change Summary:
added in missing comma on line 773
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+6 -3) |
-
Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/views/reviewDialogView.js AUTHORS Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/views/reviewDialogView.js AUTHORS
-
Looks good! Just one thing - can you modify your summary and description such that someone could read and understand it without reading up on the bug (issue 3300) you're referencing?
Change Summary:
Updated the summary, description, and testing done.
Summary: |
|
||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||||||||||||||
Testing Done: |
|
Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/views/reviewDialogView.js AUTHORS Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/views/reviewDialogView.js AUTHORS