Moves localized string to javascript, in the prompt to discard a draft review

Review Request #6346 — Created Sept. 20, 2014 and submitted

Information

Review Board
master
70e20e5...

Reviewers

Making the last few changes on code that fixed an issue, where there was no prompt after pressing the Discard Review button on draft reviews.

This moves embedded localized strings to javascript from of HTML.

Tested Visually (in both Chrome and Firefox)

Both tested with and without clicking 'ok' on the draft review under a comment or issue.

. Clicking the Discard Review button, then clicking cancel closes the prompt.
. Clicking the Discard Review button, then clicking discard exits the review and gets you back to the review request.

Description From Last Updated

There's no trailing comma here, so this will actaully break. Make sure you test this, and have Testing Done reflect …

chipx86chipx86
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/views/reviewDialogView.js
        AUTHORS
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/views/reviewDialogView.js
        AUTHORS
    
    
  2. 
      
justy777
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/views/reviewDialogView.js
        AUTHORS
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/views/reviewDialogView.js
        AUTHORS
    
    
  2. 
      
justy777
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/views/reviewDialogView.js
        AUTHORS
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/views/reviewDialogView.js
        AUTHORS
    
    
  2. 
      
david
  1. Can you update the summary and description to reflect the limited scope of this change?

  2. 
      
justy777
justy777
chipx86
  1. Make sure every single summary, description, and testing done can be read without knowledge of other changes or bug numbers. "Issue XXX" shoudn't be in the summary, just in the bugs field, and I should be able to get a sense of the change from seeing just the summary, with complete details by reading the description.

  2. 
      
chipx86
  1. 
      
  2. Show all issues

    There's no trailing comma here, so this will actaully break. Make sure you test this, and have Testing Done reflect the changes in this change, rather than the prior one.

  3. 
      
justy777
justy777
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/views/reviewDialogView.js
        AUTHORS
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/views/reviewDialogView.js
        AUTHORS
    
    
  2. 
      
anselina
  1. Looks good! Just one thing - can you modify your summary and description such that someone could read and understand it without reading up on the bug (issue 3300) you're referencing?

  2. 
      
justy777
david
  1. Ship It!

  2. 
      
justy777
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.0.x (f3caa29)