Add -X support for the svn SCMClient.
Review Request #6345 — Created Sept. 20, 2014 and submitted
| Information | |
|---|---|
| brennie | |
| RBTools | |
| master | |
|
|
|
| 5a8fae4... | |
| Reviewers | |
| rbtools, students | |
The svn backend now supports excluding files through a
filterdiff-esque method:SVNClient._filter_diff. This
method looks through the output ofsvn difffor lines
that begin withIndex:that mark the beginning of a
new file in the diff. If the file matches any given
patterns, it will not yield the lines corresponding to
that file's diff.
Ran
rbt diff -X ...in an SVN repository and successfully
excluded files and empty files.
| Description | From | Last Updated |
|---|---|---|
|
If for some reason there's text at the beginning of the diff before the first index line (which is valid), … |
 david
|
|
|
Should have a trailing period. Can you add more details to this comment to describe what's happening in the change? … |
 chipx86
|
|
|
Blank line between statements and blocks. |
chipx86
|
|
|
Here too. Also, minor thing, but we usually just use m for this variable. Not a big deal, but doesn't … |
chipx86
|
|
|
And here. |
chipx86
|
|
|
What about on Windows? |
chipx86
|
|
|
Summary should be on the same line as the """. |
chipx86
|
Change Summary:
Depend on -X support for git (for documentation changes).
Depends On: |
|
|---|
Change Summary:
Newlines no longer included in matched filename.
Fix including self in call to_filter_difftwice.
Diff: |
Revision 2 (+25 -2) |
|---|
-
Tool: Pyflakes Processed Files: rbtools/clients/svn.py Ignored Files: docs/rbtools/rbt/commands/post.rst docs/rbtools/rbt/commands/diff.rst Tool: PEP8 Style Checker Processed Files: rbtools/clients/svn.py Ignored Files: docs/rbtools/rbt/commands/post.rst docs/rbtools/rbt/commands/diff.rst
-
-
rbtools/clients/svn.py (Diff revision 2) If for some reason there's text at the beginning of the diff before the first index line (which is valid), it will cause a
NameErrorhere, sinceinclude_filehasn't yet been set. Can you setinclude_file = Trueat the top of this function?
Change Summary:
Avoid
NameErrorwhen diff includes lines before anIndex:line
Diff: |
Revision 3 (+26 -2) |
|---|
-
Tool: Pyflakes Processed Files: rbtools/clients/svn.py Ignored Files: docs/rbtools/rbt/commands/post.rst docs/rbtools/rbt/commands/diff.rst Tool: PEP8 Style Checker Processed Files: rbtools/clients/svn.py Ignored Files: docs/rbtools/rbt/commands/post.rst docs/rbtools/rbt/commands/diff.rst
-
-
rbtools/clients/svn.py (Diff revision 3) Should have a trailing period.
Can you add more details to this comment to describe what's happening in the change?
I'm also interested in why we're filtering and not using
-x. Did it turn out that we couldn't pass that to SVN? -
-
rbtools/clients/svn.py (Diff revision 3) Here too.
Also, minor thing, but we usually just use
mfor this variable. Not a big deal, but doesn't hurt to be consistent. -
-
Change Summary:
Fix issues as per chipx86
Description: |
|
||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
||||||||||||||||||||||||
Diff: |
Revision 4 (+38 -2) |
-
Tool: Pyflakes Processed Files: rbtools/clients/svn.py Ignored Files: docs/rbtools/rbt/commands/post.rst docs/rbtools/rbt/commands/diff.rst Tool: PEP8 Style Checker Processed Files: rbtools/clients/svn.py Ignored Files: docs/rbtools/rbt/commands/post.rst docs/rbtools/rbt/commands/diff.rst
-
One last thing!
-
Tool: Pyflakes Processed Files: rbtools/clients/svn.py Ignored Files: docs/rbtools/rbt/commands/post.rst docs/rbtools/rbt/commands/diff.rst Tool: PEP8 Style Checker Processed Files: rbtools/clients/svn.py Ignored Files: docs/rbtools/rbt/commands/post.rst docs/rbtools/rbt/commands/diff.rst