Allow specifying svn credentials on the command-line/.reviewboardrc file.
Review Request #6323 — Created Sept. 13, 2014 and submitted
Most people allow their svn credentials to be cached as part of the checkout,
but not everyone does. In this case, users need some way to be able to specify
them. This change adds --svn-username and --svn-password arguments (and
associated config file keys).
- Ran unit tests.
- Posted a change using these parameters.
| Description | From | Last Updated |
|---|---|---|
|
Col: 80 E501 line too long (84 > 79 characters) |
 reviewbot
|
|
|
Since _run_svn prepends 'svn' to the command, won't this run svn svn add ...? |
 brennie
|
|
|
Since _run_svn prepends 'svn' to the command, wouldn't this execute svn svn delete ...? |
brennie
|
|
|
Help text should have trailing periods for consistency. Also, the documentation for all the commands need to be updated to … |
 chipx86
|
-
-
rbtools/clients/svn.py (Diff revision 1) Since _run_svn prepends 'svn' to the command, won't this run
svn svn add ...? -
rbtools/clients/svn.py (Diff revision 1) Since
_run_svnprepends 'svn' to the command, wouldn't this executesvn svn delete ...?
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+44 -20) |
-
Tool: PEP8 Style Checker Processed Files: rbtools/clients/svn.py rbtools/commands/__init__.py Tool: Pyflakes Processed Files: rbtools/clients/svn.py rbtools/commands/__init__.py
-
-
rbtools/commands/__init__.py (Diff revision 2) Help text should have trailing periods for consistency.
Also, the documentation for all the commands need to be updated to include this.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+72 -20) |
-
Tool: Pyflakes Processed Files: rbtools/clients/svn.py rbtools/commands/__init__.py Ignored Files: docs/rbtools/rbt/commands/post.rst docs/rbtools/rbt/commands/diff.rst Tool: PEP8 Style Checker Processed Files: rbtools/clients/svn.py rbtools/commands/__init__.py Ignored Files: docs/rbtools/rbt/commands/post.rst docs/rbtools/rbt/commands/diff.rst
Tool: Pyflakes Processed Files: rbtools/clients/svn.py rbtools/commands/__init__.py Tool: PEP8 Style Checker Processed Files: rbtools/clients/svn.py rbtools/commands/__init__.py