Summary

Fix the signature generation for GitHub payloads.

Review Request #6321 — Created Sept. 12, 2014 and submitted Sept. 12, 2014, 10:47 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

55b4105...

Reviewers

Groups

reviewboard

People

Description

GitHub payload signatures are encoded in SHA1, but we were encoding in
MD5. This updates our signature code and tests to encode in SHA1.

Testing Done

Unit tests pass.

Deployed a build with this fix and re-sent the webhook. The review request
submitted successfully.

Expand All
Collapse All

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/github.py
    reviewboard/hostingsvcs/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/github.py
    reviewboard/hostingsvcs/tests.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (0be4404)