Summary

Add a field on Repository for storing a UUID for incoming webhooks.

Review Request #6310 — Created Sept. 10, 2014 and submitted Sept. 12, 2014, 3:25 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

5705247...

Reviewers

Groups

reviewboard

People

Description

This adds new Repository.hooks_uuid, which is used for matching and
validating incoming webhooks. How this is used is up to the hook
implementation, and can be part of the URL, part of HMAC validation,
or whatever else makes sense.

This field is not exposed in the API. It will instead be used by the
various HostingServices in whichever way makes the most sense for their
implementation, and exposed to the user through an upcoming change that
will allow them to provide hook instructions.

Testing Done

Made use of the field and functions in another change.

Issues

Description	From	Last Updated
redefinition of unused 'six' from line 13	reviewbot	Sept. 10, 2014, 3:28 p.m.
Why isn't this using the uuid module?	david	Sept. 11, 2014, 2:07 a.m.

Tool: Pyflakes
Processed Files:
    reviewboard/scmtools/evolutions/__init__.py
    reviewboard/scmtools/models.py
    reviewboard/scmtools/evolutions/repository_hooks_uuid.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/scmtools/evolutions/__init__.py
    reviewboard/scmtools/models.py
    reviewboard/scmtools/evolutions/repository_hooks_uuid.py

reviewboard/scmtools/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 redefinition of unused 'six' from line 13
```

Change Summary:

Removed a duplicate import.

Commit:

-	582e71c161ba1d4ed18de69e1c887418c7649d2f
+	76414cf9d4b73d584a0e8620623bd2e1c2fc1590

Diff:

Revision 2 (+61 -3)

Show changes

	reviewboard/scmtools/models.py
	reviewboard/scmtools/evolutions/__init__.py
	reviewboard/scmtools/evolutions/repository_hooks_uuid.py

Tool: Pyflakes
Processed Files:
    reviewboard/scmtools/evolutions/__init__.py
    reviewboard/scmtools/models.py
    reviewboard/scmtools/evolutions/repository_hooks_uuid.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/scmtools/evolutions/__init__.py
    reviewboard/scmtools/models.py
    reviewboard/scmtools/evolutions/repository_hooks_uuid.py

reviewboard/scmtools/models.py (Diff revision 2)

The issue has been resolved. Show all issues

Why isn't this using the uuid module?

chipx86 Sept. 11, 2014, 2:03 a.m.

I copy/pasted the bulk of this from the WebAPIToken generation code, which was based on other implementations I saw. Those were using the above trick and not using the UUID module. When I first looked into this, I saw this from RFC 4122:

Do not assume that UUIDs are hard to guess; they should not be used
as security capabilities (identifiers whose mere possession grants
access), for example. A predictable random number source will
exacerbate the situation.

I looked around tonight for opinions on this. The Openstack security team clarified this, saying that that section does not apply to UUID v4.

I'll go ahead and update this.

Change Summary:

Switch to using uuid.

Commit:

-	76414cf9d4b73d584a0e8620623bd2e1c2fc1590
+	2be7d47effe87d4f2d49b84b440bb7ee1e321cb7

Diff:

Revision 3 (+55 -3)

Show changes

	reviewboard/scmtools/models.py
	reviewboard/scmtools/evolutions/__init__.py
	reviewboard/scmtools/evolutions/repository_hooks_uuid.py

Tool: Pyflakes
Processed Files:
    reviewboard/scmtools/evolutions/__init__.py
    reviewboard/scmtools/models.py
    reviewboard/scmtools/evolutions/repository_hooks_uuid.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/scmtools/evolutions/__init__.py
    reviewboard/scmtools/models.py
    reviewboard/scmtools/evolutions/repository_hooks_uuid.py

Change Summary:

Made this field accessible via the repository form's Internal State section.

Commit:

-	2be7d47effe87d4f2d49b84b440bb7ee1e321cb7
+	570524743fb4320f6aad2e7ac32495df9826ab95

Diff:

Revision 4 (+58 -4)

Show changes

	reviewboard/scmtools/admin.py
	reviewboard/scmtools/models.py
	reviewboard/scmtools/evolutions/__init__.py
	reviewboard/scmtools/evolutions/repository_hooks_uuid.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/scmtools/admin.py
    reviewboard/scmtools/models.py
    reviewboard/scmtools/evolutions/__init__.py
    reviewboard/scmtools/evolutions/repository_hooks_uuid.py



Tool: Pyflakes
Processed Files:
    reviewboard/scmtools/admin.py
    reviewboard/scmtools/models.py
    reviewboard/scmtools/evolutions/__init__.py
    reviewboard/scmtools/evolutions/repository_hooks_uuid.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (b6e332d)