Offer helpful RBTools setup instructions in the repository list.
Review Request #6306 — Created Sept. 9, 2014 and submitted
This updates the repository list to have helpful action links for
getting RBTools configured against that repository. When the admin
clicks "RBTools Setup", it will pop up a modal dialog box showing the
setup instructions for that given repository.To make room for the new column, I've also shortened the label for the
"Show this repository" column in the repository list. Upcoming changes
will add new actions to this list.
Tested this link with several different repositories, and saw the expected
text.
| Description | From | Last Updated |
|---|---|---|
|
Can you localize "RBTools Setup" here? |
 david
|
|
|
Should this be localized? |
david
|
|
|
'HttpResponseNotFound' imported but unused |
 reviewbot
|
|
|
'HttpResponse' imported but unused |
reviewbot
|
|
|
'HttpResponseNotFound' imported but unused |
reviewbot
|
|
|
'HttpResponse' imported but unused |
reviewbot
|
Change Summary:
- Fixed localization.
- Made use of the new
get_server_url(). As part of this, we properly show links to repositories on Local Sites. - Added brackets around the action link names. This helps differentiate when there are multiple links (which will happen in a coming change).
- Removed the underscore before the new URLs. While they are meant for internal usage, they display file alone (though without any page container or styling), and this allows users to right-click the links and copy them for later.
Depends On: |
|
||||
|---|---|---|---|---|---|
Commit: |
|
||||
Diff: |
Revision 2 (+122 -1) |
-
Tool: PEP8 Style Checker Processed Files: reviewboard/scmtools/admin.py Ignored Files: reviewboard/templates/admin/scmtools/repository/rbtools_setup.html reviewboard/static/rb/css/admin.less reviewboard/templates/admin/scmtools/repository/change_list.html Tool: Pyflakes Processed Files: reviewboard/scmtools/admin.py Ignored Files: reviewboard/templates/admin/scmtools/repository/rbtools_setup.html reviewboard/static/rb/css/admin.less reviewboard/templates/admin/scmtools/repository/change_list.html -
-
Change Summary:
Fixed Review Bot warnings.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+122 -1) |
-
Tool: PEP8 Style Checker Processed Files: reviewboard/scmtools/admin.py Ignored Files: reviewboard/templates/admin/scmtools/repository/rbtools_setup.html reviewboard/static/rb/css/admin.less reviewboard/templates/admin/scmtools/repository/change_list.html Tool: Pyflakes Processed Files: reviewboard/scmtools/admin.py Ignored Files: reviewboard/templates/admin/scmtools/repository/rbtools_setup.html reviewboard/static/rb/css/admin.less reviewboard/templates/admin/scmtools/repository/change_list.html -
-
Change Summary:
Actually fix Review Bot warnings this time. (Changes weren't in the index.)
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+121 -1) |
-
Tool: Pyflakes Processed Files: reviewboard/scmtools/admin.py Ignored Files: reviewboard/templates/admin/scmtools/repository/rbtools_setup.html reviewboard/static/rb/css/admin.less reviewboard/templates/admin/scmtools/repository/change_list.html Tool: PEP8 Style Checker Processed Files: reviewboard/scmtools/admin.py Ignored Files: reviewboard/templates/admin/scmtools/repository/rbtools_setup.html reviewboard/static/rb/css/admin.less reviewboard/templates/admin/scmtools/repository/change_list.html
Tool: PEP8 Style Checker Processed Files: reviewboard/scmtools/admin.py Ignored Files: reviewboard/templates/admin/scmtools/repository/rbtools_setup.html reviewboard/static/rb/css/admin.less reviewboard/templates/admin/scmtools/repository/change_list.html Tool: Pyflakes Processed Files: reviewboard/scmtools/admin.py Ignored Files: reviewboard/templates/admin/scmtools/repository/rbtools_setup.html reviewboard/static/rb/css/admin.less reviewboard/templates/admin/scmtools/repository/change_list.html