Summary

Allow local_site_reverse to take an actual LocalSite.

Review Request #6302 — Created Sept. 8, 2014 and submitted Sept. 9, 2014, 12:08 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

7edac8a...

Reviewers

Groups

reviewboard

People

Description

local_site_reverse was able to take a LocalSite's name, or a request
object, but if you actually had a LocalSite (or None), you'd have to
write your own conditional to extract the name and pass it.

Now, local_site_reverse can take a LocalSite. This saves a database
query, if one is already available, and simplifies calling code.

Testing Done

Unit tests pass.

Used this with another change I'm about to put up.

Expand All
Collapse All

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/site/urlresolvers.py



Tool: Pyflakes
Processed Files:
    reviewboard/site/urlresolvers.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (46a5686)