Fix $.fn.retinaGravatar to not stomp all over parameters.

Review Request #6301 — Created Sept. 5, 2014 and submitted

Information

Djblets
release-0.8.x
ebd20f9...

Reviewers

The implementation of URL parsing for retina gravatars was incredibly clumsy if
the user was using any of the extra parameters which are available in settings.
For example, if the user had set GRAVATAR_DEFAULT to something fun, retina
users wouldn't see it because it wouldn't preserve the d= param.

This change makes the parameter parsing much more capable, fixing the size
parameter without touching any of the others.

Set GRAVATAR_DEFAULT to 'wavatar' in my settings_local.py file and saw actual
wavatars instead of the ugly Gs.

reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        djblets/static/djblets/js/jquery.gravy.retina.js
    
    
    
    Tool: Pyflakes
    Ignored Files:
        djblets/static/djblets/js/jquery.gravy.retina.js
    
    
  2. 
      
chipx86
  1. Ship It!

  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.8.x (b5c6645)
LI
  1. asdfasdfasfd

    1. This is not a test server. Use http://demo.reviewboard.org for that.

  2. 
      
Loading...