Fix bomb when showing differences between two diff versions

Review Request #6297 — Created Sept. 4, 2014 and submitted

Information

Review Board
master
5d6b6c9...

Reviewers

Fix crash when trying to show the differerence between two versions of a patch (e.g. with a URL like r/31/diff/2-3/). RawFileDiffData was passing self.binary to tool.get_parser(), which fails because
the buffer object has no splitlines() method. Fixed by passing self.content instead.

Ad-hoc testing - I now see a diff rather than a stack trace.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/diffviewer/models.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/diffviewer/models.py
    
    
  2. 
      
david
  1. Ship It!

  2. 
      
MA
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (46f1408)
Loading...