• 
      

    [rbslack] Fix a crash when review requests are closed/reopend by hooks.

    Review Request #6296 — Created Sept. 4, 2014 and submitted

    Information

    rb-extension-pack
    fab90da...

    Reviewers

    When closing a review request through a post-commit hook, or any other
    means where a user isn't provided, rbslack would crash. Same with
    reopening without a provided user. Now, if the user is None, it will
    default to the owner of the review request.

    The other signals all have a valid user passed in, so they don't need
    this sort of check.

    Forced the user to None when calling the signals for closing and reopening.
    Saw it default to the user.

    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          rbslack/rbslack/extension.py
      
      
      
      Tool: Pyflakes
      Processed Files:
          rbslack/rbslack/extension.py
      
      
    2. 
        
    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (1ceaf66)