Fix showing Markdown field changes with 'None' values.

Review Request #6290 — Created Sept. 3, 2014 and submitted

Information

Review Board
release-2.0.x
390802f...

Reviewers

When rendering a Markdown field in a change description box, we weren't
ensuring that the old or new values were strings. They could be None,
which is a valid value indicating there was no content before. This
would end up breaking render_markdown().

We now convert to an empty string if it's None.

Caused the breakage, using the Note to Reviewers extension. Saw that it was
fixed after this change.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/fields.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/fields.py
    
    
  2. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (877aadb)
Loading...