• 
      

    Don't use <br/> tags for newlines in Markdown text in e-mails.

    Review Request #6286 — Created Sept. 3, 2014 and submitted

    Information

    Review Board
    release-2.0.x
    5cd7ba9...

    Reviewers

    We had the "nl2br" filter applied for Markdwon text, which caused every
    newline to have a <br/>. However, these appeared inside a <pre/>, and we
    still had newlines. The end result was that we had a blank line for
    every line of text.

    I can't see any reason why we'd need this filter, so I've removed it.
    This results in proper-looking e-mails.

    Previewed some e-mails, which looked correct instead of having blank lines
    everywhere.

    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/notifications/templatetags/markdown_email.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/notifications/templatetags/markdown_email.py
      
      
    2. 
        
    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (10ba4c6)