Summary

Clean up a bunch of PEP-8/pyflakes problems.

Review Request #6284 — Created Sept. 2, 2014 and submitted Sept. 4, 2014, 12:15 a.m.

Information

Owner

david

Repository

Djblets

Branch

master

Bugs

Depends On

Commit

7dad422...

Reviewers

Groups

djblets

People

Description

This change fixes up a bunch of relatively straightforward errors. Most of
these have to do with particulars of whitespace and indentation.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Blank line between these.	chipx86	Sept. 2, 2014, 2:11 p.m.
""" on the next line.	chipx86	Sept. 2, 2014, 2:11 p.m.
Same here.	chipx86	Sept. 2, 2014, 2:12 p.m.
Same here.	chipx86	Sept. 2, 2014, 2:12 p.m.
Same here.	chipx86	Sept. 2, 2014, 2:12 p.m.
Same here.	chipx86	Sept. 2, 2014, 2:12 p.m.
Blank line between these.	chipx86	Sept. 2, 2014, 2:12 p.m.
Blank line between these.	chipx86	Sept. 2, 2014, 2:12 p.m.
Blank line between these.	chipx86	Sept. 2, 2014, 2:12 p.m.
Col: 23 E241 multiple spaces after ':'	reviewbot	Sept. 2, 2014, 2:06 p.m.
Col: 30 E241 multiple spaces after ':'	reviewbot	Sept. 2, 2014, 2:06 p.m.
Col: 22 E241 multiple spaces after ':'	reviewbot	Sept. 2, 2014, 2:06 p.m.
Col: 26 E241 multiple spaces after ':'	reviewbot	Sept. 2, 2014, 2:07 p.m.
Col: 23 E241 multiple spaces after ':'	reviewbot	Sept. 2, 2014, 2:07 p.m.
Col: 21 E241 multiple spaces after ':'	reviewbot	Sept. 2, 2014, 2:07 p.m.
Blank line between these.	chipx86	Sept. 2, 2014, 2:13 p.m.
Blank line between these.	chipx86	Sept. 2, 2014, 2:13 p.m.
""" on the next line.	chipx86	Sept. 2, 2014, 2:13 p.m.
Same here.	chipx86	Sept. 2, 2014, 2:13 p.m.
Same here.	chipx86	Sept. 2, 2014, 2:13 p.m.
Same here.	chipx86	Sept. 2, 2014, 2:13 p.m.
Col: 23 E225 missing whitespace around operator	reviewbot	Sept. 2, 2014, 2:07 p.m.
'contextlib' imported but unused	reviewbot	Sept. 2, 2014, 2:07 p.m.
Col: 23 E241 multiple spaces after ':'	reviewbot	Sept. 2, 2014, 2:21 p.m.
Col: 30 E241 multiple spaces after ':'	reviewbot	Sept. 2, 2014, 2:21 p.m.
Col: 22 E241 multiple spaces after ':'	reviewbot	Sept. 2, 2014, 2:21 p.m.
Col: 26 E241 multiple spaces after ':'	reviewbot	Sept. 2, 2014, 2:21 p.m.
Col: 23 E241 multiple spaces after ':'	reviewbot	Sept. 2, 2014, 2:21 p.m.
Col: 21 E241 multiple spaces after ':'	reviewbot	Sept. 2, 2014, 2:21 p.m.
'contextlib' imported but unused	reviewbot	Sept. 2, 2014, 2:21 p.m.

Tool: Pyflakes
Processed Files:
    djblets/datagrid/grids.py
    djblets/extensions/urls.py
    djblets/extensions/packaging.py
    djblets/util/templatetags/djblets_images.py
    djblets/webapi/decorators.py
    djblets/util/templatetags/djblets_utils.py
    djblets/extensions/tests.py
    djblets/util/templatetags/djblets_email.py
    djblets/log/urls.py
    djblets/extensions/resources.py
    djblets/feedview/test_urls.py
    djblets/webapi/errors.py
    djblets/urls/decorators.py
    djblets/extensions/hooks.py
    djblets/siteconfig/django_settings.py
    djblets/util/tests.py
    djblets/testing/urls.py
    djblets/log/middleware.py
    djblets/auth/forms.py
    djblets/extensions/test/urls.py
    djblets/settings.py
    djblets/feedview/views.py
    djblets/util/decorators.py
    djblets/urls/root.py
    djblets/extensions/manager.py
    djblets/testing/testcases.py
    djblets/cache/backend.py
    djblets/log/views.py
    djblets/datagrid/tests.py
    djblets/util/http.py
    djblets/auth/util.py
    djblets/webapi/resources.py
    tests/runtests.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/datagrid/grids.py
    djblets/extensions/urls.py
    djblets/extensions/packaging.py
    djblets/util/templatetags/djblets_images.py
    djblets/webapi/decorators.py
    djblets/util/templatetags/djblets_utils.py
    djblets/extensions/tests.py
    djblets/util/templatetags/djblets_email.py
    djblets/log/urls.py
    djblets/extensions/resources.py
    djblets/feedview/test_urls.py
    djblets/webapi/errors.py
    djblets/urls/decorators.py
    djblets/extensions/hooks.py
    djblets/siteconfig/django_settings.py
    djblets/util/tests.py
    djblets/testing/urls.py
    djblets/log/middleware.py
    djblets/auth/forms.py
    djblets/extensions/test/urls.py
    djblets/settings.py
    djblets/feedview/views.py
    djblets/util/decorators.py
    djblets/urls/root.py
    djblets/extensions/manager.py
    djblets/testing/testcases.py
    djblets/cache/backend.py
    djblets/log/views.py
    djblets/datagrid/tests.py
    djblets/util/http.py
    djblets/auth/util.py
    djblets/webapi/resources.py
    tests/runtests.py

djblets/siteconfig/django_settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 23
 E241 multiple spaces after ':'
```
djblets/siteconfig/django_settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 30
 E241 multiple spaces after ':'
```
djblets/siteconfig/django_settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 22
 E241 multiple spaces after ':'
```
djblets/siteconfig/django_settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 26
 E241 multiple spaces after ':'
```
djblets/siteconfig/django_settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 23
 E241 multiple spaces after ':'
```
djblets/siteconfig/django_settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 21
 E241 multiple spaces after ':'
```
djblets/webapi/errors.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 23
 E225 missing whitespace around operator
```
tests/runtests.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'contextlib' imported but unused
```

djblets/extensions/test/urls.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between these.
```
djblets/extensions/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
""" on the next line.
```
djblets/extensions/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Same here.
```
djblets/extensions/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Same here.
```
djblets/extensions/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Same here.
```
djblets/extensions/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Same here.
```
djblets/extensions/urls.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between these.
```
djblets/feedview/test_urls.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between these.
```
djblets/log/urls.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between these.
```
djblets/testing/urls.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between these.
```
djblets/urls/root.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between these.
```
djblets/util/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
""" on the next line.
```
djblets/util/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Same here.
```
djblets/util/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Same here.
```
djblets/util/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Same here.
```

Commit:

-	c2d2735157edd1fe5c157999ef129adbda963056
+	7dad422bb921b398182bceb5e893f9fb674da1b3

Diff:

Revision 2 (+256 -188)

Show changes

	djblets/settings.py
	djblets/auth/forms.py
	djblets/auth/util.py
	djblets/cache/backend.py
	djblets/datagrid/grids.py
	djblets/datagrid/tests.py
	djblets/extensions/hooks.py
	djblets/extensions/manager.py
	25 more

Tool: Pyflakes
Processed Files:
    djblets/datagrid/grids.py
    djblets/extensions/urls.py
    djblets/extensions/packaging.py
    djblets/util/templatetags/djblets_images.py
    djblets/webapi/decorators.py
    djblets/util/templatetags/djblets_utils.py
    djblets/extensions/tests.py
    djblets/util/templatetags/djblets_email.py
    djblets/log/urls.py
    djblets/extensions/resources.py
    djblets/feedview/test_urls.py
    djblets/webapi/errors.py
    djblets/urls/decorators.py
    djblets/extensions/hooks.py
    djblets/siteconfig/django_settings.py
    djblets/util/tests.py
    djblets/testing/urls.py
    djblets/log/middleware.py
    djblets/auth/forms.py
    djblets/extensions/test/urls.py
    djblets/settings.py
    djblets/feedview/views.py
    djblets/util/decorators.py
    djblets/urls/root.py
    djblets/extensions/manager.py
    djblets/testing/testcases.py
    djblets/cache/backend.py
    djblets/log/views.py
    djblets/datagrid/tests.py
    djblets/util/http.py
    djblets/auth/util.py
    djblets/webapi/resources.py
    tests/runtests.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/datagrid/grids.py
    djblets/extensions/urls.py
    djblets/extensions/packaging.py
    djblets/util/templatetags/djblets_images.py
    djblets/webapi/decorators.py
    djblets/util/templatetags/djblets_utils.py
    djblets/extensions/tests.py
    djblets/util/templatetags/djblets_email.py
    djblets/log/urls.py
    djblets/extensions/resources.py
    djblets/feedview/test_urls.py
    djblets/webapi/errors.py
    djblets/urls/decorators.py
    djblets/extensions/hooks.py
    djblets/siteconfig/django_settings.py
    djblets/util/tests.py
    djblets/testing/urls.py
    djblets/log/middleware.py
    djblets/auth/forms.py
    djblets/extensions/test/urls.py
    djblets/settings.py
    djblets/feedview/views.py
    djblets/util/decorators.py
    djblets/urls/root.py
    djblets/extensions/manager.py
    djblets/testing/testcases.py
    djblets/cache/backend.py
    djblets/log/views.py
    djblets/datagrid/tests.py
    djblets/util/http.py
    djblets/auth/util.py
    djblets/webapi/resources.py
    tests/runtests.py

djblets/siteconfig/django_settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 23
 E241 multiple spaces after ':'
```
djblets/siteconfig/django_settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 30
 E241 multiple spaces after ':'
```
djblets/siteconfig/django_settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 22
 E241 multiple spaces after ':'
```
djblets/siteconfig/django_settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 26
 E241 multiple spaces after ':'
```
djblets/siteconfig/django_settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 23
 E241 multiple spaces after ':'
```
djblets/siteconfig/django_settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 21
 E241 multiple spaces after ':'
```
tests/runtests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'contextlib' imported but unused
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.8.x (71d6a86)

djblets/webapi/errors.py (Diff revision 1)

tests/runtests.py (Diff revision 1)

djblets/extensions/tests.py (Diff revision 1)

djblets/extensions/tests.py (Diff revision 1)