Check for repo+commit when associating review requests with commits.

Review Request #6282 — Created Aug. 28, 2014 and submitted

Information

Review Board
release-2.0.x
423a930...

Reviewers

The post-commit UI had a bug where it would link revisions to review requests
even if the repository didn't match. This wasn't initially found in my testing
since almost all of my testing was with Git (where revisions are SHA-1 hashes),
but does present a problem if there are multiple Subversion repositories (where
revisions are just integers).

Ran unit tests.

reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/webapi/resources/repository_commits.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/webapi/resources/repository_commits.py
    
    
  2. 
      
chipx86
  1. Ship It!

  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (44decb6)
Loading...