Summary:

Add the option to use OpenStack Swift for file storage.

Review Request #6247 — Created Aug. 19, 2014 and submitted Aug. 21, 2014, 4:22 p.m.

Information
Owner:	omarali
Repository:	Review Board
Branch:	master
Bugs:
Depends On:
Commit:	6ee04d0...
Reviewers
Groups:	reviewboard
People:

Description

Add the option to use OpenStack Swift for file storage. Swift is a private-cloud alternative to S3.

Testing Done

Manual testing on local running server.
Ran tests.

Issues

Description	From	Last Updated
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Aug. 19, 2014, 8:28 p.m.
Col: 80 E501 line too long (84 > 79 characters)	reviewbot	Aug. 19, 2014, 8:28 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Aug. 19, 2014, 8:28 p.m.
Col: 13 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:28 p.m.
Col: 22 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:29 p.m.
Col: 22 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:29 p.m.
Col: 17 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:29 p.m.
Col: 26 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:29 p.m.
Col: 28 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:29 p.m.
Col: 22 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:29 p.m.
Col: 22 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:29 p.m.
Col: 17 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:29 p.m.
Col: 26 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:29 p.m.
Col: 28 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:29 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Aug. 19, 2014, 8:34 p.m.
Col: 13 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:34 p.m.
Col: 22 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:34 p.m.
Col: 22 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:34 p.m.
Col: 17 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:34 p.m.
Col: 26 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:34 p.m.
Col: 28 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:34 p.m.
Col: 22 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:34 p.m.
Col: 22 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:34 p.m.
Col: 17 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:34 p.m.
Col: 26 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:34 p.m.
Col: 28 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:34 p.m.
Col: 13 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:37 p.m.
Col: 22 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:37 p.m.
Col: 22 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:38 p.m.
Col: 17 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:38 p.m.
Col: 26 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:38 p.m.
Col: 28 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:38 p.m.
Col: 22 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:38 p.m.
Col: 22 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:38 p.m.
Col: 17 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:38 p.m.
Col: 26 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:38 p.m.
Col: 28 E241 multiple spaces after ':'	reviewbot	Aug. 19, 2014, 8:38 p.m.
Col: 13 E241 multiple spaces after ':'	reviewbot	Aug. 20, 2014, 12:31 a.m.
Col: 22 E241 multiple spaces after ':'	reviewbot	Aug. 20, 2014, 12:31 a.m.
Col: 22 E241 multiple spaces after ':'	reviewbot	Aug. 20, 2014, 12:31 a.m.
Col: 17 E241 multiple spaces after ':'	reviewbot	Aug. 20, 2014, 12:31 a.m.
Col: 26 E241 multiple spaces after ':'	reviewbot	Aug. 20, 2014, 12:31 a.m.
Col: 28 E241 multiple spaces after ':'	reviewbot	Aug. 20, 2014, 12:31 a.m.
Col: 22 E241 multiple spaces after ':'	reviewbot	Aug. 20, 2014, 12:31 a.m.
Col: 22 E241 multiple spaces after ':'	reviewbot	Aug. 20, 2014, 12:31 a.m.
Col: 17 E241 multiple spaces after ':'	reviewbot	Aug. 20, 2014, 12:31 a.m.
Col: 26 E241 multiple spaces after ':'	reviewbot	Aug. 20, 2014, 12:31 a.m.
Col: 28 E241 multiple spaces after ':'	reviewbot	Aug. 20, 2014, 12:31 a.m.

Tool: Pyflakes
Processed Files:
    reviewboard/admin/checks.py
    reviewboard/admin/forms.py
    reviewboard/admin/siteconfig.py

Ignored Files:
    docs/manual/admin/installation/linux.rst
    docs/manual/admin/configuration/file-storage-settings.rst



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/admin/checks.py
    reviewboard/admin/forms.py
    reviewboard/admin/siteconfig.py

Ignored Files:
    docs/manual/admin/installation/linux.rst
    docs/manual/admin/configuration/file-storage-settings.rst

reviewboard/admin/checks.py (Diff revision 1)
Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```

reviewboard/admin/forms.py (Diff revision 1)

Show all issues

Col: 80
 E501 line too long (84 > 79 characters)

reviewboard/admin/forms.py (Diff revision 1)

Show all issues

Col: 80
 E501 line too long (107 > 79 characters)

reviewboard/admin/siteconfig.py (Diff revision 1)
Show all issues
```
Col: 13
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 1)
Show all issues
```
Col: 22
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 1)
Show all issues
```
Col: 22
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 1)
Show all issues
```
Col: 17
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 1)
Show all issues
```
Col: 26
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 1)
Show all issues
```
Col: 28
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 1)
Show all issues
```
Col: 22
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 1)
Show all issues
```
Col: 22
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 1)
Show all issues
```
Col: 17
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 1)
Show all issues
```
Col: 26
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 1)
Show all issues
```
Col: 28
 E241 multiple spaces after ':'
```

Change Summary:

Fixed lines' length.

Commit:

-	dadb1f3b92e8d7291d479e5c0a5f2bcbc2f65ca2
+	abb54b85b074f70adc39e23e2573b2b782758ee3

Diff:

Revision 2 (+136)

Show changes

	docs/manual/admin/configuration/file-storage-settings.rst
	docs/manual/admin/installation/linux.rst
	reviewboard/admin/checks.py
	reviewboard/admin/forms.py
	reviewboard/admin/siteconfig.py

Tool: Pyflakes
Processed Files:
    reviewboard/admin/checks.py
    reviewboard/admin/forms.py
    reviewboard/admin/siteconfig.py

Ignored Files:
    docs/manual/admin/installation/linux.rst
    docs/manual/admin/configuration/file-storage-settings.rst



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/admin/checks.py
    reviewboard/admin/forms.py
    reviewboard/admin/siteconfig.py

Ignored Files:
    docs/manual/admin/installation/linux.rst
    docs/manual/admin/configuration/file-storage-settings.rst

reviewboard/admin/checks.py (Diff revision 2)
Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
reviewboard/admin/siteconfig.py (Diff revision 2)
Show all issues
```
Col: 13
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 2)
Show all issues
```
Col: 22
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 2)
Show all issues
```
Col: 22
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 2)
Show all issues
```
Col: 17
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 2)
Show all issues
```
Col: 26
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 2)
Show all issues
```
Col: 28
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 2)
Show all issues
```
Col: 22
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 2)
Show all issues
```
Col: 22
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 2)
Show all issues
```
Col: 17
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 2)
Show all issues
```
Col: 26
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 2)
Show all issues
```
Col: 28
 E241 multiple spaces after ':'
```

Commit:

-	abb54b85b074f70adc39e23e2573b2b782758ee3
+	de246d2ab6d324c45ef9e701bbda8b013b07cac1

Diff:

Revision 3 (+137)

Show changes

	docs/manual/admin/configuration/file-storage-settings.rst
	docs/manual/admin/installation/linux.rst
	reviewboard/admin/checks.py
	reviewboard/admin/forms.py
	reviewboard/admin/siteconfig.py

Tool: Pyflakes
Processed Files:
    reviewboard/admin/checks.py
    reviewboard/admin/forms.py
    reviewboard/admin/siteconfig.py

Ignored Files:
    docs/manual/admin/installation/linux.rst
    docs/manual/admin/configuration/file-storage-settings.rst



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/admin/checks.py
    reviewboard/admin/forms.py
    reviewboard/admin/siteconfig.py

Ignored Files:
    docs/manual/admin/installation/linux.rst
    docs/manual/admin/configuration/file-storage-settings.rst

reviewboard/admin/siteconfig.py (Diff revision 3)
Show all issues
```
Col: 13
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 3)
Show all issues
```
Col: 22
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 3)
Show all issues
```
Col: 22
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 3)
Show all issues
```
Col: 17
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 3)
Show all issues
```
Col: 26
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 3)
Show all issues
```
Col: 28
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 3)
Show all issues
```
Col: 22
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 3)
Show all issues
```
Col: 22
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 3)
Show all issues
```
Col: 17
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 3)
Show all issues
```
Col: 26
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 3)
Show all issues
```
Col: 28
 E241 multiple spaces after ':'
```

Change Summary:

Fixed typo.

Commit:

-	de246d2ab6d324c45ef9e701bbda8b013b07cac1
+	6ee04d0aa439fab306ee7d8354aa8c86fdf83a80

Diff:

Revision 4 (+137)

Show changes

	docs/manual/admin/configuration/file-storage-settings.rst
	docs/manual/admin/installation/linux.rst
	reviewboard/admin/checks.py
	reviewboard/admin/forms.py
	reviewboard/admin/siteconfig.py

Tool: Pyflakes
Processed Files:
    reviewboard/admin/checks.py
    reviewboard/admin/forms.py
    reviewboard/admin/siteconfig.py

Ignored Files:
    docs/manual/admin/installation/linux.rst
    docs/manual/admin/configuration/file-storage-settings.rst



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/admin/checks.py
    reviewboard/admin/forms.py
    reviewboard/admin/siteconfig.py

Ignored Files:
    docs/manual/admin/installation/linux.rst
    docs/manual/admin/configuration/file-storage-settings.rst

reviewboard/admin/siteconfig.py (Diff revision 4)
Show all issues
```
Col: 13
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 4)
Show all issues
```
Col: 22
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 4)
Show all issues
```
Col: 22
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 4)
Show all issues
```
Col: 17
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 4)
Show all issues
```
Col: 26
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 4)
Show all issues
```
Col: 28
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 4)
Show all issues
```
Col: 22
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 4)
Show all issues
```
Col: 22
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 4)
Show all issues
```
Col: 17
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 4)
Show all issues
```
Col: 26
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 4)
Show all issues
```
Col: 28
 E241 multiple spaces after ':'
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (2088a18)