• 
  
    
 
    
 
    

    



    
    
    
    
     
    




    
 
    

  
    



    
 

 

  

  

 

    


  
    





    
 
    



  

    
 
 
    
  
    Add a configuration option to the JSHint tool plugin.
    
 
    

    



 
    
 
    

  Review Request #6241
  —
  Created Aug. 18, 2014 and submitted 

 
    


    




    




    




 
    
  
    
   Information

  
    



    
 
 
    
  anselina
 
    

    





    
 
 
    
  ReviewBot
 
    

    





    
 
 
    
  release-0.2.x
 
    

    





    
 
 
    
  
 
    

    





    
 
 
    
  6240
 
    

    





    
 
 
    
  a28a8ff...
 
    

    



 
    



 
    
  
    
   Reviewers

  
    



    
 
 
    
  reviewbot
 
    

    





    
 
 
    
  
 
    

    



 
    



    


    
 
    




  

    
 
 
    
  
    This adds a config option to the JSHint plugin, allowing admins to specify
    
which JSHint options should be turned on or off. The contents of a .jshintrc
    
file can simply be copied into this field.
    

    I also fixed a small bug in make_tempfile() (the default value of None for
    
extension would cause an error since mkstemp()'s suffix must be a string).
    
 
    

    





  

    
 
 
    
  
    Without any config specified, I published a review request, saw the worker run
    
jshint without the --config flag. The published review did not include issues
    
on unused variables.
    

    Using the same config as reviewboard/static/rb/js/.jshintrc, I published a
    
review request, and saw the worker run jshint with the --config flag this time.
    
The published review included issues on unused variables.
    
 
    

    




 
    

    





    
 
    









 
    
  
  
    

   
    
    
    
     
    
     
    
     
    
    
    
   
    

   
    
    
    
     
    
     
    
     
    
    
    
   
    

   
    
    
    
     
    
     
    
     
    
    
    
   
    

   
    
  
    
 
    









 
    

    



  
    
 
    

    


    


 













    
 





 
    
  
    
   
    



reviewbot




   
    
   
    



    
  
    
 
    


 
    
  
    

   
    
   
    
    
     
reviewbot


    
    
   
    

  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      Tool: PEP8 Style Checker
Processed Files:
    bot/reviewbot/tools/jshint.py
    bot/reviewbot/processing/filesystem.py



Tool: Pyflakes
Processed Files:
    bot/reviewbot/tools/jshint.py
    bot/reviewbot/processing/filesystem.py


      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 















    2. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 


    

  
    
 
    

    












    
 





 
    
  
    
   
    



david




   
    
   
    





    
  
    
 
    


 
    
  
    

   
    
   
    
    
     
david


    
    
   
    

  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      Ship It!
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 















    2. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 


    

  
    
 
    

    












    
 



 
    
  
    
   
    



anselina




   
    
   
    
  
    
 
    


 

    












    
 





 
    
  
    
   
    



reviewbot




   
    
   
    



    
  
    
 
    


 
    
  
    

   
    
   
    
    
     
reviewbot


    
    
   
    

  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      Tool: PEP8 Style Checker
Processed Files:
    bot/reviewbot/tools/jshint.py
    bot/reviewbot/processing/filesystem.py



Tool: Pyflakes
Processed Files:
    bot/reviewbot/tools/jshint.py
    bot/reviewbot/processing/filesystem.py


      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 















    2. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 


    

  
    
 
    

    












    
 





 
    
  
    
   
    




 SM





   
    
   
    





    
  
    
 
    


 
    
  
    

   
    
   
    
    
     
smacleod


    
    
   
    

  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      Looks good to me. Land this when r/6420 is ready to go too.
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 

















    2. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       bot/reviewbot/processing/filesystem.py
       


        (Diff revision 2)


       
      
     
      
          
    
     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    





    
      Was this broken for the cases when extension wasn't provided?
      
  
      
 
      

 
      
  


      
 
      
 
        

  


      1. 
 
 
        
 
        
  
 
        
 
        
  
        Yup, exactly! None was a bad default value for extension, since mkstemp()'s suffix must be a string.
        
 
        

        2. 


 
      


      

 
      

      3. 




    3. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      4. 


    

  
    
 
    

    












    
 



 
    
  
    
   
    



anselina




   
    
   
    
  
    
 
    


 
    
  
    

   
    
   
    
    
     Review request changed
    
    
   
    

  
    
  
    
  
    




    

  
    
   
    
    Status:
   
    
   
    

    Completed

   
    
  
    



  
    
   
    
    Change Summary:
   
    
   
    
    
    Pushed to release-0.2.x (9be378a)