• 
      

    Backport FileDiff migration and condensediffs to 1.7.x.

    Review Request #6229 — Created Aug. 14, 2014 and submitted

    Information

    Review Board
    release-1.7.x
    8f7caca...

    Reviewers

    While Review Board 1.7.x introduced FileDiffData for new diffs, it never
    gained the migration support. This was added for 2.0, by way of
    on-access migration in FileDiff and the condensediffs management
    command.

    Diff migration has been thoroughly tested at this point, and is known to
    work really well. It's also a beneficial thing to run before an upgrade
    to 2.0. This change backports everything needed to get modern
    (pre-RawFileDiffData) migration in 1.7.x.

    Tested on-access migration on some FileDiffs containing diff data through
    the shell. Saw that, prior to diff access, there was no associated FileDiffData,
    but afterwards there was.

    Tested that accessing diffs through the diff viewer worked and performed the migration.

    Ran condensediffs and saw the progress notification and that diffs were migrated.
    Verified the results.

    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/diffviewer/models.py
          reviewboard/diffviewer/management/commands/condensediffs.py
          reviewboard/diffviewer/managers.py
          reviewboard/diffviewer/tests.py
      
      Ignored Files:
          reviewboard/diffviewer/management/__init__.py
          reviewboard/diffviewer/management/commands/__init__.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/diffviewer/models.py
          reviewboard/diffviewer/management/commands/condensediffs.py
          reviewboard/diffviewer/managers.py
          reviewboard/diffviewer/tests.py
      
      Ignored Files:
          reviewboard/diffviewer/management/__init__.py
          reviewboard/diffviewer/management/commands/__init__.py
      
      
    2. 
        
    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-1.7.x (f7d35de)