Add form in admin site for AutomaticRunGroups.

Review Request #6221 — Created Aug. 12, 2014 and submitted

Information

ReviewBot
master
847a80b...

Reviewers

AutomaticRunGroups can now be created, modified, or deleted through the admin
site by specifying a name, file regex, profile(s), local site (optional), and
repository (optional). See the attached screenshots.

  • Tried adding AutomaticRunGroups with invalid fields (a missing required
    field (name, file regex, profile), an invalid file regex, and a local site
    that does not exist), and saw the appropriate errors on the form.
  • Added AutomaticRunGroups with valid fields, and saw them listed in the admin
    panel and in the database.
  • Displayed the list of AutomaticRunGroups.
  • Modified an AutomaticRunGroup and saved the changes.
  • Deleted AutomaticRunGroups, and saw them removed.

Description From Last Updated

blank line between these two

SM smacleod

"These tool profiles will be executed when the provided file regex and repositories match a review request"

SM smacleod

"Validates the provided regular expression"

SM smacleod
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        extension/reviewbotext/forms.py
        extension/reviewbotext/models.py
        extension/reviewbotext/admin.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        extension/reviewbotext/forms.py
        extension/reviewbotext/models.py
        extension/reviewbotext/admin.py
    
    
  2. 
      
anselina
anselina
SM
  1. 
      
  2. extension/reviewbotext/admin.py (Diff revision 1)
     
     
     

    blank line between these two

    1. Both of these are 3rd-party, from reviewbotext's perspective.

  3. extension/reviewbotext/admin.py (Diff revision 1)
     
     
     
     
     

    "These tool profiles will be executed when the provided file regex and repositories match a review request"

  4. extension/reviewbotext/forms.py (Diff revision 1)
     
     

    "Validates the provided regular expression"

  5. 
      
anselina
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        extension/reviewbotext/forms.py
        extension/reviewbotext/models.py
        extension/reviewbotext/admin.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        extension/reviewbotext/forms.py
        extension/reviewbotext/models.py
        extension/reviewbotext/admin.py
    
    
  2. 
      
david
  1. Ship It!

  2. 
      
anselina
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        extension/reviewbotext/forms.py
        extension/reviewbotext/models.py
        extension/reviewbotext/admin.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        extension/reviewbotext/forms.py
        extension/reviewbotext/models.py
        extension/reviewbotext/admin.py
    
    
  2. 
      
david
  1. Ship It!

  2. 
      
anselina
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (d59e0cd)
Loading...