Add form in admin site for AutomaticRunGroups.
Review Request #6221 — Created Aug. 12, 2014 and submitted
AutomaticRunGroups can now be created, modified, or deleted through the admin
site by specifying a name, file regex, profile(s), local site (optional), and
repository (optional). See the attached screenshots.
- Tried adding AutomaticRunGroups with invalid fields (a missing required
field (name, file regex, profile), an invalid file regex, and a local site
that does not exist), and saw the appropriate errors on the form. - Added AutomaticRunGroups with valid fields, and saw them listed in the admin
panel and in the database. - Displayed the list of AutomaticRunGroups.
- Modified an AutomaticRunGroup and saved the changes.
- Deleted AutomaticRunGroups, and saw them removed.
| Description | From | Last Updated |
|---|---|---|
|
blank line between these two |
SM smacleod | |
|
"These tool profiles will be executed when the provided file regex and repositories match a review request" |
SM smacleod | |
|
"Validates the provided regular expression" |
SM smacleod |
- Description:
-
~ AutomaticRunGroups can now be created or deleted through the admin
~ AutomaticRunGroups can now be created, modified, or deleted through the admin
site by specifying a name, file regex, profile(s), local site (optional), and repository (optional). See the attached screenshots. - - TODO:
- - Selecting a single AutomaticRunGroup to modify it in the admin panel raises a - FieldError. - Testing Done:
-
- Tried adding AutomaticRunGroups with invalid fields (a missing required
field (name, file regex, profile), an invalid file regex, and a local site
that does not exist), and saw the appropriate errors on the form.
- Added AutomaticRunGroups with valid fields, and saw them listed in the admin
panel and in the database.
- Displayed the list of AutomaticRunGroups.
~ - Deleted AutomaticRunGroups, and saw them removed.
~ - Modified an AutomaticRunGroup and saved the changes.
+ - Deleted AutomaticRunGroups, and saw them removed.
- Tried adding AutomaticRunGroups with invalid fields (a missing required
-
Tool: PEP8 Style Checker Processed Files: extension/reviewbotext/forms.py extension/reviewbotext/models.py extension/reviewbotext/admin.py Tool: Pyflakes Processed Files: extension/reviewbotext/forms.py extension/reviewbotext/models.py extension/reviewbotext/admin.py
- Change Summary:
-
Rebased on master.
- Commit:
-
cc5b533065df8d7d50d6da817df8c3b0a73b4a95847a80bb8034930fa238f664a24410fb2196bf44
Tool: Pyflakes Processed Files: extension/reviewbotext/forms.py extension/reviewbotext/models.py extension/reviewbotext/admin.py Tool: PEP8 Style Checker Processed Files: extension/reviewbotext/forms.py extension/reviewbotext/models.py extension/reviewbotext/admin.py