New resource for "owned" and review request independent file attachments

Review Request #6220 — Created Aug. 12, 2014 and discarded — Latest diff uploaded

Information

Review Board
master

Reviewers

New resource for user file attachments.

New file attachment resource was creating using the frontend backbone/RB.BaseResource model and post/put/get were tested manually.

  • Successfully created a file attachment user content is always empty upon creation as expected
  • Successfully posted caption and file data
  • Successfully modified and saved caption data
  • Tried to update file a second time and observed the expected behaviour (it failed)
  • Manually tested get_list by making a request to /api/file-attachments/, it returned a list of all file attachments owned by the user making the request as expected.
reviewboard/reviews/markdown_utils.py
reviewboard/reviews/tests.py
reviewboard/reviews/views.py
reviewboard/scmtools/hg.py
reviewboard/scmtools/svn/subvertpy.py
reviewboard/static/rb/css/ui/boxes.less
reviewboard/static/rb/js/configForms/models/tests/resourceListItemModelTests.js
reviewboard/static/rb/js/diffviewer/views/diffRevisionSelectorView.js
reviewboard/static/rb/js/resources/models/baseResourceModel.js
reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
reviewboard/webapi/resources/base_original_file.py
reviewboard/webapi/resources/base_patched_file.py
reviewboard/webapi/resources/diff.py
reviewboard/webapi/resources/file_attachment_user.py
reviewboard/webapi/resources/filediff.py
reviewboard/webapi/resources/review_request.py
reviewboard/webapi/resources/review_request_draft.py
reviewboard/webapi/tests/test_review_request.py
reviewboard/webapi/tests/test_review_request_draft.py
This diff has been split across 2 pages: < 1 2
Loading...