New resource for "owned" and review request independent file attachments
Review Request #6220 — Created Aug. 12, 2014 and discarded — Latest diff uploaded
New resource for user file attachments.
New file attachment resource was creating using the frontend backbone/RB.BaseResource model and post/put/get were tested manually.
- Successfully created a file attachment user content is always empty upon creation as expected
- Successfully posted caption and file data
- Successfully modified and saved caption data
- Tried to update file a second time and observed the expected behaviour (it failed)
- Manually tested get_list by making a request to /api/file-attachments/, it returned a list of all file attachments owned by the user making the request as expected.
Diff Revision 6
This is not the most recent revision of the diff. The latest diff is revision 11. See what's changed.
orig
1
2
3
4
5
6
7
8
9
10
11
| reviewboard/staticbundles.py |
|---|
| reviewboard/attachments/models.py |
|---|
| reviewboard/diffviewer/managers.py |
|---|
| reviewboard/diffviewer/management/commands/condensediffs.py |
|---|
| reviewboard/reviews/markdown_utils.py |
|---|
| reviewboard/reviews/tests.py |
|---|
| reviewboard/scmtools/svn/subvertpy.py |
|---|
| reviewboard/static/rb/css/ui/boxes.less |
|---|
| reviewboard/static/rb/js/configForms/models/tests/resourceListItemModelTests.js |
|---|
| reviewboard/static/rb/js/resources/models/apiTokenModel.js |
|---|
| reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js |
|---|
| reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js |
|---|
| reviewboard/webapi/resources/file_attachment_user.py |
|---|
| reviewboard/webapi/resources/review_request.py |
|---|
| reviewboard/webapi/resources/review_request_draft.py |
|---|
| reviewboard/webapi/resources/root.py |
|---|
| reviewboard/webapi/tests/test_review_request.py |
|---|
| reviewboard/webapi/tests/test_review_request_draft.py |
|---|