Summary

New resource for "owned" and review request independent file attachments

Review Request #6220 — Created Aug. 12, 2014 and discarded Oct. 30, 2014, 1:22 p.m.

Information

Owner

rvaiya

Repository

Review Board

Branch

master

Bugs

Depends On

~~6217~~

Reviewers

Groups

reviewboard, students

People

Description

New resource for user file attachments.

Testing Done

New file attachment resource was creating using the frontend backbone/RB.BaseResource model and post/put/get were tested manually.

Successfully created a file attachment user content is always empty upon creation as expected
Successfully posted caption and file data
Successfully modified and saved caption data
Tried to update file a second time and observed the expected behaviour (it failed)
Manually tested get_list by making a request to /api/file-attachments/, it returned a list of all file attachments owned by the user making the request as expected.

Issues

Description	From	Last Updated
'reviewboard' imported but unused	reviewbot	Aug. 23, 2014, 5:05 p.m.
Col: 13 E241 multiple spaces after ':'	reviewbot	Aug. 23, 2014, 5:05 p.m.
Col: 22 E241 multiple spaces after ':'	reviewbot	Aug. 23, 2014, 5:05 p.m.
Col: 22 E241 multiple spaces after ':'	reviewbot	Aug. 23, 2014, 5:05 p.m.
Col: 17 E241 multiple spaces after ':'	reviewbot	Aug. 23, 2014, 5:05 p.m.
Col: 26 E241 multiple spaces after ':'	reviewbot	Aug. 23, 2014, 5:05 p.m.
Col: 28 E241 multiple spaces after ':'	reviewbot	Aug. 23, 2014, 5:05 p.m.
Col: 22 E241 multiple spaces after ':'	reviewbot	Aug. 23, 2014, 5:04 p.m.
Col: 22 E241 multiple spaces after ':'	reviewbot	Aug. 23, 2014, 5:04 p.m.
Col: 17 E241 multiple spaces after ':'	reviewbot	Aug. 23, 2014, 5:04 p.m.
Col: 26 E241 multiple spaces after ':'	reviewbot	Aug. 23, 2014, 5:04 p.m.
Col: 28 E241 multiple spaces after ':'	reviewbot	Aug. 23, 2014, 5:04 p.m.
local variable 'positions_key' is assigned to but never used	reviewbot	Aug. 23, 2014, 5:04 p.m.
redefinition of unused 'FileDiffMigrationTests' from line 726	reviewbot	Aug. 23, 2014, 5:04 p.m.
list comprehension redefines 'file_attachment' from line 583	reviewbot	Aug. 23, 2014, 5:04 p.m.
We generally avoid the ternary form because it's annoying. How about rewriting this as: if self.orig_filename: return self.orig_filename elif self.file: …	david	Sept. 6, 2014, 6:24 p.m.
Why did you make this change?	david	Sept. 6, 2014, 6:24 p.m.
Trailing spaces in javascript can break IE.	david	Sept. 6, 2014, 6:24 p.m.
Remove this line.	david	Sept. 6, 2014, 6:24 p.m.
This should probably include everything if it's an admin making the request.	david	Aug. 28, 2014, 4:36 p.m.
Docstrings should generally follow the same format that you might use for a commit message -- the first line should …	david	Sept. 6, 2014, 6:31 p.m.
Same comments as the above docstring.	david	Sept. 6, 2014, 6:24 p.m.
What happens if you just let it assign None to the caption field?	david	Sept. 6, 2014, 6:24 p.m.
PERMISSION_DENIED doesn't seem quite right. How about creating a new error, FILE_ALREADY_EXISTS?	david	Sept. 6, 2014, 6:24 p.m.
'User' imported but unused	reviewbot	Sept. 6, 2014, 6:25 p.m.
'User' imported but unused	reviewbot	Sept. 6, 2014, 6:32 p.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/attachments/models.py
    reviewboard/attachments/forms.py
    reviewboard/webapi/resources/root.py



Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/attachments/models.py
    reviewboard/attachments/forms.py
    reviewboard/webapi/resources/root.py

Summary:: resource changes
[WIP] New reosource for "owned" and review request independent file attachments

Summary:: [WIP] New reosource for "owned" and review request independent file attachments
[WIP] New resource for "owned" and review request independent file attachments

Testing Done:: ~
get/create were by hand crafting POST/GET requests using wget, currently in the process of fixing update and get_list. This patch depends on the model changes made in /r/6217/.
~
get/create were tested by hand crafting POST/GET requests using wget. I am currently in the process of fixing update and get_list. This patch depends on the model changes made in /r/6217/.

Commit:

b8ce4548705fa678cf0521cabc3751ecb1060486

17c12451c86a5c67ebcb57e68c25b686c3fe2e22

Diff:

Revision 2 (+22)

Show changes

	reviewboard/urls.py
	reviewboard/attachments/views.py

Diff:

Revision 3 (+125 -2)

Show changes

	reviewboard/attachments/forms.py
	reviewboard/attachments/models.py
	reviewboard/webapi/resources/file_attachment_user.py
	reviewboard/webapi/resources/root.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/attachments/models.py
    reviewboard/attachments/forms.py
    reviewboard/webapi/resources/root.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/attachments/models.py
    reviewboard/attachments/forms.py
    reviewboard/webapi/resources/root.py

Commit:

b8ce4548705fa678cf0521cabc3751ecb1060486

0cd9e19b6f5cb67d33cc8013ff9fa1128911315c

Diff:

Revision 4 (+126 -2)

Show changes

	reviewboard/attachments/forms.py
	reviewboard/attachments/models.py
	reviewboard/webapi/resources/file_attachment_user.py
	reviewboard/webapi/resources/root.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/attachments/models.py
    reviewboard/attachments/forms.py
    reviewboard/webapi/resources/root.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/attachments/models.py
    reviewboard/attachments/forms.py
    reviewboard/webapi/resources/root.py

Commit:

0cd9e19b6f5cb67d33cc8013ff9fa1128911315c

ed78a75a621aecbfb62b062dc9fae91aa7cda508

Diff:

Revision 5 (+126 -2)

Show changes

	reviewboard/attachments/forms.py
	reviewboard/attachments/models.py
	reviewboard/webapi/resources/file_attachment_user.py
	reviewboard/webapi/resources/root.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/attachments/models.py
    reviewboard/attachments/forms.py
    reviewboard/webapi/resources/root.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/attachments/models.py
    reviewboard/attachments/forms.py
    reviewboard/webapi/resources/root.py

Description:

~		[WIP] Resource changes needed for front-end code
	~	New resource for user file attachments.

Testing Done:

~		get/create were tested by hand crafting POST/GET requests using wget. I am currently in the process of fixing update and get_list. This patch depends on the model changes made in /r/6217/.
	~	New file attachment resource was creating using the frontend backbone/RB.BaseResource model and post/put/get were tested manually.
	+
	+	Successfully created a file attachment user content is always empty upon creation as expected
	+	Successfully posted caption and file data
	+	Successfully modified and saved caption data
	+	Tried to update file a second time and observed the expected behaviour (it failed)
	+	Manually tested get_list by making a request to /api/file-attachments/, it returned a list of all file attachments owned by the user making the request as expected.

Commit:

ed78a75a621aecbfb62b062dc9fae91aa7cda508

65d52053fde9cd2fd7a4eb3dc7e25b0bc0073791

Diff:

Revision 6 (+407 -25)

Show changes

	reviewboard/staticbundles.py
	reviewboard/attachments/models.py
	reviewboard/diffviewer/managers.py
	reviewboard/diffviewer/management/commands/condensediffs.py
	reviewboard/reviews/markdown_utils.py
	reviewboard/reviews/tests.py
	reviewboard/scmtools/svn/subvertpy.py
	reviewboard/static/rb/css/ui/boxes.less
	10 more

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/root.py
    reviewboard/diffviewer/management/commands/condensediffs.py
    reviewboard/attachments/models.py
    reviewboard/diffviewer/managers.py
    reviewboard/reviews/markdown_utils.py
    reviewboard/reviews/tests.py
    reviewboard/webapi/resources/review_request.py
    reviewboard/webapi/tests/test_review_request.py
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/staticbundles.py
    reviewboard/webapi/resources/review_request_draft.py
    reviewboard/webapi/tests/test_review_request_draft.py
    reviewboard/scmtools/svn/subvertpy.py

Ignored Files:
    reviewboard/static/rb/js/configForms/models/tests/resourceListItemModelTests.js
    reviewboard/static/rb/css/ui/boxes.less
    reviewboard/static/rb/js/resources/models/apiTokenModel.js
    reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js
    reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/root.py
    reviewboard/diffviewer/management/commands/condensediffs.py
    reviewboard/attachments/models.py
    reviewboard/diffviewer/managers.py
    reviewboard/reviews/markdown_utils.py
    reviewboard/reviews/tests.py
    reviewboard/webapi/resources/review_request.py
    reviewboard/webapi/tests/test_review_request.py
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/staticbundles.py
    reviewboard/webapi/resources/review_request_draft.py
    reviewboard/webapi/tests/test_review_request_draft.py
    reviewboard/scmtools/svn/subvertpy.py

Ignored Files:
    reviewboard/static/rb/js/configForms/models/tests/resourceListItemModelTests.js
    reviewboard/static/rb/css/ui/boxes.less
    reviewboard/static/rb/js/resources/models/apiTokenModel.js
    reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js
    reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js

Commit:

65d52053fde9cd2fd7a4eb3dc7e25b0bc0073791

82ffe4b69f998467969529f2fd15a26f03baae66

Diff:

Revision 7 (+1382 -216)

Show changes

	AUTHORS
	setup.py
	docs/manual/admin/configuration/file-storage-settings.rst
	docs/manual/admin/installation/linux.rst
	docs/releasenotes/1.7.28.rst
	docs/releasenotes/2.0.6.rst
	docs/releasenotes/index.rst
	reviewboard/__init__.py
	26 more

Summary:: [WIP] New resource for "owned" and review request independent file attachments
New resource for "owned" and review request independent file attachments

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/admin/views.py
    reviewboard/diffviewer/renderers.py
    reviewboard/webapi/resources/root.py
    reviewboard/diffviewer/tests.py
    reviewboard/diffviewer/evolutions/__init__.py
    reviewboard/webapi/resources/diff.py
    reviewboard/staticbundles.py
    reviewboard/diffviewer/evolutions/raw_diff_file_data.py
    reviewboard/admin/forms.py
    reviewboard/attachments/models.py
    reviewboard/webapi/resources/base_original_file.py
    setup.py
    reviewboard/diffviewer/managers.py
    reviewboard/admin/siteconfig.py
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/admin/checks.py
    reviewboard/diffviewer/management/commands/condensediffs.py
    reviewboard/webapi/resources/base_patched_file.py
    reviewboard/scmtools/hg.py
    reviewboard/__init__.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/diffviewer/diffutils.py
    reviewboard/diffviewer/models.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js
    reviewboard/static/rb/js/resources/models/baseResourceModel.js
    docs/releasenotes/index.rst
    docs/manual/admin/installation/linux.rst
    docs/manual/admin/configuration/file-storage-settings.rst
    docs/releasenotes/2.0.6.rst
    AUTHORS
    docs/releasenotes/1.7.28.rst
    reviewboard/static/rb/js/diffviewer/views/diffRevisionSelectorView.js
    reviewboard/static/rb/js/resources/models/apiTokenModel.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/admin/views.py
    reviewboard/diffviewer/renderers.py
    reviewboard/webapi/resources/root.py
    reviewboard/diffviewer/tests.py
    reviewboard/diffviewer/evolutions/__init__.py
    reviewboard/webapi/resources/diff.py
    reviewboard/staticbundles.py
    reviewboard/diffviewer/evolutions/raw_diff_file_data.py
    reviewboard/admin/forms.py
    reviewboard/attachments/models.py
    reviewboard/webapi/resources/base_original_file.py
    setup.py
    reviewboard/diffviewer/managers.py
    reviewboard/admin/siteconfig.py
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/admin/checks.py
    reviewboard/diffviewer/management/commands/condensediffs.py
    reviewboard/webapi/resources/base_patched_file.py
    reviewboard/scmtools/hg.py
    reviewboard/__init__.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/diffviewer/diffutils.py
    reviewboard/diffviewer/models.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js
    reviewboard/static/rb/js/resources/models/baseResourceModel.js
    docs/releasenotes/index.rst
    docs/manual/admin/installation/linux.rst
    docs/manual/admin/configuration/file-storage-settings.rst
    docs/releasenotes/2.0.6.rst
    AUTHORS
    docs/releasenotes/1.7.28.rst
    reviewboard/static/rb/js/diffviewer/views/diffRevisionSelectorView.js
    reviewboard/static/rb/js/resources/models/apiTokenModel.js

reviewboard/__init__.py (Diff revision 7)
The issue has been dropped. Show all issues
```
 'reviewboard' imported but unused
```
reviewboard/admin/siteconfig.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 13
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 22
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 22
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 17
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 26
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 28
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 22
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 22
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 17
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 26
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 28
 E241 multiple spaces after ':'
```
reviewboard/admin/views.py (Diff revision 7)
The issue has been dropped. Show all issues
```
 local variable 'positions_key' is assigned to but never used
```
reviewboard/diffviewer/tests.py (Diff revision 7)
The issue has been dropped. Show all issues
```
 redefinition of unused 'FileDiffMigrationTests' from line 726
```
reviewboard/reviews/views.py (Diff revision 7)
The issue has been dropped. Show all issues
```
 list comprehension redefines 'file_attachment' from line 583
```

Something went terribly wrong with this commit. Make sure you have master merged into your branch.

rvaiya Aug. 23, 2014, 2:53 p.m.

Sorry about that, I have my own repository where I store some of my branches and rbt post was using the master branch upstream of the branch I was working on (which was out of date). I have resolved the issue and updated the review request.

Commit:

82ffe4b69f998467969529f2fd15a26f03baae66

c5a66833bcefedb44af9fe0d30366040fc42636d

Diff:

Revision 8 (+212 -4)

Show changes

	reviewboard/staticbundles.py
	reviewboard/attachments/models.py
	reviewboard/static/rb/js/resources/models/apiTokenModel.js
	reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js
	reviewboard/webapi/resources/file_attachment_user.py
	reviewboard/webapi/resources/root.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/attachments/models.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/apiTokenModel.js
    reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/attachments/models.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/apiTokenModel.js
    reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js

Fix it!

This also needs unit tests for the new API.

reviewboard/attachments/models.py (Diff revision 8)

The issue has been resolved. Show all issues

We generally avoid the ternary form because it's annoying. How about rewriting this as:

if self.orig_filename:
    return self.orig_filename
elif self.file:
    return os.path.basename(self.file.name)
else:
    return None

reviewboard/static/rb/js/resources/models/apiTokenModel.js (Diff revision 8)
The issue has been resolved. Show all issues
```
Why did you make this change?
```
reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js (Diff revision 8)
The issue has been resolved. Show all issues
```
Trailing spaces in javascript can break IE.
```
1. RV
  
  rvaiya Sept. 6, 2014, 6:25 p.m.
  I don't see any trailing spaces.
reviewboard/webapi/resources/file_attachment_user.py (Diff revision 8)
The issue has been resolved. Show all issues
```
Remove this line.
```
reviewboard/webapi/resources/file_attachment_user.py (Diff revision 8)
An issue was opened. Show all issues
```
This should probably include everything if it's an admin making the request.
```

reviewboard/webapi/resources/file_attachment_user.py (Diff revision 8)

The issue has been resolved. Show all issues

Docstrings should generally follow the same format that you might use for a commit message -- the first line should be a summary, and then additional paragraphs can go into more explanation.
Indentation should also be:

def create(self, request, *args, **kwargs):
    """Create a FileAttachment

    Here's some more explanation.
    """


I'm also not 100% sure we should completely ignore the POST parameters. If a file or caption is present, we should use it (the web UI isn't the only consumer of the API).

reviewboard/webapi/resources/file_attachment_user.py (Diff revision 8)
The issue has been resolved. Show all issues
```
Same comments as the above docstring.
```
reviewboard/webapi/resources/file_attachment_user.py (Diff revision 8)
The issue has been resolved. Show all issues
```
What happens if you just let it assign None to the caption field?
```
reviewboard/webapi/resources/file_attachment_user.py (Diff revision 8)
The issue has been resolved. Show all issues
```
PERMISSION_DENIED doesn't seem quite right. How about creating a new error, FILE_ALREADY_EXISTS?
```

Change Summary:

Made changes according to David's remarks

Commit:

c5a66833bcefedb44af9fe0d30366040fc42636d

1b23d5d6cc570bf16f7ee2814aa8bc9159997086

Diff:

Revision 9 (+297 -49)

Show changes

	reviewboard/staticbundles.py
	reviewboard/attachments/forms.py
	reviewboard/attachments/mimetypes.py
	reviewboard/attachments/models.py
	reviewboard/attachments/evolutions/__init__.py
	reviewboard/attachments/evolutions/file_attachment_ownership.py
	reviewboard/static/rb/js/resources/models/apiTokenModel.js
	reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js
	3 more

Fix it!

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/root.py
    reviewboard/attachments/models.py
    reviewboard/webapi/errors.py
    reviewboard/attachments/evolutions/__init__.py
    reviewboard/attachments/mimetypes.py
    reviewboard/attachments/evolutions/file_attachment_ownership.py
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/attachments/forms.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/apiTokenModel.js
    reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js



Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/root.py
    reviewboard/attachments/models.py
    reviewboard/webapi/errors.py
    reviewboard/attachments/evolutions/__init__.py
    reviewboard/attachments/mimetypes.py
    reviewboard/attachments/evolutions/file_attachment_ownership.py
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/attachments/forms.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/apiTokenModel.js
    reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js

reviewboard/webapi/resources/file_attachment_user.py (Diff revision 9)
An issue was opened. Show all issues
```
 'User' imported but unused
```

Commit:

1b23d5d6cc570bf16f7ee2814aa8bc9159997086

0e9b24148f82e38d2874f139651063fc654dbabe

Diff:

Revision 10 (+301 -49)

Show changes

	reviewboard/staticbundles.py
	reviewboard/attachments/forms.py
	reviewboard/attachments/mimetypes.py
	reviewboard/attachments/models.py
	reviewboard/attachments/evolutions/__init__.py
	reviewboard/attachments/evolutions/file_attachment_ownership.py
	reviewboard/static/rb/js/resources/models/apiTokenModel.js
	reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js
	3 more

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/root.py
    reviewboard/attachments/models.py
    reviewboard/webapi/errors.py
    reviewboard/attachments/evolutions/__init__.py
    reviewboard/attachments/mimetypes.py
    reviewboard/attachments/evolutions/file_attachment_ownership.py
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/attachments/forms.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/apiTokenModel.js
    reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/root.py
    reviewboard/attachments/models.py
    reviewboard/webapi/errors.py
    reviewboard/attachments/evolutions/__init__.py
    reviewboard/attachments/mimetypes.py
    reviewboard/attachments/evolutions/file_attachment_ownership.py
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/attachments/forms.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/apiTokenModel.js
    reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js

reviewboard/webapi/resources/file_attachment_user.py (Diff revision 10)
The issue has been resolved. Show all issues
```
 'User' imported but unused
```

Commit:

0e9b24148f82e38d2874f139651063fc654dbabe

6b00122cf113541aca3a08e22d6bf80f5c7687a8

Diff:

Revision 11 (+300 -49)

Show changes

	reviewboard/staticbundles.py
	reviewboard/attachments/forms.py
	reviewboard/attachments/mimetypes.py
	reviewboard/attachments/models.py
	reviewboard/attachments/evolutions/__init__.py
	reviewboard/attachments/evolutions/file_attachment_ownership.py
	reviewboard/static/rb/js/resources/models/apiTokenModel.js
	reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js
	3 more

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/root.py
    reviewboard/attachments/models.py
    reviewboard/webapi/errors.py
    reviewboard/attachments/evolutions/__init__.py
    reviewboard/attachments/mimetypes.py
    reviewboard/attachments/evolutions/file_attachment_ownership.py
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/attachments/forms.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/apiTokenModel.js
    reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/root.py
    reviewboard/attachments/models.py
    reviewboard/webapi/errors.py
    reviewboard/attachments/evolutions/__init__.py
    reviewboard/attachments/mimetypes.py
    reviewboard/attachments/evolutions/file_attachment_ownership.py
    reviewboard/webapi/resources/file_attachment_user.py
    reviewboard/attachments/forms.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/apiTokenModel.js
    reviewboard/static/rb/js/resources/models/fileAttachmentUserModel.js

Status:: Discarded

~		get/create were by hand crafting POST/GET requests using wget, currently in the process of fixing update and get_list. This patch depends on the model changes made in /r/6217/.
	~	get/create were tested by hand crafting POST/GET requests using wget. I am currently in the process of fixing update and get_list. This patch depends on the model changes made in /r/6217/.