Restyled notification message

Review Request #6214 — Created Aug. 10, 2014 and submitted

Information

rb-extension-pack
ec83059...

Reviewers

Restyled notification messages.

Launch Review Together in one browsers.
Click "Add" button and open the provided URL in another browser. (Note the popup in this "Add window")
In the second browser, the notification window upon load should look similar to the "Add window".
Exit the second browser.
A pop up in the first browser should have a notification message saying the peer has quit. This window will resemble the body of the "Add window".


Description From Last Updated

Does this really need the section prefix? There really should only ever be one of these...

mike_conleymike_conley
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        review_together/review_together/forms.py
        review_together/review_together/admin_urls.py
        review_together/review_together/extension.py
    
    Ignored Files:
        review_together/review_together/static/js/togetherjs.js
        review_together/review_together/static/js/review-together.js
        review_together/README.md
        review_together/review_together/static/css/review-together.less
        review_together/review_together/templates/review_together/base.html
    
    
    
    Tool: Pyflakes
    Processed Files:
        review_together/review_together/forms.py
        review_together/review_together/admin_urls.py
        review_together/review_together/extension.py
    
    Ignored Files:
        review_together/review_together/static/js/togetherjs.js
        review_together/review_together/static/js/review-together.js
        review_together/README.md
        review_together/review_together/static/css/review-together.less
        review_together/review_together/templates/review_together/base.html
    
    
  2. 
      
PE
david
  1. The diff on this change seems to contain more than just the style changes. Can you update this and make sure to tell rbt post the correct revisions that you want to post (if you have a branch for just this change, check it out and run rbt post -u HEAD)

  2. 
      
PE
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        review_together/review_together/static/css/review-together.less
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        review_together/review_together/static/css/review-together.less
    
    
  2. 
      
mike_conley
  1. 
      
  2. Show all issues

    Does this really need the section prefix? There really should only ever be one of these...

    1. That's right. ID is unique so it doesn't matter what element is before it?

    2. Correct - this rule says, "Any section, with an ID of togetherjs-chat-notifier-message", when we can just say "anything with an ID of togetherjs-chat-notifier-message".

  3. 
      
PE
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        review_together/review_together/static/css/review-together.less
    
    
    
    Tool: Pyflakes
    Ignored Files:
        review_together/review_together/static/css/review-together.less
    
    
  2. 
      
david
  1. Ship It!

  2. 
      
PE
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (f4b7376)
Loading...