Checklist extension client API and Backbone view
Review Request #6206 — Created Aug. 7, 2014 and discarded
| Information | |
|---|---|
| salam0smy | |
| rb-extension-pack | |
| Reviewers | |
| students | |
Created the necessary files for the client to connect to the api, and manipulate the view.
Attached the files to checklist manager view.
Implemented the managerAPI, and templates model.
Implemented the views.
The views request a list of all lists for existing user, populates the resaults, and allow for added and removing of the list.
Apon adding a list, the user can set the name of the list, which will instantiate the list on the server, and allow to add items to it.
The list cannot be modified at the moment.
Tested on Chrome Browser and Firefox.
There are bugs that needs to be fixed: one bug is that click events sometimes fire multiple times.
| Description | From | Last Updated |
|---|---|---|
|
Col: 80 E501 line too long (80 > 79 characters) |
 reviewbot
|
|
|
'User' imported but unused |
reviewbot
|
|
|
New line to separate dj* imports and reviewboard imports? |
PE PeterTran | |
|
This shouldn't be necessary since this isn't different from the name used for the resource. |
 anselina
|
|
|
Col: 80 E501 line too long (80 > 79 characters) |
reviewbot
|
|
|
Mixed spaces and tabs |
PE PeterTran | |
|
Mixed spaces and tabs |
PE PeterTran | |
|
Mixed spaces and tabs |
PE PeterTran | |
|
Mixed spaces and tabs |
PE PeterTran | |
|
Mixed spaces and tabs |
PE PeterTran | |
|
Is this over indented? |
PE PeterTran | |
|
Col: 80 E501 line too long (80 > 79 characters) |
reviewbot
|
|
|
When the files are minified, this will end up breaking things, because the var will be enclosed within this file … |
 chipx86
|
|
|
Col: 80 E501 line too long (80 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (80 > 79 characters) |
reviewbot
|
SA
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+116 -1) |
-
Tool: PEP8 Style Checker Processed Files: checklist/checklist/extension.py checklist/checklist/ChecklistTemplateResource.py Ignored Files: checklist/checklist/templates/checklist/manager_script.html checklist/checklist/static/js/models/manager.js checklist/checklist/static/js/models/managerAPI.js checklist/checklist/static/js/views/managerView.js Tool: Pyflakes Processed Files: checklist/checklist/extension.py checklist/checklist/ChecklistTemplateResource.py Ignored Files: checklist/checklist/templates/checklist/manager_script.html checklist/checklist/static/js/models/manager.js checklist/checklist/static/js/models/managerAPI.js checklist/checklist/static/js/views/managerView.js -
-
PE
-
-
checklist/checklist/ChecklistTemplateResource.py (Diff revision 2) New line to separate dj* imports and reviewboard imports?
-
-
-
-
-
-
checklist/checklist/templates/checklist/manager_script.html (Diff revision 2) Is this over indented?
-
-
checklist/checklist/ChecklistTemplateResource.py (Diff revision 2) This shouldn't be necessary since this isn't different from the name used for the resource.
-
checklist/checklist/static/js/models/managerAPI.js (Diff revision 2) After changing the name of the resource to 'checklist_template', change this to
+ '/checklist-templates/';.
SA
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+117 -2) |
-
Tool: PEP8 Style Checker Processed Files: checklist/checklist/extension.py checklist/checklist/ChecklistTemplateResource.py Ignored Files: checklist/checklist/templates/checklist/manager_script.html checklist/checklist/static/js/models/manager.js checklist/checklist/static/js/models/managerAPI.js checklist/checklist/static/js/views/managerView.js Tool: Pyflakes Processed Files: checklist/checklist/extension.py checklist/checklist/ChecklistTemplateResource.py Ignored Files: checklist/checklist/templates/checklist/manager_script.html checklist/checklist/static/js/models/manager.js checklist/checklist/static/js/models/managerAPI.js checklist/checklist/static/js/views/managerView.js -
-
-
checklist/checklist/static/js/models/manager.js (Diff revision 3) When the files are minified, this will end up breaking things, because the
varwill be enclosed within this file and not accessible outside of it.Instead, do:
ChecklistTemplates = {};
SA
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+248 -14) |
-
Tool: PEP8 Style Checker Processed Files: checklist/checklist/extension.py checklist/checklist/ChecklistTemplateResource.py Ignored Files: checklist/checklist/templates/checklist/manager_script.html checklist/checklist/templates/checklist/manager.html checklist/checklist/static/js/models/manager.js checklist/checklist/static/js/models/managerAPI.js checklist/checklist/static/js/views/managerView.js Tool: Pyflakes Processed Files: checklist/checklist/extension.py checklist/checklist/ChecklistTemplateResource.py Ignored Files: checklist/checklist/templates/checklist/manager_script.html checklist/checklist/templates/checklist/manager.html checklist/checklist/static/js/models/manager.js checklist/checklist/static/js/models/managerAPI.js checklist/checklist/static/js/views/managerView.js -
SA
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 5 (+308 -18) |
-
Tool: PEP8 Style Checker Processed Files: checklist/checklist/extension.py checklist/checklist/ChecklistTemplateResource.py Ignored Files: checklist/checklist/static/css/manager.less checklist/checklist/static/js/views/managerView.js checklist/checklist/templates/checklist/manager.html checklist/checklist/templates/checklist/manager_script.html checklist/checklist/static/js/models/managerAPI.js checklist/checklist/static/js/models/manager.js Tool: Pyflakes Processed Files: checklist/checklist/extension.py checklist/checklist/ChecklistTemplateResource.py Ignored Files: checklist/checklist/static/css/manager.less checklist/checklist/static/js/views/managerView.js checklist/checklist/templates/checklist/manager.html checklist/checklist/templates/checklist/manager_script.html checklist/checklist/static/js/models/managerAPI.js checklist/checklist/static/js/models/manager.js -
SA
Description: |
|
||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
||||||||||||||||||||||||
Added Files: |
Tool: PEP8 Style Checker Processed Files: checklist/checklist/extension.py Ignored Files: checklist/checklist/templates/checklist/manager_script.html checklist/checklist/static/js/models/manager.js checklist/checklist/static/js/models/managerAPI.js checklist/checklist/static/js/views/managerView.js Tool: Pyflakes Processed Files: checklist/checklist/extension.py Ignored Files: checklist/checklist/templates/checklist/manager_script.html checklist/checklist/static/js/models/manager.js checklist/checklist/static/js/models/managerAPI.js checklist/checklist/static/js/views/managerView.js