Summary

Checklist extension client API and Backbone view

Review Request #6206 — Created Aug. 7, 2014 and discarded Dec. 10, 2014, 4:53 p.m.

Information

Owner

salam0smy

Repository

rb-extension-pack

Branch

Bugs

Depends On

Reviewers

Groups

students

People

Description

Created the necessary files for the client to connect to the api, and manipulate the view.
Attached the files to checklist manager view.
Implemented the managerAPI, and templates model.
Implemented the views.
The views request a list of all lists for existing user, populates the resaults, and allow for added and removing of the list.
Apon adding a list, the user can set the name of the list, which will instantiate the list on the server, and allow to add items to it.
The list cannot be modified at the moment.

Testing Done

Tested on Chrome Browser and Firefox.
There are bugs that needs to be fixed: one bug is that click events sometimes fire multiple times.

Files

Issues

Description	From	Last Updated
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Aug. 12, 2014, 6:56 a.m.
'User' imported but unused	reviewbot	Aug. 12, 2014, 6:56 a.m.
New line to separate dj* imports and reviewboard imports?	PE PeterTran	Aug. 12, 2014, 6:56 a.m.
This shouldn't be necessary since this isn't different from the name used for the resource.	anselina	Aug. 12, 2014, 6:56 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Aug. 12, 2014, 6:56 a.m.
Mixed spaces and tabs	PE PeterTran	Aug. 12, 2014, 6:56 a.m.
Mixed spaces and tabs	PE PeterTran	Aug. 12, 2014, 6:56 a.m.
Mixed spaces and tabs	PE PeterTran	Aug. 12, 2014, 6:56 a.m.
Mixed spaces and tabs	PE PeterTran	Aug. 12, 2014, 6:56 a.m.
Mixed spaces and tabs	PE PeterTran	Aug. 12, 2014, 6:56 a.m.
Is this over indented?	PE PeterTran	Aug. 12, 2014, 6:56 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Aug. 11, 2014, 9:37 a.m.
When the files are minified, this will end up breaking things, because the var will be enclosed within this file …	chipx86	Aug. 11, 2014, 12:19 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Aug. 12, 2014, 6:51 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Aug. 12, 2014, 12:31 p.m.

Tool: PEP8 Style Checker
Processed Files:
    checklist/checklist/extension.py

Ignored Files:
    checklist/checklist/templates/checklist/manager_script.html
    checklist/checklist/static/js/models/manager.js
    checklist/checklist/static/js/models/managerAPI.js
    checklist/checklist/static/js/views/managerView.js



Tool: Pyflakes
Processed Files:
    checklist/checklist/extension.py

Ignored Files:
    checklist/checklist/templates/checklist/manager_script.html
    checklist/checklist/static/js/models/manager.js
    checklist/checklist/static/js/models/managerAPI.js
    checklist/checklist/static/js/views/managerView.js

checklist/checklist/extension.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```

Commit:

-	9c979060589c1bca5eb7b2790202615b007c366c
+	a7ed5f7292318382c20ab631e5fb14c2f6026ad5

Diff:

Revision 2 (+116 -1)

Show changes

	checklist/checklist/ChecklistTemplateResource.py
	checklist/checklist/extension.py
	checklist/checklist/static/js/models/manager.js
	checklist/checklist/static/js/models/managerAPI.js
	checklist/checklist/static/js/views/managerView.js
	checklist/checklist/templates/checklist/manager_script.html

Tool: PEP8 Style Checker
Processed Files:
    checklist/checklist/extension.py
    checklist/checklist/ChecklistTemplateResource.py

Ignored Files:
    checklist/checklist/templates/checklist/manager_script.html
    checklist/checklist/static/js/models/manager.js
    checklist/checklist/static/js/models/managerAPI.js
    checklist/checklist/static/js/views/managerView.js



Tool: Pyflakes
Processed Files:
    checklist/checklist/extension.py
    checklist/checklist/ChecklistTemplateResource.py

Ignored Files:
    checklist/checklist/templates/checklist/manager_script.html
    checklist/checklist/static/js/models/manager.js
    checklist/checklist/static/js/models/managerAPI.js
    checklist/checklist/static/js/views/managerView.js

checklist/checklist/ChecklistTemplateResource.py (Diff revision 2)
The issue has been resolved. Show all issues
```
 'User' imported but unused
```
checklist/checklist/extension.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```

checklist/checklist/ChecklistTemplateResource.py (Diff revision 2)
The issue has been resolved. Show all issues
```
New line to separate dj* imports and reviewboard imports?
```
checklist/checklist/static/js/models/manager.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Mixed spaces and tabs
```
checklist/checklist/static/js/models/manager.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Mixed spaces and tabs
```

checklist/checklist/static/js/models/managerAPI.js (Diff revision 2)

The issue has been resolved. Show all issues

Mixed spaces and tabs

checklist/checklist/static/js/views/managerView.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Mixed spaces and tabs
```

checklist/checklist/static/js/views/managerView.js (Diff revision 2)

The issue has been resolved. Show all issues

Mixed spaces and tabs

checklist/checklist/templates/checklist/manager_script.html (Diff revision 2)
The issue has been resolved. Show all issues
```
Is this over indented?
```

checklist/checklist/ChecklistTemplateResource.py (Diff revision 2)
The issue has been resolved. Show all issues
```
This shouldn't be necessary since this isn't different from the name used for the resource.
```

checklist/checklist/static/js/models/managerAPI.js (Diff revision 2)

After changing the name of the resource to 'checklist_template', change this to + '/checklist-templates/';.

Commit:

-	a7ed5f7292318382c20ab631e5fb14c2f6026ad5
+	351d9ba49ac4ac020c5302997ff7ed3431748f51

Diff:

Revision 3 (+117 -2)

Show changes

	checklist/checklist/ChecklistTemplateResource.py
	checklist/checklist/extension.py
	checklist/checklist/static/js/models/manager.js
	checklist/checklist/static/js/models/managerAPI.js
	checklist/checklist/static/js/views/managerView.js
	checklist/checklist/templates/checklist/manager_script.html

Fix it!

Tool: PEP8 Style Checker
Processed Files:
    checklist/checklist/extension.py
    checklist/checklist/ChecklistTemplateResource.py

Ignored Files:
    checklist/checklist/templates/checklist/manager_script.html
    checklist/checklist/static/js/models/manager.js
    checklist/checklist/static/js/models/managerAPI.js
    checklist/checklist/static/js/views/managerView.js



Tool: Pyflakes
Processed Files:
    checklist/checklist/extension.py
    checklist/checklist/ChecklistTemplateResource.py

Ignored Files:
    checklist/checklist/templates/checklist/manager_script.html
    checklist/checklist/static/js/models/manager.js
    checklist/checklist/static/js/models/managerAPI.js
    checklist/checklist/static/js/views/managerView.js

checklist/checklist/extension.py (Diff revision 3)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```

Summary:

-	[WIP] Checklist extension client API and Backbone view
+	Checklist extension client API and Backbone view

Fix it!

checklist/checklist/static/js/models/manager.js (Diff revision 3)

An issue was opened. Show all issues

When the files are minified, this will end up breaking things, because the var will be enclosed within this file and not accessible outside of it.
Instead, do:
ChecklistTemplates = {};

Commit:

-	351d9ba49ac4ac020c5302997ff7ed3431748f51
+	d7eb5787f8f9b6d84b5a2b75935e6e9f420a13d5

Diff:

Revision 4 (+248 -14)

Show changes

	checklist/checklist/ChecklistTemplateResource.py
	checklist/checklist/extension.py
	checklist/checklist/static/js/models/manager.js
	checklist/checklist/static/js/models/managerAPI.js
	checklist/checklist/static/js/views/managerView.js
	checklist/checklist/templates/checklist/manager.html
	checklist/checklist/templates/checklist/manager_script.html

Fix it!

Tool: PEP8 Style Checker
Processed Files:
    checklist/checklist/extension.py
    checklist/checklist/ChecklistTemplateResource.py

Ignored Files:
    checklist/checklist/templates/checklist/manager_script.html
    checklist/checklist/templates/checklist/manager.html
    checklist/checklist/static/js/models/manager.js
    checklist/checklist/static/js/models/managerAPI.js
    checklist/checklist/static/js/views/managerView.js



Tool: Pyflakes
Processed Files:
    checklist/checklist/extension.py
    checklist/checklist/ChecklistTemplateResource.py

Ignored Files:
    checklist/checklist/templates/checklist/manager_script.html
    checklist/checklist/templates/checklist/manager.html
    checklist/checklist/static/js/models/manager.js
    checklist/checklist/static/js/models/managerAPI.js
    checklist/checklist/static/js/views/managerView.js

checklist/checklist/extension.py (Diff revision 4)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```

Commit:

-	d7eb5787f8f9b6d84b5a2b75935e6e9f420a13d5
+	dbb107c2b355ae4a433907bbfe326a7f4b0bd8c8

Diff:

Revision 5 (+308 -18)

Show changes

	checklist/checklist/ChecklistTemplateResource.py
	checklist/checklist/extension.py
	checklist/checklist/static/css/manager.less
	checklist/checklist/static/js/models/manager.js
	checklist/checklist/static/js/models/managerAPI.js
	checklist/checklist/static/js/views/managerView.js
	checklist/checklist/templates/checklist/manager.html
	checklist/checklist/templates/checklist/manager_script.html

Fix it!

Tool: PEP8 Style Checker
Processed Files:
    checklist/checklist/extension.py
    checklist/checklist/ChecklistTemplateResource.py

Ignored Files:
    checklist/checklist/static/css/manager.less
    checklist/checklist/static/js/views/managerView.js
    checklist/checklist/templates/checklist/manager.html
    checklist/checklist/templates/checklist/manager_script.html
    checklist/checklist/static/js/models/managerAPI.js
    checklist/checklist/static/js/models/manager.js



Tool: Pyflakes
Processed Files:
    checklist/checklist/extension.py
    checklist/checklist/ChecklistTemplateResource.py

Ignored Files:
    checklist/checklist/static/css/manager.less
    checklist/checklist/static/js/views/managerView.js
    checklist/checklist/templates/checklist/manager.html
    checklist/checklist/templates/checklist/manager_script.html
    checklist/checklist/static/js/models/managerAPI.js
    checklist/checklist/static/js/models/manager.js

checklist/checklist/extension.py (Diff revision 5)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```

Description:

		Created the necessary files for the client to connect to the api, and manipulate the view.
		Attached the files to checklist manager view.
~		Implemented the managerAPI, and templates model.
	~	Implemented the managerAPI, and templates model.
	+	Implemented the views.
	+	The views request a list of all lists for existing user, populates the resaults, and allow for added and removing of the list.
	+	Apon adding a list, the user can set the name of the list, which will instantiate the list on the server, and allow to add items to it.
	+	The list cannot be modified at the moment.

Testing Done:

	+	Tested on Chrome Browser and Firefox.
	+	There are bugs that needs to be fixed: one bug is that click events sometimes fire multiple times.

Review Board 7.0 alpha 0 (dev)

Checklist extension client API and Backbone view

Information

Reviewers

Commit:

Diff:

Commit:

Diff:

Summary:

Commit:

Diff:

Commit:

Diff:

Description:

Testing Done:

Added Files:

Status: Discarded