Checklist extension client API and Backbone view

Review Request #6206 — Created Aug. 7, 2014 and discarded

salam0smy
rb-extension-pack
students

Created the necessary files for the client to connect to the api, and manipulate the view.
Attached the files to checklist manager view.
Implemented the managerAPI, and templates model.
Implemented the views.
The views request a list of all lists for existing user, populates the resaults, and allow for added and removing of the list.
Apon adding a list, the user can set the name of the list, which will instantiate the list on the server, and allow to add items to it.
The list cannot be modified at the moment.

Tested on Chrome Browser and Firefox.
There are bugs that needs to be fixed: one bug is that click events sometimes fire multiple times.


Description From Last Updated

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

'User' imported but unused

reviewbotreviewbot

New line to separate dj* imports and reviewboard imports?

PE PeterTran

This shouldn't be necessary since this isn't different from the name used for the resource.

anselinaanselina

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Mixed spaces and tabs

PE PeterTran

Mixed spaces and tabs

PE PeterTran

Mixed spaces and tabs

PE PeterTran

Mixed spaces and tabs

PE PeterTran

Mixed spaces and tabs

PE PeterTran

Is this over indented?

PE PeterTran

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

When the files are minified, this will end up breaking things, because the var will be enclosed within this file …

chipx86chipx86

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        checklist/checklist/extension.py
    
    Ignored Files:
        checklist/checklist/templates/checklist/manager_script.html
        checklist/checklist/static/js/models/manager.js
        checklist/checklist/static/js/models/managerAPI.js
        checklist/checklist/static/js/views/managerView.js
    
    
    
    Tool: Pyflakes
    Processed Files:
        checklist/checklist/extension.py
    
    Ignored Files:
        checklist/checklist/templates/checklist/manager_script.html
        checklist/checklist/static/js/models/manager.js
        checklist/checklist/static/js/models/managerAPI.js
        checklist/checklist/static/js/views/managerView.js
    
    
  2. checklist/checklist/extension.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (80 > 79 characters)
    
  3. 
      
SA
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        checklist/checklist/extension.py
        checklist/checklist/ChecklistTemplateResource.py
    
    Ignored Files:
        checklist/checklist/templates/checklist/manager_script.html
        checklist/checklist/static/js/models/manager.js
        checklist/checklist/static/js/models/managerAPI.js
        checklist/checklist/static/js/views/managerView.js
    
    
    
    Tool: Pyflakes
    Processed Files:
        checklist/checklist/extension.py
        checklist/checklist/ChecklistTemplateResource.py
    
    Ignored Files:
        checklist/checklist/templates/checklist/manager_script.html
        checklist/checklist/static/js/models/manager.js
        checklist/checklist/static/js/models/managerAPI.js
        checklist/checklist/static/js/views/managerView.js
    
    
  2.  'User' imported but unused
    
  3. checklist/checklist/extension.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (80 > 79 characters)
    
  4. 
      
PE
  1. 
      
  2. New line to separate dj* imports and reviewboard imports?

  3. Mixed spaces and tabs

  4. Mixed spaces and tabs

  5. checklist/checklist/static/js/models/managerAPI.js (Diff revision 2)
     
     
     
     
     
     
     
     
     
     
     
     

    Mixed spaces and tabs

  6. checklist/checklist/static/js/views/managerView.js (Diff revision 2)
     
     
     
     
     
     
     

    Mixed spaces and tabs

  7. checklist/checklist/static/js/views/managerView.js (Diff revision 2)
     
     
     
     
     
     
     
     
     

    Mixed spaces and tabs

  8. Is this over indented?

  9. 
      
anselina
  1. 
      
  2. This shouldn't be necessary since this isn't different from the name used for the resource.

  3. After changing the name of the resource to 'checklist_template', change this to + '/checklist-templates/';.

  4. 
      
SA
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        checklist/checklist/extension.py
        checklist/checklist/ChecklistTemplateResource.py
    
    Ignored Files:
        checklist/checklist/templates/checklist/manager_script.html
        checklist/checklist/static/js/models/manager.js
        checklist/checklist/static/js/models/managerAPI.js
        checklist/checklist/static/js/views/managerView.js
    
    
    
    Tool: Pyflakes
    Processed Files:
        checklist/checklist/extension.py
        checklist/checklist/ChecklistTemplateResource.py
    
    Ignored Files:
        checklist/checklist/templates/checklist/manager_script.html
        checklist/checklist/static/js/models/manager.js
        checklist/checklist/static/js/models/managerAPI.js
        checklist/checklist/static/js/views/managerView.js
    
    
  2. checklist/checklist/extension.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (80 > 79 characters)
    
  3. 
      
SA
chipx86
  1. 
      
  2. When the files are minified, this will end up breaking things, because the var will be enclosed within this file and not accessible outside of it.

    Instead, do:

    ChecklistTemplates = {};
    
  3. 
      
SA
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        checklist/checklist/extension.py
        checklist/checklist/ChecklistTemplateResource.py
    
    Ignored Files:
        checklist/checklist/templates/checklist/manager_script.html
        checklist/checklist/templates/checklist/manager.html
        checklist/checklist/static/js/models/manager.js
        checklist/checklist/static/js/models/managerAPI.js
        checklist/checklist/static/js/views/managerView.js
    
    
    
    Tool: Pyflakes
    Processed Files:
        checklist/checklist/extension.py
        checklist/checklist/ChecklistTemplateResource.py
    
    Ignored Files:
        checklist/checklist/templates/checklist/manager_script.html
        checklist/checklist/templates/checklist/manager.html
        checklist/checklist/static/js/models/manager.js
        checklist/checklist/static/js/models/managerAPI.js
        checklist/checklist/static/js/views/managerView.js
    
    
  2. checklist/checklist/extension.py (Diff revision 4)
     
     
    Col: 80
     E501 line too long (80 > 79 characters)
    
  3. 
      
SA
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        checklist/checklist/extension.py
        checklist/checklist/ChecklistTemplateResource.py
    
    Ignored Files:
        checklist/checklist/static/css/manager.less
        checklist/checklist/static/js/views/managerView.js
        checklist/checklist/templates/checklist/manager.html
        checklist/checklist/templates/checklist/manager_script.html
        checklist/checklist/static/js/models/managerAPI.js
        checklist/checklist/static/js/models/manager.js
    
    
    
    Tool: Pyflakes
    Processed Files:
        checklist/checklist/extension.py
        checklist/checklist/ChecklistTemplateResource.py
    
    Ignored Files:
        checklist/checklist/static/css/manager.less
        checklist/checklist/static/js/views/managerView.js
        checklist/checklist/templates/checklist/manager.html
        checklist/checklist/templates/checklist/manager_script.html
        checklist/checklist/static/js/models/managerAPI.js
        checklist/checklist/static/js/models/manager.js
    
    
  2. checklist/checklist/extension.py (Diff revision 5)
     
     
    Col: 80
     E501 line too long (80 > 79 characters)
    
  3. 
      
SA
SA
Review request changed

Status: Discarded

Loading...