-
-
reviewboard/reviews/views.py (Diff revision 1) list comprehension redefines 'file_attachment' from line 583
-
-
-
reviewboard/webapi/resources/base_patched_file.py (Diff revision 1) Col: 80 E501 line too long (83 > 79 characters)
Corrected work with encoding on subversion and generate diff
Review Request #6205 — Created Aug. 7, 2014 and discarded
| Information | |
|---|---|
| 1tush | |
| Review Board | |
| master | |
| 934db59... | |
| Reviewers | |
| reviewboard | |
When repository encoding different from UTF-8, applying unicode (utf-8) diff to non utf-8 original file may cause an error (reviewboard/diffviewer/diffutils.py 'patch' function).
Also in code of both subversion client encoding of repository was hardcoded.
1T
Change Summary:
fix pep8 and pyflake issues
Commit: |
|
||
|---|---|---|---|
Diff: |
Revision 2 (+26 -16) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/webapi/resources/base_patched_file.py reviewboard/scmtools/svn/pysvn.py reviewboard/scmtools/svn/base.py reviewboard/webapi/resources/base_original_file.py reviewboard/diffviewer/chunk_generator.py reviewboard/diffviewer/diffutils.py reviewboard/scmtools/svn/subvertpy.py reviewboard/scmtools/svn/__init__.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/webapi/resources/base_patched_file.py reviewboard/scmtools/svn/pysvn.py reviewboard/scmtools/svn/base.py reviewboard/webapi/resources/base_original_file.py reviewboard/diffviewer/chunk_generator.py reviewboard/diffviewer/diffutils.py reviewboard/scmtools/svn/subvertpy.py reviewboard/scmtools/svn/__init__.py
-
Something about the way you updated the diff isn't correct. Revision 2 seems to use your first revision as a parent diff, instead of just containing a full diff between upstream and your code.
1T
Change Summary:
Updated diff (now revision3 contains full list of changes)
Commit: |
|
||
|---|---|---|---|
Diff: |
Revision 3 (+46 -28) |
-
I haven't looked too closely at the code yet, because your "Testing done" section is not filled out. For a change like this, we really need to know what testing steps you've taken already.
-
reviewboard/scmtools/svn/base.py (Diff revision 3) Might as well use a list, since this is called
encoding_list
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/webapi/resources/base_patched_file.py reviewboard/scmtools/svn/pysvn.py reviewboard/scmtools/svn/base.py reviewboard/webapi/resources/base_original_file.py reviewboard/diffviewer/chunk_generator.py reviewboard/diffviewer/diffutils.py reviewboard/scmtools/svn/subvertpy.py reviewboard/scmtools/svn/__init__.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/webapi/resources/base_patched_file.py reviewboard/scmtools/svn/pysvn.py reviewboard/scmtools/svn/base.py reviewboard/webapi/resources/base_original_file.py reviewboard/diffviewer/chunk_generator.py reviewboard/diffviewer/diffutils.py reviewboard/scmtools/svn/subvertpy.py reviewboard/scmtools/svn/__init__.py