Improved work with encoding on subversion/diff generate

Review Request #6202 — Created Aug. 6, 2014 and discarded

Information

Review Board
master
e9e95f6...

Reviewers

When repository encoding different from UTF-8, applying unicode (utf-8) diff to non utf-8 original file may cause an error (reviewboard/diffviewer/diffutils.py 'patch' function).
Also in code of both subversion client encoding of repository was hardcoded.


 
Description From Last Updated

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (90 > 79 characters)

reviewbotreviewbot

list comprehension redefines 'file_attachment' from line 583

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (95 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (95 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

'_' imported but unused

reviewbotreviewbot

Col: 80 E501 line too long (95 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

redefinition of unused '_' from line 21

reviewbotreviewbot

undefined name '_'

reviewbotreviewbot

undefined name '_'

reviewbotreviewbot

Col: 80 E501 line too long (83 > 79 characters)

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/webapi/resources/base_patched_file.py
        reviewboard/scmtools/svn/pysvn.py
        reviewboard/scmtools/svn/base.py
        reviewboard/webapi/resources/base_original_file.py
        reviewboard/diffviewer/chunk_generator.py
        reviewboard/diffviewer/diffutils.py
        reviewboard/scmtools/svn/subvertpy.py
        reviewboard/scmtools/svn/__init__.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/webapi/resources/base_patched_file.py
        reviewboard/scmtools/svn/pysvn.py
        reviewboard/scmtools/svn/base.py
        reviewboard/webapi/resources/base_original_file.py
        reviewboard/diffviewer/chunk_generator.py
        reviewboard/diffviewer/diffutils.py
        reviewboard/scmtools/svn/subvertpy.py
        reviewboard/scmtools/svn/__init__.py
    
    
  2. Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  3. reviewboard/diffviewer/diffutils.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (90 > 79 characters)
    
  4. reviewboard/reviews/views.py (Diff revision 1)
     
     
    Show all issues
     list comprehension redefines 'file_attachment' from line 583
    
  5. reviewboard/scmtools/svn/__init__.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  6. reviewboard/scmtools/svn/base.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (95 > 79 characters)
    
  7. reviewboard/scmtools/svn/pysvn.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (95 > 79 characters)
    
  8. reviewboard/scmtools/svn/pysvn.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (93 > 79 characters)
    
  9. reviewboard/scmtools/svn/subvertpy.py (Diff revision 1)
     
     
    Show all issues
     '_' imported but unused
    
  10. reviewboard/scmtools/svn/subvertpy.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (95 > 79 characters)
    
  11. reviewboard/scmtools/svn/subvertpy.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (93 > 79 characters)
    
  12. reviewboard/scmtools/svn/subvertpy.py (Diff revision 1)
     
     
    Show all issues
     redefinition of unused '_' from line 21
    
  13. Show all issues
     undefined name '_'
    
  14. Show all issues
     undefined name '_'
    
  15. Show all issues
    Col: 80
     E501 line too long (83 > 79 characters)
    
  16. 
      
1T
1T
1T
Review request changed
Status:
Discarded