Improved work with encoding on subversion/diff generate
Review Request #6202 — Created Aug. 6, 2014 and discarded
When repository encoding different from UTF-8, applying unicode (utf-8) diff to non utf-8 original file may cause an error (reviewboard/diffviewer/diffutils.py 'patch' function).
Also in code of both subversion client encoding of repository was hardcoded.
| Description | From | Last Updated |
|---|---|---|
|
Col: 80 E501 line too long (85 > 79 characters) |
 reviewbot
|
|
|
Col: 80 E501 line too long (90 > 79 characters) |
reviewbot
|
|
|
list comprehension redefines 'file_attachment' from line 583 |
reviewbot
|
|
|
Col: 80 E501 line too long (80 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (95 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (95 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (93 > 79 characters) |
reviewbot
|
|
|
'_' imported but unused |
reviewbot
|
|
|
Col: 80 E501 line too long (95 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (93 > 79 characters) |
reviewbot
|
|
|
redefinition of unused '_' from line 21 |
reviewbot
|
|
|
undefined name '_' |
reviewbot
|
|
|
undefined name '_' |
reviewbot
|
|
|
Col: 80 E501 line too long (83 > 79 characters) |
reviewbot
|
1T
- Change Summary:
-
Change variable name
- Commit:
-
e9e95f68f3c83b0ce4e7e363fcbeb912821a9e81
- Diff:
-
Revision 2 (+31 -23)
1T
- Change Summary:
-
Change variable name
- Commit:
-
e9e95f68f3c83b0ce4e7e363fcbeb912821a9e81
- Diff:
-
Revision 3 (+31 -23)
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/webapi/resources/base_patched_file.py reviewboard/scmtools/svn/pysvn.py reviewboard/scmtools/svn/base.py reviewboard/webapi/resources/base_original_file.py reviewboard/diffviewer/chunk_generator.py reviewboard/diffviewer/diffutils.py reviewboard/scmtools/svn/subvertpy.py reviewboard/scmtools/svn/__init__.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/webapi/resources/base_patched_file.py reviewboard/scmtools/svn/pysvn.py reviewboard/scmtools/svn/base.py reviewboard/webapi/resources/base_original_file.py reviewboard/diffviewer/chunk_generator.py reviewboard/diffviewer/diffutils.py reviewboard/scmtools/svn/subvertpy.py reviewboard/scmtools/svn/__init__.py