Summary

Improved work with encoding on subversion/diff generate

Review Request #6202 — Created Aug. 6, 2014 and discarded Aug. 7, 2014, 12:41 a.m.

Information

Owner

1tush

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

e9e95f6...

Reviewers

Groups

reviewboard

People

Description

When repository encoding different from UTF-8, applying unicode (utf-8) diff to non utf-8 original file may cause an error (reviewboard/diffviewer/diffutils.py 'patch' function).
Also in code of both subversion client encoding of repository was hardcoded.

Testing Done

Issues

Description	From	Last Updated
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Aug. 6, 2014, 6:52 a.m.
Col: 80 E501 line too long (90 > 79 characters)	reviewbot	Aug. 6, 2014, 6:52 a.m.
list comprehension redefines 'file_attachment' from line 583	reviewbot	Aug. 6, 2014, 6:52 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Aug. 6, 2014, 6:52 a.m.
Col: 80 E501 line too long (95 > 79 characters)	reviewbot	Aug. 6, 2014, 6:52 a.m.
Col: 80 E501 line too long (95 > 79 characters)	reviewbot	Aug. 6, 2014, 6:52 a.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Aug. 6, 2014, 6:52 a.m.
'_' imported but unused	reviewbot	Aug. 6, 2014, 6:52 a.m.
Col: 80 E501 line too long (95 > 79 characters)	reviewbot	Aug. 6, 2014, 6:52 a.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Aug. 6, 2014, 6:52 a.m.
redefinition of unused '_' from line 21	reviewbot	Aug. 6, 2014, 7:33 a.m.
undefined name '_'	reviewbot	Aug. 6, 2014, 6:52 a.m.
undefined name '_'	reviewbot	Aug. 6, 2014, 6:52 a.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	Aug. 6, 2014, 6:52 a.m.

Fix it!

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/webapi/resources/base_patched_file.py
    reviewboard/scmtools/svn/pysvn.py
    reviewboard/scmtools/svn/base.py
    reviewboard/webapi/resources/base_original_file.py
    reviewboard/diffviewer/chunk_generator.py
    reviewboard/diffviewer/diffutils.py
    reviewboard/scmtools/svn/subvertpy.py
    reviewboard/scmtools/svn/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/webapi/resources/base_patched_file.py
    reviewboard/scmtools/svn/pysvn.py
    reviewboard/scmtools/svn/base.py
    reviewboard/webapi/resources/base_original_file.py
    reviewboard/diffviewer/chunk_generator.py
    reviewboard/diffviewer/diffutils.py
    reviewboard/scmtools/svn/subvertpy.py
    reviewboard/scmtools/svn/__init__.py

reviewboard/diffviewer/chunk_generator.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (90 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 1)
An issue was opened. Show all issues
```
 list comprehension redefines 'file_attachment' from line 583
```
reviewboard/scmtools/svn/__init__.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
reviewboard/scmtools/svn/base.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (95 > 79 characters)
```
reviewboard/scmtools/svn/pysvn.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (95 > 79 characters)
```
reviewboard/scmtools/svn/pysvn.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (93 > 79 characters)
```
reviewboard/scmtools/svn/subvertpy.py (Diff revision 1)
An issue was opened. Show all issues
```
 '_' imported but unused
```
reviewboard/scmtools/svn/subvertpy.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (95 > 79 characters)
```
reviewboard/scmtools/svn/subvertpy.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (93 > 79 characters)
```
reviewboard/scmtools/svn/subvertpy.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 redefinition of unused '_' from line 21
```
reviewboard/webapi/resources/base_original_file.py (Diff revision 1)
An issue was opened. Show all issues
```
 undefined name '_'
```
reviewboard/webapi/resources/base_patched_file.py (Diff revision 1)
An issue was opened. Show all issues
```
 undefined name '_'
```
reviewboard/webapi/resources/base_patched_file.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```

Change Summary:

Change variable name

Commit:

e9e95f68f3c83b0ce4e7e363fcbeb912821a9e81

Diff:

Revision 2 (+31 -23)

Show changes

	reviewboard/diffviewer/chunk_generator.py
	reviewboard/diffviewer/diffutils.py
	reviewboard/reviews/views.py
	reviewboard/scmtools/svn/__init__.py
	reviewboard/scmtools/svn/base.py
	reviewboard/scmtools/svn/pysvn.py
	reviewboard/scmtools/svn/subvertpy.py
	reviewboard/webapi/resources/base_original_file.py
	1 more