Make SVN keyword handling case-insensitive.

Review Request #6199 — Created Aug. 5, 2014 and submitted

Information

Review Board
release-1.7.x
c037ee0...

Reviewers

Our existing handling for SVN keywords only works when the keywords had very
specific casing. This change fixes it to lower-case everything first, and does
a case-insensitive regex substitution.

Tested with several diffs that used svn:keywords with various casing.

Description From Last Updated

Col: 20 E221 multiple spaces before operator

reviewbotreviewbot

Col: 18 E221 multiple spaces before operator

reviewbotreviewbot

Col: 17 E221 multiple spaces before operator

reviewbotreviewbot

Col: 16 E221 multiple spaces before operator

reviewbotreviewbot

Col: 20 E221 multiple spaces before operator

reviewbotreviewbot

Col: 18 E241 multiple spaces after ':'

reviewbotreviewbot

Col: 16 E241 multiple spaces after ':'

reviewbotreviewbot

Col: 20 E241 multiple spaces after ':'

reviewbotreviewbot

Col: 19 E241 multiple spaces after ':'

reviewbotreviewbot

Col: 14 E241 multiple spaces after ':'

reviewbotreviewbot

Col: 18 E241 multiple spaces after ':'

reviewbotreviewbot

Col: 25 E241 multiple spaces after ':'

reviewbotreviewbot

Col: 27 E241 multiple spaces after ':'

reviewbotreviewbot

Col: 15 E241 multiple spaces after ':'

reviewbotreviewbot

Col: 15 E241 multiple spaces after ':'

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/scmtools/svn.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/scmtools/svn.py
    
    
  2. reviewboard/scmtools/svn.py (Diff revision 1)
     
     
    Show all issues
    Col: 20
     E221 multiple spaces before operator
    
  3. reviewboard/scmtools/svn.py (Diff revision 1)
     
     
    Show all issues
    Col: 18
     E221 multiple spaces before operator
    
  4. reviewboard/scmtools/svn.py (Diff revision 1)
     
     
    Show all issues
    Col: 17
     E221 multiple spaces before operator
    
  5. reviewboard/scmtools/svn.py (Diff revision 1)
     
     
    Show all issues
    Col: 16
     E221 multiple spaces before operator
    
  6. reviewboard/scmtools/svn.py (Diff revision 1)
     
     
    Show all issues
    Col: 20
     E221 multiple spaces before operator
    
  7. reviewboard/scmtools/svn.py (Diff revision 1)
     
     
    Show all issues
    Col: 18
     E241 multiple spaces after ':'
    
  8. reviewboard/scmtools/svn.py (Diff revision 1)
     
     
    Show all issues
    Col: 16
     E241 multiple spaces after ':'
    
  9. reviewboard/scmtools/svn.py (Diff revision 1)
     
     
    Show all issues
    Col: 20
     E241 multiple spaces after ':'
    
  10. reviewboard/scmtools/svn.py (Diff revision 1)
     
     
    Show all issues
    Col: 19
     E241 multiple spaces after ':'
    
  11. reviewboard/scmtools/svn.py (Diff revision 1)
     
     
    Show all issues
    Col: 14
     E241 multiple spaces after ':'
    
  12. reviewboard/scmtools/svn.py (Diff revision 1)
     
     
    Show all issues
    Col: 18
     E241 multiple spaces after ':'
    
  13. reviewboard/scmtools/svn.py (Diff revision 1)
     
     
    Show all issues
    Col: 25
     E241 multiple spaces after ':'
    
  14. reviewboard/scmtools/svn.py (Diff revision 1)
     
     
    Show all issues
    Col: 27
     E241 multiple spaces after ':'
    
  15. reviewboard/scmtools/svn.py (Diff revision 1)
     
     
    Show all issues
    Col: 15
     E241 multiple spaces after ':'
    
  16. reviewboard/scmtools/svn.py (Diff revision 1)
     
     
    Show all issues
    Col: 15
     E241 multiple spaces after ':'
    
  17. 
      
chipx86
  1. Ship It!

  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.7.x (08c5037)
Loading...