Fix unicode problems when processing errors from SVN.

Review Request #6196 — Created Aug. 4, 2014 and submitted

Information

Review Board
release-2.0.x
17e36f8...

Reviewers

When processing any errors that come out of the pysvn client, we would cast the
exception to unicode without specifying an encoding. This resulted in any utf-8
filenames or other text triggering a UnicodeDecodeError. I've changed this to
first coerce the exception to bytes, and then decode. While I was in here, I
also fixed up a duplicate cast.

Ran unit tests (this error handler is exercised in the tests).

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/scmtools/svn/pysvn.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/scmtools/svn/pysvn.py
    
    
  2. 
      
chipx86
  1. Ship It!

  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (6c7881f)
Loading...