Checklist options manager view
Review Request #6190 — Created Aug. 1, 2014 and discarded
| Information | |
|---|---|
| salam0smy | |
| rb-extension-pack | |
| Reviewers | |
| students | |
Created a page for checklist templates options.
Connected .less file styleing through TemplateHook.
Created basic structure for the page.
Added styling for the page.
Open [server]/checklist/manager/
The page gets loaded with the view, and its style.
| Description | From | Last Updated |
|---|---|---|
|
Can this be changed to checklist-manager to be consistent with your other ids? (hyphen instead of underscore) |
PE PeterTran | |
|
Overtabbed? |
PE PeterTran | |
|
Html elements should be in alphabetical order |
PE PeterTran | |
|
Is this a tab instead of space? |
PE PeterTran | |
|
Rules should be alphabetical order. I've noticed you use 1500 in several spots. If this ever needs to change, it … |
PE PeterTran | |
|
Tab instead of space? |
PE PeterTran | |
|
IDs should also be in alphabetical order. Move this up and slide #options-* below #mytemplates-list? |
PE PeterTran | |
|
Over tabbed? |
PE PeterTran | |
|
Tabs instead of spaces? |
PE PeterTran | |
|
The tabbing is not aligned here. |
PE PeterTran | |
|
The indentation is not flush. |
PE PeterTran | |
|
Trailing white space. |
PE PeterTran | |
|
Extra white space between class and id. |
PE PeterTran | |
|
Maybe put "Name:" on a new line for consistency with line 34? |
PE PeterTran | |
|
Col: 25 E127 continuation line over-indented for visual indent |
 reviewbot
|
|
|
Col: 1 E124 closing bracket does not match visual indentation |
reviewbot
|
PE
-
-
checklist/checklist/static/css/manager.less (Diff revision 1) Can this be changed to checklist-manager to be consistent with your other ids? (hyphen instead of underscore)
-
-
checklist/checklist/static/css/manager.less (Diff revision 1) Html elements should be in alphabetical order
-
-
checklist/checklist/static/css/manager.less (Diff revision 1) Rules should be alphabetical order.
I've noticed you use 1500 in several spots. If this ever needs to change, it might be convenient to store it in a variable?
-
-
checklist/checklist/static/css/manager.less (Diff revision 1) IDs should also be in alphabetical order. Move this up and slide #options-* below #mytemplates-list?
-
-
-
-
checklist/checklist/templates/checklist/manager.html (Diff revision 1) The indentation is not flush.
-
-
checklist/checklist/templates/checklist/manager.html (Diff revision 1) Extra white space between class and id.
-
checklist/checklist/templates/checklist/manager.html (Diff revision 1) Maybe put "Name:" on a new line for consistency with line 34?
SA
Change Summary:
Fixed indentation issues
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+198 -4) |
-
Tool: PEP8 Style Checker Processed Files: checklist/checklist/extension.py checklist/checklist/urls.py checklist/checklist/views.py Ignored Files: checklist/checklist/templates/checklist/manager.html checklist/checklist/static/css/manager.less checklist/checklist/templates/checklist/manager_style.html Tool: Pyflakes Processed Files: checklist/checklist/extension.py checklist/checklist/urls.py checklist/checklist/views.py Ignored Files: checklist/checklist/templates/checklist/manager.html checklist/checklist/static/css/manager.less checklist/checklist/templates/checklist/manager_style.html -
checklist/checklist/urls.py (Diff revision 2) Col: 25 E127 continuation line over-indented for visual indent
-
checklist/checklist/urls.py (Diff revision 2) Col: 1 E124 closing bracket does not match visual indentation
Tool: PEP8 Style Checker Processed Files: checklist/checklist/extension.py Ignored Files: checklist/checklist/templates/checklist/manager.html checklist/checklist/static/css/manager.less checklist/checklist/templates/checklist/manager_style.html Tool: Pyflakes Processed Files: checklist/checklist/extension.py Ignored Files: checklist/checklist/templates/checklist/manager.html checklist/checklist/static/css/manager.less checklist/checklist/templates/checklist/manager_style.html