Show buttons for all review request field editors.

Review Request #6179 — Created July 31, 2014 and submitted

Information

Review Board
release-2.0.x
e1cbb02...

Reviewers

Users were getting confused about how to save fields on the review
request page, since we removed the buttons in Review Board 2.0. This
change helps to solve that by adding back the buttons.

The fields on the side of the review request now have buttons once
again. Instead of taking up precious space on the field's line, they now
appear below the field instead.

The buttons are a bit smaller to help visually fit, and spacing is added
to help keep them from bumping up against neighboring fields. Any
fields below will simply shift down while the buttons are shown.

Clicked on all the fields, and saw buttons for each.


Description From Last Updated

Switch the order of these two rules.

daviddavid

You can just eliminate this line, since showing is the default.

daviddavid
chipx86
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/css/reviews.less
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/css/reviews.less
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
    
    
  2. 
      
david
  1. 
      
  2. reviewboard/static/rb/css/reviews.less (Diff revision 1)
     
     
     

    Switch the order of these two rules.

  3. You can just eliminate this line, since showing is the default.

  4. 
      
chipx86
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/css/reviews.less
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/css/reviews.less
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
    
    
  2. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (13d52e6)
Loading...