Summary

Show buttons for all review request field editors.

Review Request #6179 — Created July 31, 2014 and submitted July 31, 2014, 3:26 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.0.x

Bugs

3474

Depends On

Commit

e1cbb02...

Reviewers

Groups

reviewboard

People

Description

Users were getting confused about how to save fields on the review
request page, since we removed the buttons in Review Board 2.0. This
change helps to solve that by adding back the buttons.

The fields on the side of the review request now have buttons once
again. Instead of taking up precious space on the field's line, they now
appear below the field instead.

The buttons are a bit smaller to help visually fit, and spacing is added
to help keep them from bumping up against neighboring fields. Any
fields below will simply shift down while the buttons are shown.

Testing Done

Clicked on all the fields, and saw buttons for each.

Files

Issues

Description	From	Last Updated
Switch the order of these two rules.	david	July 31, 2014, 3:21 p.m.
You can just eliminate this line, since showing is the default.	david	July 31, 2014, 3:19 p.m.

Added Files:

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/css/reviews.less
    reviewboard/static/rb/js/views/reviewRequestEditorView.js



Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/css/reviews.less
    reviewboard/static/rb/js/views/reviewRequestEditorView.js

reviewboard/static/rb/css/reviews.less (Diff revision 1)
The issue has been resolved. Show all issues
```
Switch the order of these two rules.
```
reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 1)
The issue has been resolved. Show all issues
```
You can just eliminate this line, since showing is the default.
```

Change Summary:


Switched the order of two rules.
Removed the showButtons setting.

Commit:

36b0e7a26a5abf30fad5ab4285642cae739bef2f

e1cbb02a482bde48adb236b237dce749ecd7e86d

Diff:

Revision 2 (+10 -1)

Show changes

	reviewboard/static/rb/css/reviews.less
	reviewboard/static/rb/js/views/reviewRequestEditorView.js

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/css/reviews.less
    reviewboard/static/rb/js/views/reviewRequestEditorView.js



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/css/reviews.less
    reviewboard/static/rb/js/views/reviewRequestEditorView.js

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (13d52e6)