Set line-heights on the inline editor elements.

Review Request #6175 — Created July 31, 2014 and submitted

Information

Review Board
release-2.0.x
de35cbd...

Reviewers

The new fixes to inlineEditor requires that the consumers take the
responsibility of setting line-heights, in order to keep text from
jumping. This sets the appropriate line-heights for the general inline
editors and for the change description field.

Tested opening and closing the various editors. Didn't see any visual
glitches or shifting text.

Also tested manually hiding/showing just the edit icons. After this change,
I didn't see any issues.

reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/css/reviews.less
        reviewboard/static/rb/css/common.less
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/css/reviews.less
        reviewboard/static/rb/css/common.less
    
    
  2. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (1645c59)
Loading...