Use Math.ceil() when computing a modalbox's position.
Review Request #6162 — Created July 28, 2014 and submitted
Information | |
---|---|
chipx86 | |
Djblets | |
release-0.8.x | |
e95eb6f... | |
Reviewers | |
djblets | |
modalBox would listen for updates to the content within the box and
attempt to update its size and position accordingly. These values could
end up being non-integers, causing elements to subtly jump.To fix this, we just need to use Math.ceil() on the values to ensure
that we get whole numbers.
Saw this issue in a modalBox I had built. Some small updates would just
cause the box's contents to shift just a bit. That no longer happens
after this change.