Summary

Add a new close icon for admin widgets.

Review Request #6153 — Created July 27, 2014 and submitted July 28, 2014, 11:57 a.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

be349d6...

Reviewers

Groups

reviewboard

People

Description

This change adds a new close icon to use for admin widgets which matches the
style of the collapse/expand icons.

Testing Done

Loaded the admin dashboard and saw the new pretty.

Files

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/images/icons.png
    reviewboard/static/rb/images/icons.svg
    reviewboard/static/rb/images/icons@2x.png
    reviewboard/static/rb/css/assets/icons.less



Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/images/icons.png
    reviewboard/static/rb/images/icons.svg
    reviewboard/static/rb/images/icons@2x.png
    reviewboard/static/rb/css/assets/icons.less

admin-icons.png

The X feels a lot slimmer. How does the dash look if it's one pixel thinner?

david July 27, 2014, 5:42 p.m.

Diminutive. I played around with these and this seemed the best compromise. Either the dash disappears, or the X looks super fatty.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (c13e3a7)