• 
      

    Handle all errors when checking if a diff dedup is needed on upgrade.

    Review Request #6145 — Created July 25, 2014 and submitted — Latest diff uploaded

    Information

    Review Board
    release-2.0.x
    23ffcf6...

    Reviewers

    We were checking if an OperationalError was thrown when checking if a
    diff dedup was needed during upgrade. Turns out, ProgrammingError can
    also be thrown. We may find that more errors could be thrown in the
    future.

    We unit test that the unmigrated() function works, and Django's count()
    should always work. So, trusting that, we're now just catching all
    exceptions, instead of white-listing several exceptions. This will help
    protect from new errors in the future (depending on database), and
    ensure that the user will always be able to get through this (very
    unimportant) part of the upgrade process.

    Didn't do any testing, but this is pretty trivial.