Handle all errors when checking if a diff dedup is needed on upgrade.

Review Request #6145 — Created July 25, 2014 and submitted

Information

Review Board
release-2.0.x
23ffcf6...

Reviewers

We were checking if an OperationalError was thrown when checking if a
diff dedup was needed during upgrade. Turns out, ProgrammingError can
also be thrown. We may find that more errors could be thrown in the
future.

We unit test that the unmigrated() function works, and Django's count()
should always work. So, trusting that, we're now just catching all
exceptions, instead of white-listing several exceptions. This will help
protect from new errors in the future (depending on database), and
ensure that the user will always be able to get through this (very
unimportant) part of the upgrade process.

Didn't do any testing, but this is pretty trivial.

Description From Last Updated

'urllib2' imported but unused

reviewbotreviewbot

redefinition of unused 'show_get_more' from line 1571

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/cmdline/rbsite.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/cmdline/rbsite.py
    
    
  2. reviewboard/cmdline/rbsite.py (Diff revision 1)
     
     
    Show all issues
     'urllib2' imported but unused
    
  3. reviewboard/cmdline/rbsite.py (Diff revision 1)
     
     
    Show all issues
     redefinition of unused 'show_get_more' from line 1571
    
  4. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (c816421)
Loading...