Make "Update Diff" work like "New Review Request"
Review Request #6138 — Created July 23, 2014 and submitted
This change replaces the old "Update Diff" dialog with a new version that's
based on the pre-commit workflow from the "New Review Request" page. This makes
it so that the general case is as simple as selecting or drag-and-dropping a
diff file, and other questions (such as the basedir or parent diff) are only
asked if necessary.The PreCommitView from the New Review Request page has been generalized into
UploadDiffView, which both the PreCommitView and UpdateDiffView extend. For the
most part, the only difference between these are the specific templates that
are used, and the fact that the update dialog uses$.fn.modalDlgaround
this.$el.This eliminates one of our two remaining uses of
$.formDlgandgReviewRequest,
getting us that much closer to a clean javascript codebase.
- Went through all the old scenarios with the "New Review Request" page to test
for regressions. - Updated a diff on a review request and saw the resulting change.
- Updated a diff on a review request that required a parent diff, specified
that parent diff, and saw the resulting change. - Tried to update a diff on a review request with a patch file that had short
revs for git and saw the appropriate error. - Updated a diff on a review request using an svn repository and was prompted
for the base directory.
| Description | From | Last Updated |
|---|---|---|
|
Space after switch. |
 chipx86
|
|
|
Should have a break; after, just to keep issues from popping up down the road. |
chipx86
|
|
|
<tt> is more appropriate than <code> here. |
chipx86
|
|
|
We should move this file if it's no longer specific to the New Review Request page. |
chipx86
|
|
|
Can these go in alphabetical order? |
chipx86
|
-
Nice :)
-
reviewboard/static/rb/js/newReviewRequest/models/preCommitModel.js (Diff revision 1) Space after switch.
-
reviewboard/static/rb/js/newReviewRequest/models/preCommitModel.js (Diff revision 1) Should have a
break;after, just to keep issues from popping up down the road. -
reviewboard/static/rb/js/views/uploadDiffView.js (Diff revision 1) <tt>is more appropriate than<code>here. -
reviewboard/staticbundles.py (Diff revision 1) We should move this file if it's no longer specific to the New Review Request page.
-
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+400 -253) |
-
Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/newReviewRequest/views/newReviewRequestView.js reviewboard/static/rb/js/views/updateDiffView.js reviewboard/static/rb/js/models/uploadDiffModel.js reviewboard/templates/reviews/reviewable_page_data.js reviewboard/static/rb/js/views/reviewRequestEditorView.js reviewboard/static/rb/js/newReviewRequest/views/preCommitView.js reviewboard/static/rb/js/views/uploadDiffView.js reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_request_dlgs.html Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/newReviewRequest/views/newReviewRequestView.js reviewboard/static/rb/js/views/updateDiffView.js reviewboard/static/rb/js/models/uploadDiffModel.js reviewboard/templates/reviews/reviewable_page_data.js reviewboard/static/rb/js/views/reviewRequestEditorView.js reviewboard/static/rb/js/newReviewRequest/views/preCommitView.js reviewboard/static/rb/js/views/uploadDiffView.js reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_request_dlgs.html
Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/newReviewRequest/models/preCommitModel.js reviewboard/templates/reviews/reviewable_page_data.js reviewboard/static/rb/js/views/reviewRequestEditorView.js reviewboard/static/rb/js/newReviewRequest/views/preCommitView.js reviewboard/static/rb/js/views/uploadDiffView.js reviewboard/static/rb/css/pages/reviews.less reviewboard/static/rb/js/views/updateDiffView.js reviewboard/templates/reviews/review_request_dlgs.html Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/newReviewRequest/models/preCommitModel.js reviewboard/templates/reviews/reviewable_page_data.js reviewboard/static/rb/js/views/reviewRequestEditorView.js reviewboard/static/rb/js/newReviewRequest/views/preCommitView.js reviewboard/static/rb/js/views/uploadDiffView.js reviewboard/static/rb/css/pages/reviews.less reviewboard/static/rb/js/views/updateDiffView.js reviewboard/templates/reviews/review_request_dlgs.html