Fix "No Summary" in dashboard with draft summaries.

Review Request #6136 — Created July 23, 2014 and submitted

Information

Review Board
release-2.0.x
808f17a...

Reviewers

The code in the dashboard that put in the italic "No Summary" for review
requests that had blank summaries wasn't ordered quite right, which meant that
if there was a draft with an empty summary present, the summary field would be
empty, but if it was merely a non-public review request, the summary field
would say "No Summary".

This change re-orders things to always override the displayed summary, whether
or not there's a draft.

Saw that my devserver with a bunch of draft/un-published review requests no
longer showed two different things based on the presence of a draft.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/datagrids/columns.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/datagrids/columns.py
    
    
  2. 
      
chipx86
  1. Ship It!

  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (a7c8af0)
Loading...