-
-
checklist/checklist/extension.py (Diff revision 1) Col: 13 E128 continuation line under-indented for visual indent
-
checklist/checklist/urls.py (Diff revision 1) Col: 5 E128 continuation line under-indented for visual indent
-
Added URLHook to Checklist Extension Options page
Review Request #6135 — Created July 23, 2014 and discarded
| Information | |
|---|---|
| salam0smy | |
| rb-extension-pack | |
| Reviewers | |
| students | |
Defined a new file, urls.py, to take care of url patterns. Also, Added a URLHook using the urlPattern.
Added a statement to register templates resource to its model.
Created manager.html, and connected it in views.py
opened the link [server]/checklist/manager/
The server serves the empty page 'manager.html' with its Title
| Description | From | Last Updated |
|---|---|---|
|
No need for parens, since this doesn't span multiple lines. |
 chipx86
|
|
|
The urlpatterns line needs to have arguments properly lined up, like: urlpatterns = patterns( '', url(...), ) You probably just … |
chipx86
|
|
|
Col: 13 E128 continuation line under-indented for visual indent |
 reviewbot
|
|
|
Please put the 'checklist.views' on the next line, with a blank line separating it and the url(). You should also … |
chipx86
|
|
|
Col: 5 E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
Col: 2 W292 no newline at end of file |
reviewbot
|
|
|
Col: 22 W291 trailing whitespace |
reviewbot
|
|
|
Col: 17 E124 closing bracket does not match visual indentation |
reviewbot
|
|
|
Col: 5 E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
Col: 17 E124 closing bracket does not match visual indentation |
reviewbot
|
|
|
Col: 5 E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
Col: 5 E101 indentation contains mixed spaces and tabs |
reviewbot
|
|
|
Col: 5 W191 indentation contains tabs |
reviewbot
|
|
|
Col: 10 E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
Col: 5 E101 indentation contains mixed spaces and tabs |
reviewbot
|
|
|
Col: 5 W191 indentation contains tabs |
reviewbot
|
|
|
Col: 11 E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
Col: 32 E127 continuation line over-indented for visual indent |
reviewbot
|
|
|
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
Col: 1 E101 indentation contains mixed spaces and tabs |
reviewbot
|
|
|
Col: 1 W191 indentation contains tabs |
reviewbot
|
|
|
Col: 1 W191 indentation contains tabs |
reviewbot
|
|
|
Col: 1 W191 indentation contains tabs |
reviewbot
|
|
|
Col: 1 W191 indentation contains tabs |
reviewbot
|
|
|
Col: 7 E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
Col: 1 W191 indentation contains tabs |
reviewbot
|
|
|
Col: 8 E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
'redirect' imported but unused |
reviewbot
|
|
|
'get_object_or_404' imported but unused |
reviewbot
|
|
|
'render' imported but unused |
reviewbot
|
|
|
'get_list_or_404' imported but unused |
reviewbot
|
|
|
Col: 32 E127 continuation line over-indented for visual indent |
reviewbot
|
|
|
While you're here, can you fix the alignment? register_resource_for_model should be aligned with unregister_resource_for_model. |
 anselina
|
|
|
Can you add a blank line before this? |
anselina
|
|
|
ChecklistTemplate should go before ReviewChecklist, and no parens are needed since they fit on one line. |
anselina
|
|
|
Col: 1 W191 indentation contains tabs |
reviewbot
|
|
|
Col: 7 E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
Col: 1 W191 indentation contains tabs |
reviewbot
|
|
|
Col: 8 E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
'redirect' imported but unused |
reviewbot
|
|
|
'get_object_or_404' imported but unused |
reviewbot
|
|
|
'render' imported but unused |
reviewbot
|
|
|
'get_list_or_404' imported but unused |
reviewbot
|
|
|
Col: 32 E127 continuation line over-indented for visual indent |
reviewbot
|
|
|
Is this returned line over indented? |
PE PeterTran | |
|
Col: 25 E127 continuation line over-indented for visual indent |
reviewbot
|
|
|
Col: 1 E124 closing bracket does not match visual indentation |
reviewbot
|
-
-
checklist/checklist/extension.py (Diff revision 1) No need for parens, since this doesn't span multiple lines.
-
checklist/checklist/extension.py (Diff revision 1) The urlpatterns line needs to have arguments properly lined up, like:
urlpatterns = patterns( '', url(...), )You probably just want to pass these values directly into
URLHookinstead of creating a variable, though. -
checklist/checklist/urls.py (Diff revision 1) Please put the
'checklist.views'on the next line, with a blank line separating it and theurl().You should also have a comma after the
url()line. That makes it easier to add additional entries without changing existing lines.
SA
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+11 -1) |
-
Tool: Pyflakes Processed Files: checklist/checklist/extension.py checklist/checklist/urls.py Tool: PEP8 Style Checker Processed Files: checklist/checklist/extension.py checklist/checklist/urls.py -
-
checklist/checklist/extension.py (Diff revision 2) Col: 17 E124 closing bracket does not match visual indentation
-
checklist/checklist/urls.py (Diff revision 2) Col: 5 E128 continuation line under-indented for visual indent
SA
Change Summary:
Register checklist templates resource to its model
Description: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
|||||||||
Diff: |
Revision 3 (+17 -3) |
-
Tool: Pyflakes Processed Files: checklist/checklist/extension.py checklist/checklist/urls.py Tool: PEP8 Style Checker Processed Files: checklist/checklist/extension.py checklist/checklist/urls.py -
checklist/checklist/extension.py (Diff revision 3) Col: 17 E124 closing bracket does not match visual indentation
-
checklist/checklist/urls.py (Diff revision 3) Col: 5 E128 continuation line under-indented for visual indent
SA
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+27 -3) |
-
Tool: PEP8 Style Checker Processed Files: checklist/checklist/extension.py checklist/checklist/urls.py checklist/checklist/view.py -
checklist/checklist/urls.py (Diff revision 4) Col: 5 E101 indentation contains mixed spaces and tabs
-
-
checklist/checklist/urls.py (Diff revision 4) Col: 10 E128 continuation line under-indented for visual indent
-
checklist/checklist/urls.py (Diff revision 4) Col: 5 E101 indentation contains mixed spaces and tabs
-
-
checklist/checklist/urls.py (Diff revision 4) Col: 11 E128 continuation line under-indented for visual indent
-
checklist/checklist/view.py (Diff revision 4) Col: 32 E127 continuation line over-indented for visual indent
-
-
checklist/checklist/view.py (Diff revision 4) Col: 1 E101 indentation contains mixed spaces and tabs
-
-
-
SA
Change Summary:
Renamed view.py to views.py, changes url to map to "checklist/manager/", fixed styling and format.
Summary: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
|||||||||
Commit: |
|
|||||||||
Diff: |
Revision 5 (+28 -3) |
-
Tool: PEP8 Style Checker Processed Files: checklist/checklist/extension.py checklist/checklist/urls.py checklist/checklist/views.py Tool: Pyflakes Processed Files: checklist/checklist/extension.py checklist/checklist/urls.py checklist/checklist/views.py -
-
checklist/checklist/urls.py (Diff revision 5) Col: 7 E128 continuation line under-indented for visual indent
-
-
checklist/checklist/urls.py (Diff revision 5) Col: 8 E128 continuation line under-indented for visual indent
-
-
-
-
-
checklist/checklist/views.py (Diff revision 5) Col: 32 E127 continuation line over-indented for visual indent
-
Tool: PEP8 Style Checker Processed Files: checklist/checklist/extension.py checklist/checklist/urls.py checklist/checklist/views.py Tool: Pyflakes Processed Files: checklist/checklist/extension.py checklist/checklist/urls.py checklist/checklist/views.py -
-
checklist/checklist/urls.py (Diff revision 6) Col: 7 E128 continuation line under-indented for visual indent
-
-
checklist/checklist/urls.py (Diff revision 6) Col: 8 E128 continuation line under-indented for visual indent
-
-
-
-
-
checklist/checklist/views.py (Diff revision 6) Col: 32 E127 continuation line over-indented for visual indent
-
-
checklist/checklist/extension.py (Diff revision 6) While you're here, can you fix the alignment? register_resource_for_model should be aligned with unregister_resource_for_model.
-
-
checklist/checklist/extension.py (Diff revision 6) ChecklistTemplate should go before ReviewChecklist, and no parens are needed since they fit on one line.
SA
Change Summary:
Fixed indentation, and other format.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 7 (+29 -4) |
-
Tool: PEP8 Style Checker Processed Files: checklist/checklist/extension.py checklist/checklist/urls.py checklist/checklist/views.py Tool: Pyflakes Processed Files: checklist/checklist/extension.py checklist/checklist/urls.py checklist/checklist/views.py -
checklist/checklist/urls.py (Diff revision 7) Col: 25 E127 continuation line over-indented for visual indent
-
checklist/checklist/urls.py (Diff revision 7) Col: 1 E124 closing bracket does not match visual indentation
Tool: Pyflakes Processed Files: checklist/checklist/extension.py checklist/checklist/urls.py Tool: PEP8 Style Checker Processed Files: checklist/checklist/extension.py checklist/checklist/urls.py