Added URLHook to Checklist Extension Options page

Review Request #6135 — Created July 23, 2014 and discarded

Information

rb-extension-pack

Reviewers

Defined a new file, urls.py, to take care of url patterns. Also, Added a URLHook using the urlPattern.
Added a statement to register templates resource to its model.

Created manager.html, and connected it in views.py
opened the link [server]/checklist/manager/
The server serves the empty page 'manager.html' with its Title

Description From Last Updated

No need for parens, since this doesn't span multiple lines.

chipx86chipx86

The urlpatterns line needs to have arguments properly lined up, like: urlpatterns = patterns( '', url(...), ) You probably just …

chipx86chipx86

Col: 13 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Please put the 'checklist.views' on the next line, with a blank line separating it and the url(). You should also …

chipx86chipx86

Col: 5 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 2 W292 no newline at end of file

reviewbotreviewbot

Col: 22 W291 trailing whitespace

reviewbotreviewbot

Col: 17 E124 closing bracket does not match visual indentation

reviewbotreviewbot

Col: 5 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 17 E124 closing bracket does not match visual indentation

reviewbotreviewbot

Col: 5 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 5 E101 indentation contains mixed spaces and tabs

reviewbotreviewbot

Col: 5 W191 indentation contains tabs

reviewbotreviewbot

Col: 10 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 5 E101 indentation contains mixed spaces and tabs

reviewbotreviewbot

Col: 5 W191 indentation contains tabs

reviewbotreviewbot

Col: 11 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 32 E127 continuation line over-indented for visual indent

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

Col: 1 E101 indentation contains mixed spaces and tabs

reviewbotreviewbot

Col: 1 W191 indentation contains tabs

reviewbotreviewbot

Col: 1 W191 indentation contains tabs

reviewbotreviewbot

Col: 1 W191 indentation contains tabs

reviewbotreviewbot

Col: 1 W191 indentation contains tabs

reviewbotreviewbot

Col: 7 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 W191 indentation contains tabs

reviewbotreviewbot

Col: 8 E128 continuation line under-indented for visual indent

reviewbotreviewbot

'redirect' imported but unused

reviewbotreviewbot

'get_object_or_404' imported but unused

reviewbotreviewbot

'render' imported but unused

reviewbotreviewbot

'get_list_or_404' imported but unused

reviewbotreviewbot

Col: 32 E127 continuation line over-indented for visual indent

reviewbotreviewbot

While you're here, can you fix the alignment? register_resource_for_model should be aligned with unregister_resource_for_model.

anselinaanselina

Can you add a blank line before this?

anselinaanselina

ChecklistTemplate should go before ReviewChecklist, and no parens are needed since they fit on one line.

anselinaanselina

Col: 1 W191 indentation contains tabs

reviewbotreviewbot

Col: 7 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 W191 indentation contains tabs

reviewbotreviewbot

Col: 8 E128 continuation line under-indented for visual indent

reviewbotreviewbot

'redirect' imported but unused

reviewbotreviewbot

'get_object_or_404' imported but unused

reviewbotreviewbot

'render' imported but unused

reviewbotreviewbot

'get_list_or_404' imported but unused

reviewbotreviewbot

Col: 32 E127 continuation line over-indented for visual indent

reviewbotreviewbot

Is this returned line over indented?

PE PeterTran

Col: 25 E127 continuation line over-indented for visual indent

reviewbotreviewbot

Col: 1 E124 closing bracket does not match visual indentation

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        checklist/checklist/extension.py
        checklist/checklist/urls.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        checklist/checklist/extension.py
        checklist/checklist/urls.py
    
    
  2. checklist/checklist/extension.py (Diff revision 1)
     
     
    Show all issues
    Col: 13
     E128 continuation line under-indented for visual indent
    
  3. checklist/checklist/urls.py (Diff revision 1)
     
     
    Show all issues
    Col: 5
     E128 continuation line under-indented for visual indent
    
  4. checklist/checklist/urls.py (Diff revision 1)
     
     
    Show all issues
    Col: 2
     W292 no newline at end of file
    
  5. 
      
chipx86
  1. 
      
  2. checklist/checklist/extension.py (Diff revision 1)
     
     
    Show all issues

    No need for parens, since this doesn't span multiple lines.

  3. checklist/checklist/extension.py (Diff revision 1)
     
     
     
     
    Show all issues

    The urlpatterns line needs to have arguments properly lined up, like:

    urlpatterns = patterns(
        '',
    
        url(...),
    )
    

    You probably just want to pass these values directly into URLHook instead of creating a variable, though.

  4. checklist/checklist/urls.py (Diff revision 1)
     
     
    Show all issues

    Please put the 'checklist.views' on the next line, with a blank line separating it and the url().

    You should also have a comma after the url() line. That makes it easier to add additional entries without changing existing lines.

  5. 
      
SA
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        checklist/checklist/extension.py
        checklist/checklist/urls.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        checklist/checklist/extension.py
        checklist/checklist/urls.py
    
    
  2. checklist/checklist/extension.py (Diff revision 2)
     
     
    Show all issues
    Col: 22
     W291 trailing whitespace
    
  3. checklist/checklist/extension.py (Diff revision 2)
     
     
    Show all issues
    Col: 17
     E124 closing bracket does not match visual indentation
    
  4. checklist/checklist/urls.py (Diff revision 2)
     
     
    Show all issues
    Col: 5
     E128 continuation line under-indented for visual indent
    
  5. 
      
SA
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        checklist/checklist/extension.py
        checklist/checklist/urls.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        checklist/checklist/extension.py
        checklist/checklist/urls.py
    
    
  2. checklist/checklist/extension.py (Diff revision 3)
     
     
    Show all issues
    Col: 17
     E124 closing bracket does not match visual indentation
    
  3. checklist/checklist/urls.py (Diff revision 3)
     
     
    Show all issues
    Col: 5
     E128 continuation line under-indented for visual indent
    
  4. 
      
SA
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        checklist/checklist/extension.py
        checklist/checklist/urls.py
        checklist/checklist/view.py
    
    
  2. checklist/checklist/urls.py (Diff revision 4)
     
     
    Show all issues
    Col: 5
     E101 indentation contains mixed spaces and tabs
    
  3. checklist/checklist/urls.py (Diff revision 4)
     
     
    Show all issues
    Col: 5
     W191 indentation contains tabs
    
  4. checklist/checklist/urls.py (Diff revision 4)
     
     
    Show all issues
    Col: 10
     E128 continuation line under-indented for visual indent
    
  5. checklist/checklist/urls.py (Diff revision 4)
     
     
    Show all issues
    Col: 5
     E101 indentation contains mixed spaces and tabs
    
  6. checklist/checklist/urls.py (Diff revision 4)
     
     
    Show all issues
    Col: 5
     W191 indentation contains tabs
    
  7. checklist/checklist/urls.py (Diff revision 4)
     
     
    Show all issues
    Col: 11
     E128 continuation line under-indented for visual indent
    
  8. checklist/checklist/view.py (Diff revision 4)
     
     
    Show all issues
    Col: 32
     E127 continuation line over-indented for visual indent
    
  9. checklist/checklist/view.py (Diff revision 4)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  10. checklist/checklist/view.py (Diff revision 4)
     
     
    Show all issues
    Col: 1
     E101 indentation contains mixed spaces and tabs
    
  11. checklist/checklist/view.py (Diff revision 4)
     
     
    Show all issues
    Col: 1
     W191 indentation contains tabs
    
  12. checklist/checklist/view.py (Diff revision 4)
     
     
    Show all issues
    Col: 1
     W191 indentation contains tabs
    
  13. checklist/checklist/view.py (Diff revision 4)
     
     
    Show all issues
    Col: 1
     W191 indentation contains tabs
    
  14. 
      
SA
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        checklist/checklist/extension.py
        checklist/checklist/urls.py
        checklist/checklist/views.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        checklist/checklist/extension.py
        checklist/checklist/urls.py
        checklist/checklist/views.py
    
    
  2. checklist/checklist/urls.py (Diff revision 5)
     
     
    Show all issues
    Col: 1
     W191 indentation contains tabs
    
  3. checklist/checklist/urls.py (Diff revision 5)
     
     
    Show all issues
    Col: 7
     E128 continuation line under-indented for visual indent
    
  4. checklist/checklist/urls.py (Diff revision 5)
     
     
    Show all issues
    Col: 1
     W191 indentation contains tabs
    
  5. checklist/checklist/urls.py (Diff revision 5)
     
     
    Show all issues
    Col: 8
     E128 continuation line under-indented for visual indent
    
  6. checklist/checklist/views.py (Diff revision 5)
     
     
    Show all issues
     'redirect' imported but unused
    
  7. checklist/checklist/views.py (Diff revision 5)
     
     
    Show all issues
     'get_object_or_404' imported but unused
    
  8. checklist/checklist/views.py (Diff revision 5)
     
     
    Show all issues
     'render' imported but unused
    
  9. checklist/checklist/views.py (Diff revision 5)
     
     
    Show all issues
     'get_list_or_404' imported but unused
    
  10. checklist/checklist/views.py (Diff revision 5)
     
     
    Show all issues
    Col: 32
     E127 continuation line over-indented for visual indent
    
  11. 
      
SA
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        checklist/checklist/extension.py
        checklist/checklist/urls.py
        checklist/checklist/views.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        checklist/checklist/extension.py
        checklist/checklist/urls.py
        checklist/checklist/views.py
    
    
  2. checklist/checklist/urls.py (Diff revision 6)
     
     
    Show all issues
    Col: 1
     W191 indentation contains tabs
    
  3. checklist/checklist/urls.py (Diff revision 6)
     
     
    Show all issues
    Col: 7
     E128 continuation line under-indented for visual indent
    
  4. checklist/checklist/urls.py (Diff revision 6)
     
     
    Show all issues
    Col: 1
     W191 indentation contains tabs
    
  5. checklist/checklist/urls.py (Diff revision 6)
     
     
    Show all issues
    Col: 8
     E128 continuation line under-indented for visual indent
    
  6. checklist/checklist/views.py (Diff revision 6)
     
     
    Show all issues
     'redirect' imported but unused
    
  7. checklist/checklist/views.py (Diff revision 6)
     
     
    Show all issues
     'get_object_or_404' imported but unused
    
  8. checklist/checklist/views.py (Diff revision 6)
     
     
    Show all issues
     'render' imported but unused
    
  9. checklist/checklist/views.py (Diff revision 6)
     
     
    Show all issues
     'get_list_or_404' imported but unused
    
  10. checklist/checklist/views.py (Diff revision 6)
     
     
    Show all issues
    Col: 32
     E127 continuation line over-indented for visual indent
    
  11. 
      
PE
  1. 
      
  2. checklist/checklist/views.py (Diff revision 6)
     
     
    Show all issues

    Is this returned line over indented?

  3. 
      
anselina
  1. 
      
  2. checklist/checklist/extension.py (Diff revision 6)
     
     
    Show all issues

    While you're here, can you fix the alignment? register_resource_for_model should be aligned with unregister_resource_for_model.

  3. checklist/checklist/extension.py (Diff revision 6)
     
     
    Show all issues

    Can you add a blank line before this?

  4. checklist/checklist/extension.py (Diff revision 6)
     
     
    Show all issues

    ChecklistTemplate should go before ReviewChecklist, and no parens are needed since they fit on one line.

  5. 
      
SA
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        checklist/checklist/extension.py
        checklist/checklist/urls.py
        checklist/checklist/views.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        checklist/checklist/extension.py
        checklist/checklist/urls.py
        checklist/checklist/views.py
    
    
  2. checklist/checklist/urls.py (Diff revision 7)
     
     
    Show all issues
    Col: 25
     E127 continuation line over-indented for visual indent
    
  3. checklist/checklist/urls.py (Diff revision 7)
     
     
    Show all issues
    Col: 1
     E124 closing bracket does not match visual indentation
    
  4. 
      
SA
Review request changed
Status:
Discarded