Summary

Added URLHook to Checklist Extension Options page

Review Request #6135 — Created July 23, 2014 and discarded Dec. 10, 2014, 4:54 p.m.

Information

Owner

salam0smy

Repository

rb-extension-pack

Branch

Bugs

Depends On

Reviewers

Groups

students

People

Description

Defined a new file, urls.py, to take care of url patterns. Also, Added a URLHook using the urlPattern.
Added a statement to register templates resource to its model.

Testing Done

Created manager.html, and connected it in views.py
opened the link [server]/checklist/manager/
The server serves the empty page 'manager.html' with its Title

Issues

Description	From	Last Updated
No need for parens, since this doesn't span multiple lines.	chipx86	July 23, 2014, 2:12 p.m.
The urlpatterns line needs to have arguments properly lined up, like: urlpatterns = patterns( '', url(...), ) You probably just …	chipx86	July 23, 2014, 2:12 p.m.
Col: 13 E128 continuation line under-indented for visual indent	reviewbot	Aug. 4, 2014, 7:55 p.m.
Please put the 'checklist.views' on the next line, with a blank line separating it and the url(). You should also …	chipx86	July 23, 2014, 2:12 p.m.
Col: 5 E128 continuation line under-indented for visual indent	reviewbot	Aug. 4, 2014, 7:55 p.m.
Col: 2 W292 no newline at end of file	reviewbot	July 23, 2014, 2:12 p.m.
Col: 22 W291 trailing whitespace	reviewbot	July 24, 2014, 4:56 p.m.
Col: 17 E124 closing bracket does not match visual indentation	reviewbot	Aug. 4, 2014, 7:44 p.m.
Col: 5 E128 continuation line under-indented for visual indent	reviewbot	Aug. 4, 2014, 7:44 p.m.
Col: 17 E124 closing bracket does not match visual indentation	reviewbot	July 27, 2014, 1:55 p.m.
Col: 5 E128 continuation line under-indented for visual indent	reviewbot	July 27, 2014, 1:55 p.m.
Col: 5 E101 indentation contains mixed spaces and tabs	reviewbot	July 31, 2014, 11:13 a.m.
Col: 5 W191 indentation contains tabs	reviewbot	July 31, 2014, 11:13 a.m.
Col: 10 E128 continuation line under-indented for visual indent	reviewbot	July 31, 2014, 11:13 a.m.
Col: 5 E101 indentation contains mixed spaces and tabs	reviewbot	July 31, 2014, 11:13 a.m.
Col: 5 W191 indentation contains tabs	reviewbot	July 31, 2014, 11:13 a.m.
Col: 11 E128 continuation line under-indented for visual indent	reviewbot	July 31, 2014, 11:13 a.m.
Col: 32 E127 continuation line over-indented for visual indent	reviewbot	July 31, 2014, 11:13 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	July 31, 2014, 11:08 a.m.
Col: 1 E101 indentation contains mixed spaces and tabs	reviewbot	July 31, 2014, 11:13 a.m.
Col: 1 W191 indentation contains tabs	reviewbot	July 31, 2014, 11:13 a.m.
Col: 1 W191 indentation contains tabs	reviewbot	July 31, 2014, 11:13 a.m.
Col: 1 W191 indentation contains tabs	reviewbot	July 31, 2014, 11:13 a.m.
Col: 1 W191 indentation contains tabs	reviewbot	Aug. 4, 2014, 7:44 p.m.
Col: 7 E128 continuation line under-indented for visual indent	reviewbot	Aug. 4, 2014, 7:44 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Aug. 4, 2014, 7:44 p.m.
Col: 8 E128 continuation line under-indented for visual indent	reviewbot	Aug. 4, 2014, 7:44 p.m.
'redirect' imported but unused	reviewbot	Aug. 4, 2014, 7:44 p.m.
'get_object_or_404' imported but unused	reviewbot	Aug. 4, 2014, 7:45 p.m.
'render' imported but unused	reviewbot	Aug. 4, 2014, 7:45 p.m.
'get_list_or_404' imported but unused	reviewbot	Aug. 4, 2014, 7:45 p.m.
Col: 32 E127 continuation line over-indented for visual indent	reviewbot	Aug. 4, 2014, 7:45 p.m.
While you're here, can you fix the alignment? register_resource_for_model should be aligned with unregister_resource_for_model.	anselina	Aug. 4, 2014, 7:38 p.m.
Can you add a blank line before this?	anselina	Aug. 4, 2014, 7:38 p.m.
ChecklistTemplate should go before ReviewChecklist, and no parens are needed since they fit on one line.	anselina	Aug. 4, 2014, 7:39 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Aug. 4, 2014, 7:34 p.m.
Col: 7 E128 continuation line under-indented for visual indent	reviewbot	Aug. 4, 2014, 7:35 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Aug. 4, 2014, 7:35 p.m.
Col: 8 E128 continuation line under-indented for visual indent	reviewbot	Aug. 4, 2014, 7:35 p.m.
'redirect' imported but unused	reviewbot	Aug. 4, 2014, 7:35 p.m.
'get_object_or_404' imported but unused	reviewbot	Aug. 4, 2014, 7:36 p.m.
'render' imported but unused	reviewbot	Aug. 4, 2014, 7:36 p.m.
'get_list_or_404' imported but unused	reviewbot	Aug. 4, 2014, 7:36 p.m.
Col: 32 E127 continuation line over-indented for visual indent	reviewbot	Aug. 4, 2014, 7:36 p.m.
Is this returned line over indented?	PE PeterTran	Aug. 4, 2014, 7:45 p.m.
Col: 25 E127 continuation line over-indented for visual indent	reviewbot	Aug. 4, 2014, 7:41 p.m.
Col: 1 E124 closing bracket does not match visual indentation	reviewbot	Aug. 4, 2014, 7:41 p.m.

Tool: Pyflakes
Processed Files:
    checklist/checklist/extension.py
    checklist/checklist/urls.py



Tool: PEP8 Style Checker
Processed Files:
    checklist/checklist/extension.py
    checklist/checklist/urls.py

checklist/checklist/extension.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 13
 E128 continuation line under-indented for visual indent
```
checklist/checklist/urls.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 5
 E128 continuation line under-indented for visual indent
```
checklist/checklist/urls.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 2
 W292 no newline at end of file
```

checklist/checklist/extension.py (Diff revision 1)
The issue has been resolved. Show all issues
```
No need for parens, since this doesn't span multiple lines.
```

checklist/checklist/extension.py (Diff revision 1)

The issue has been resolved. Show all issues

The urlpatterns line needs to have arguments properly lined up, like:

urlpatterns = patterns(
    '',

    url(...),
)

You probably just want to pass these values directly into URLHook instead of creating a variable, though.

checklist/checklist/urls.py (Diff revision 1)

The issue has been resolved. Show all issues

Please put the 'checklist.views' on the next line, with a blank line separating it and the url().

You should also have a comma after the url() line. That makes it easier to add additional entries without changing existing lines.

Commit:

75e5dc1bb15d72e768701aa0bcc43dccac886bd1

df6180253c3fffbf0abc1498b73d3cac336d918a

Diff:

Revision 2 (+11 -1)

Show changes

	checklist/checklist/extension.py
	checklist/checklist/urls.py

Tool: Pyflakes
Processed Files:
    checklist/checklist/extension.py
    checklist/checklist/urls.py



Tool: PEP8 Style Checker
Processed Files:
    checklist/checklist/extension.py
    checklist/checklist/urls.py

checklist/checklist/extension.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 22
 W291 trailing whitespace
```
checklist/checklist/extension.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 17
 E124 closing bracket does not match visual indentation
```
checklist/checklist/urls.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 5
 E128 continuation line under-indented for visual indent
```

Change Summary:

Description:

~		Defined a new file, urls.py, to take care of url patterns. Also, Added a URLHook using the urlPattern.
	~	Defined a new file, urls.py, to take care of url patterns. Also, Added a URLHook using the urlPattern.
	+	Added a statement to register templates resource to its model.

Commit:

df6180253c3fffbf0abc1498b73d3cac336d918a

a3bfb3765050a44769f93a52d1dd40168391b524

Diff:

Revision 3 (+17 -3)

Show changes

	checklist/checklist/extension.py
	checklist/checklist/urls.py

Tool: Pyflakes
Processed Files:
    checklist/checklist/extension.py
    checklist/checklist/urls.py



Tool: PEP8 Style Checker
Processed Files:
    checklist/checklist/extension.py
    checklist/checklist/urls.py

checklist/checklist/extension.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 17
 E124 closing bracket does not match visual indentation
```
checklist/checklist/urls.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 5
 E128 continuation line under-indented for visual indent
```

Commit:

a3bfb3765050a44769f93a52d1dd40168391b524

48c013f596b2f87c0fefb3e801a0f5389054c105

Diff:

Revision 4 (+27 -3)

Show changes

	checklist/checklist/extension.py
	checklist/checklist/urls.py
	checklist/checklist/view.py

Tool: PEP8 Style Checker
Processed Files:
    checklist/checklist/extension.py
    checklist/checklist/urls.py
    checklist/checklist/view.py

checklist/checklist/urls.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 5
 E101 indentation contains mixed spaces and tabs
```
checklist/checklist/urls.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 5
 W191 indentation contains tabs
```
checklist/checklist/urls.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 10
 E128 continuation line under-indented for visual indent
```
checklist/checklist/urls.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 5
 E101 indentation contains mixed spaces and tabs
```
checklist/checklist/urls.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 5
 W191 indentation contains tabs
```
checklist/checklist/urls.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 11
 E128 continuation line under-indented for visual indent
```
checklist/checklist/view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 32
 E127 continuation line over-indented for visual indent
```
checklist/checklist/view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
checklist/checklist/view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 1
 E101 indentation contains mixed spaces and tabs
```
checklist/checklist/view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
checklist/checklist/view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
checklist/checklist/view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```

Change Summary:

Renamed view.py to views.py, changes url to map to "checklist/manager/", fixed styling and format.

Summary:

[WIP] Added URLHook to Checklist Extension Options page

Added URLHook to Checklist Extension Options page

Testing Done:

	+	Created manager.html, and connected it in views.py
	+	opened the link [server]/checklist/manager/
	+	The server serves the empty page 'manager.html' with its Title

Commit:

48c013f596b2f87c0fefb3e801a0f5389054c105

32a7f6e9cabf7f392ef3f1df48156d8688f186dd

Diff:

Revision 5 (+28 -3)

Show changes

	checklist/checklist/extension.py
	checklist/checklist/urls.py
	checklist/checklist/views.py

Tool: PEP8 Style Checker
Processed Files:
    checklist/checklist/extension.py
    checklist/checklist/urls.py
    checklist/checklist/views.py



Tool: Pyflakes
Processed Files:
    checklist/checklist/extension.py
    checklist/checklist/urls.py
    checklist/checklist/views.py

checklist/checklist/urls.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
checklist/checklist/urls.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Col: 7
 E128 continuation line under-indented for visual indent
```
checklist/checklist/urls.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
checklist/checklist/urls.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Col: 8
 E128 continuation line under-indented for visual indent
```
checklist/checklist/views.py (Diff revision 5)
The issue has been resolved. Show all issues
```
 'redirect' imported but unused
```
checklist/checklist/views.py (Diff revision 5)
The issue has been resolved. Show all issues
```
 'get_object_or_404' imported but unused
```
checklist/checklist/views.py (Diff revision 5)
The issue has been resolved. Show all issues
```
 'render' imported but unused
```
checklist/checklist/views.py (Diff revision 5)
The issue has been resolved. Show all issues
```
 'get_list_or_404' imported but unused
```
checklist/checklist/views.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Col: 32
 E127 continuation line over-indented for visual indent
```

Diff:

Revision 6 (+28 -3)

Show changes

	checklist/checklist/extension.py
	checklist/checklist/urls.py
	checklist/checklist/views.py

Tool: PEP8 Style Checker
Processed Files:
    checklist/checklist/extension.py
    checklist/checklist/urls.py
    checklist/checklist/views.py



Tool: Pyflakes
Processed Files:
    checklist/checklist/extension.py
    checklist/checklist/urls.py
    checklist/checklist/views.py

checklist/checklist/urls.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
checklist/checklist/urls.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 7
 E128 continuation line under-indented for visual indent
```
checklist/checklist/urls.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
checklist/checklist/urls.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 8
 E128 continuation line under-indented for visual indent
```
checklist/checklist/views.py (Diff revision 6)
The issue has been resolved. Show all issues
```
 'redirect' imported but unused
```
checklist/checklist/views.py (Diff revision 6)
The issue has been resolved. Show all issues
```
 'get_object_or_404' imported but unused
```
checklist/checklist/views.py (Diff revision 6)
The issue has been resolved. Show all issues
```
 'render' imported but unused
```
checklist/checklist/views.py (Diff revision 6)
The issue has been resolved. Show all issues
```
 'get_list_or_404' imported but unused
```
checklist/checklist/views.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 32
 E127 continuation line over-indented for visual indent
```

checklist/checklist/views.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Is this returned line over indented?
```

checklist/checklist/extension.py (Diff revision 6)

The issue has been resolved. Show all issues

While you're here, can you fix the alignment? register_resource_for_model should be aligned with unregister_resource_for_model.

checklist/checklist/extension.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Can you add a blank line before this?
```

checklist/checklist/extension.py (Diff revision 6)

The issue has been resolved. Show all issues

ChecklistTemplate should go before ReviewChecklist, and no parens are needed since they fit on one line.

Change Summary:

Fixed indentation, and other format.

Commit:

32a7f6e9cabf7f392ef3f1df48156d8688f186dd

7dea0a94fb3383f64619e583942005f821dc200e

Diff:

Revision 7 (+29 -4)

Show changes

	checklist/checklist/extension.py
	checklist/checklist/urls.py
	checklist/checklist/views.py

Fix it!

Tool: PEP8 Style Checker
Processed Files:
    checklist/checklist/extension.py
    checklist/checklist/urls.py
    checklist/checklist/views.py



Tool: Pyflakes
Processed Files:
    checklist/checklist/extension.py
    checklist/checklist/urls.py
    checklist/checklist/views.py

checklist/checklist/urls.py (Diff revision 7)
An issue was opened. Show all issues
```
Col: 25
 E127 continuation line over-indented for visual indent
```
checklist/checklist/urls.py (Diff revision 7)
An issue was opened. Show all issues
```
Col: 1
 E124 closing bracket does not match visual indentation
```

Status:: Discarded